bbcf4b765e6946a8b6c7110372c4e1cadbfefa44
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 30
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 2 | ||
Rename Method public getImplementationClass(cg CodeGenerator<?>) : T renamed to public createInstance(cg CodeGenerator<?>) : T in class org.apache.drill.exec.compile.CodeCompiler | From | To | |
Rename Method public getImplementationClass(cg CodeGenerator<?>, instanceNumber int) : List<T> renamed to public createInstances(cg CodeGenerator<?>, count int) : List<T> in class org.apache.drill.exec.compile.CodeCompiler | From | To | |
Move Attribute | 11 | ||
Move Attribute public JAVA_COMPILER_DEBUG_OPTION : String from class org.apache.drill.exec.compile.QueryClassLoader to public JAVA_COMPILER_DEBUG_OPTION : String from class org.apache.drill.exec.compile.ClassCompilerSelector | From | To | |
Move Attribute private config : DrillConfig from class org.apache.drill.exec.compile.CodeCompiler to private config : DrillConfig from class org.apache.drill.exec.compile.ClassBuilder | From | To | |
Move Attribute public JAVA_COMPILER_JANINO_MAXSIZE_CONFIG : String from class org.apache.drill.exec.compile.QueryClassLoader to public JAVA_COMPILER_JANINO_MAXSIZE_CONFIG : String from class org.apache.drill.exec.compile.ClassCompilerSelector | From | To | |
Move Attribute public JAVA_COMPILER_JANINO_MAXSIZE_OPTION : String from class org.apache.drill.exec.compile.QueryClassLoader to public JAVA_COMPILER_JANINO_MAXSIZE_OPTION : String from class org.apache.drill.exec.compile.ClassCompilerSelector | From | To | |
Move Attribute public JAVA_COMPILER_OPTION : String from class org.apache.drill.exec.compile.QueryClassLoader to public JAVA_COMPILER_OPTION : String from class org.apache.drill.exec.compile.ClassCompilerSelector | From | To | |
Move Attribute public JAVA_COMPILER_CONFIG : String from class org.apache.drill.exec.compile.QueryClassLoader to public JAVA_COMPILER_CONFIG : String from class org.apache.drill.exec.compile.ClassCompilerSelector | From | To | |
Move Attribute public JAVA_COMPILER_DEBUG : OptionValidator from class org.apache.drill.exec.compile.QueryClassLoader to public JAVA_COMPILER_DEBUG : OptionValidator from class org.apache.drill.exec.compile.ClassCompilerSelector | From | To | |
Move Attribute public JAVA_COMPILER_VALIDATOR : StringValidator from class org.apache.drill.exec.compile.QueryClassLoader to public JAVA_COMPILER_VALIDATOR : StringValidator from class org.apache.drill.exec.compile.ClassCompilerSelector | From | To | |
Move Attribute public MAX_LOADING_CACHE_SIZE_CONFIG : String from class org.apache.drill.exec.ExecConstants to public MAX_LOADING_CACHE_SIZE_CONFIG : String from class org.apache.drill.exec.compile.CodeCompiler | From | To | |
Move Attribute public JAVA_COMPILER_DEBUG_CONFIG : String from class org.apache.drill.exec.compile.QueryClassLoader to public JAVA_COMPILER_DEBUG_CONFIG : String from class org.apache.drill.exec.compile.ClassCompilerSelector | From | To | |
Move Attribute public JAVA_COMPILER_JANINO_MAXSIZE : OptionValidator from class org.apache.drill.exec.compile.QueryClassLoader to public JAVA_COMPILER_JANINO_MAXSIZE : OptionValidator from class org.apache.drill.exec.compile.ClassCompilerSelector | From | To | |
Extract Class | 2 | ||
Extract Class org.apache.drill.exec.compile.ClassBuilder from class org.apache.drill.exec.compile.CodeCompiler | From | To | |
Extract Class org.apache.drill.exec.compile.ClassCompilerSelector from class org.apache.drill.exec.compile.QueryClassLoader | From | To | |
Move Class | 1 | ||
Move Class org.apache.drill.exec.compile.QueryClassLoader.CompilerPolicy moved to org.apache.drill.exec.compile.ClassCompilerSelector.CompilerPolicy | From | To | |
Inline Variable | 1 | ||
Inline Variable g : ClassGenerator<SingleBatchSorter> in method public createNewSorter(context FragmentContext, batch VectorAccessible) : SingleBatchSorter from class org.apache.drill.exec.physical.impl.xsort.ExternalSortBatch | From | To | |
Extract Method | 2 | ||
Extract Method private doCompile(className ClassNames, sourceCode String) : DrillJavaFileObject extracted from protected getByteCode(className ClassNames, sourceCode String) : byte[][] in class org.apache.drill.exec.compile.JDKClassCompiler | From | To | |
Extract Method private doCompile(sourceCode String) : ClassFile[] extracted from protected getByteCode(className ClassNames, sourcecode String) : byte[][] in class org.apache.drill.exec.compile.JaninoClassCompiler | From | To | |
Extract And Move Method | 1 | ||
Extract And Move Method public getImplementationClass(cg CodeGenerator<?>) : Class<?> extracted from public load(cg CodeGenerator<?>) : GeneratedClassEntry in class org.apache.drill.exec.compile.CodeCompiler.Loader & moved to class org.apache.drill.exec.compile.ClassTransformer | From | To | |
Rename Parameter | 2 | ||
Rename Parameter sourcecode : String to sourceCode : String in method protected getByteCode(className ClassNames, sourceCode String) : byte[][] in class org.apache.drill.exec.compile.JaninoClassCompiler | From | To | |
Rename Parameter instanceNumber : int to count : int in method public createInstances(cg CodeGenerator<?>, count int) : List<T> in class org.apache.drill.exec.compile.CodeCompiler | From | To |