c0d5a693ac70c42019b5841eea91252f9eaa7792
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 44
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Attribute | 1 | ||
| Move Attribute private deferredException : DeferredException from class org.apache.drill.exec.ops.FragmentContext to private deferredException : DeferredException from class org.apache.drill.exec.work.fragment.FragmentExecutor | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type def : RecordBatchDef to def : RecordBatchDef.Builder in method public getEmptyBatchWithSchema(isLast boolean, queryId QueryId, sendMajorFragmentId int, sendMinorFragmentId int, receiveMajorFragmentId int, receiveMinorFragmentId int, schema BatchSchema) : FragmentWritableBatch in class org.apache.drill.exec.record.FragmentWritableBatch | From | To | |
| Change Variable Type endpointLatch : CountDownLatch to endpointLatch : ExtendedLatch in method private setupNonRootFragments(fragments Collection<PlanFragment>) : void in class org.apache.drill.exec.work.foreman.Foreman | From | To | |
| Extract Variable | 7 | ||
| Extract Variable time : long in method public setStatus(newStatus FragmentStatus) : boolean from class org.apache.drill.exec.work.foreman.FragmentData | From | To | |
| Extract Variable handle : FragmentHandle in method private updateState(target FragmentState) : boolean from class org.apache.drill.exec.work.fragment.FragmentExecutor | From | To | |
| Extract Variable assignment : DrillbitEndpoint in method package addFragmentStatusTracker(fragment PlanFragment, isRoot boolean) : void from class org.apache.drill.exec.work.foreman.QueryManager | From | To | |
| Extract Variable data : FragmentData in method private updateFragmentStatus(fragmentStatus FragmentStatus) : boolean from class org.apache.drill.exec.work.foreman.QueryManager | From | To | |
| Extract Variable incomingName : String in method private classifyExpr(ex NamedExpression, incoming RecordBatch, result ClassifierResult) : void from class org.apache.drill.exec.physical.impl.project.ProjectRecordBatch | From | To | |
| Extract Variable controller : Controller in method public run() : void from class org.apache.drill.exec.work.WorkManager.StatusThread | From | To | |
| Extract Variable name : String in method private classifyExpr(ex NamedExpression, incoming RecordBatch, result ClassifierResult) : void from class org.apache.drill.exec.physical.impl.project.ProjectRecordBatch | From | To | |
| Inline Variable | 2 | ||
| Inline Variable incomingName : String in method private classifyExpr(ex NamedExpression, incoming RecordBatch, result ClassifierResult) : void from class org.apache.drill.exec.physical.impl.project.ProjectRecordBatch | From | To | |
| Inline Variable name : String in method private classifyExpr(ex NamedExpression, incoming RecordBatch, result ClassifierResult) : void from class org.apache.drill.exec.physical.impl.project.ProjectRecordBatch | From | To | |
| Extract Method | 2 | ||
| Extract Method public throwAndClear() : void extracted from public close() : void in class org.apache.drill.common.DeferredException | From | To | |
| Extract Method public getAndClear() : Exception extracted from public close() : void in class org.apache.drill.common.DeferredException | From | To | |
| Rename Method | 1 | ||
| Rename Method public getRootStatusHandler(context FragmentContext) : RootStatusReporter renamed to public newRootStatusHandler(context FragmentContext) : StatusReporter in class org.apache.drill.exec.work.foreman.QueryManager | From | To | |
| Inline Method | 1 | ||
| Inline Method protected awaitingAllocation(handle FragmentHandle, statusBuilder FragmentStatus.Builder) : void inlined to public stateChanged(handle FragmentHandle, newState FragmentState) : void in class org.apache.drill.exec.work.fragment.AbstractStatusReporter | From | To | |
| Rename Variable | 1 | ||
| Rename Variable ready : boolean to first : boolean in method private setupNonRootFragments(fragments Collection<PlanFragment>) : void in class org.apache.drill.exec.work.foreman.Foreman | From | To | |
| Change Return Type | 4 | ||
| Change Return Type RootStatusReporter to StatusReporter in method public newRootStatusHandler(context FragmentContext) : StatusReporter in class org.apache.drill.exec.work.foreman.QueryManager | From | To | |
| Change Return Type void to boolean in method private updateState(target FragmentState) : boolean in class org.apache.drill.exec.work.fragment.FragmentExecutor | From | To | |
| Change Return Type void to boolean in method public setStatus(newStatus FragmentStatus) : boolean in class org.apache.drill.exec.work.foreman.FragmentData | From | To | |
| Change Return Type void to boolean in method private updateFragmentStatus(fragmentStatus FragmentStatus) : boolean in class org.apache.drill.exec.work.foreman.QueryManager | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute state : AtomicInteger to fragmentState : AtomicReference<FragmentState> in class org.apache.drill.exec.work.fragment.FragmentExecutor | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type acceptExternalEvents : CountDownLatch to acceptExternalEvents : ExtendedLatch in class org.apache.drill.exec.work.foreman.Foreman | From | To | |
| Change Attribute Type state : AtomicInteger to fragmentState : AtomicReference<FragmentState> in class org.apache.drill.exec.work.fragment.FragmentExecutor | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public getState() : FragmentState extracted from package cancelExecutingFragments(drillbitContext DrillbitContext, rootRunner FragmentExecutor) : void in class org.apache.drill.exec.work.foreman.QueryManager & moved to class org.apache.drill.exec.work.foreman.FragmentData | From | To | |
| Extract And Move Method public getExecutorThreadName(fragmentHandle FragmentHandle) : String extracted from public run() : void in class org.apache.drill.exec.work.fragment.FragmentExecutor & moved to class org.apache.drill.exec.proto.helper.QueryIdHelper | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter status : FragmentStatus to newStatus : FragmentStatus in method public setStatus(newStatus FragmentStatus) : boolean in class org.apache.drill.exec.work.foreman.FragmentData | From | To | |
| Rename Parameter to : FragmentState to target : FragmentState in method private updateState(target FragmentState) : boolean in class org.apache.drill.exec.work.fragment.FragmentExecutor | From | To |