cd44d1eb25127f775f7cbfa95eca8ec078caf6fa
Files Diff
- Added: 4
- Removed: 2
- Renamed: 0
- Modified: 67
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Updated | |
| From org.freemarker:freemarker 2.3.26-incubating To 2.3.28 | |
| From org.apache.hbase:hbase-client 2.1.1 To 1.1.1-mapr-1602-m7-5.2.0 | |
| From org.apache.hbase:hbase-client 1.1.1-mapr-1602-m7-5.2.0 To 2.1.1 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 4 | ||
| Change Parameter Type value : int to value : boolean in method public setBoolean(value boolean) : void in class org.apache.drill.exec.vector.accessor.convert.ConvertBooleanToString | From | To | |
| Change Parameter Type defaultValue : Object to defaultValue : String in method private makeNullCol(name String, nullType MajorType, defaultValue String) : ResolvedNullColumn in class org.apache.drill.exec.physical.impl.scan.project.TestNullColumnLoader | From | To | |
| Change Parameter Type defaultValue : Object to defaultValue : String in method public ResolvedNullColumn(name String, type MajorType, defaultValue String, source VectorSource, sourceIndex int) in class org.apache.drill.exec.physical.impl.scan.project.ResolvedNullColumn | From | To | |
| Change Parameter Type literals : List<String> to literals : String[] in method package BooleanType(numericValue int, literals String[]) in class org.apache.drill.common.types.BooleanType | From | To | |
| Move Method | 7 | ||
| Move Method public width() : int from class org.apache.drill.exec.vector.accessor.$ to public width() : int from class org.apache.drill.exec.vector.accessor.writer.BitColumnWriter | From | To | |
| Move Method public setLong(value long) : void from class org.apache.drill.exec.vector.accessor.$ to public setLong(value long) : void from class org.apache.drill.exec.vector.accessor.writer.AbstractFixedWidthWriter.BaseIntWriter | From | To | |
| Move Method public setInt(value int) : void from class org.apache.drill.exec.vector.accessor.$ to public setInt(value int) : void from class org.apache.drill.exec.vector.accessor.writer.BitColumnWriter | From | To | |
| Move Method public setDouble(value double) : void from class org.apache.drill.exec.vector.accessor.$ to public setDouble(value double) : void from class org.apache.drill.exec.vector.accessor.writer.AbstractFixedWidthWriter.BaseIntWriter | From | To | |
| Move Method public vector() : BaseDataValueVector from class org.apache.drill.exec.vector.accessor.$ to public vector() : BaseDataValueVector from class org.apache.drill.exec.vector.accessor.writer.BitColumnWriter | From | To | |
| Move Method public setValue(value Object) : void from class org.apache.drill.exec.vector.accessor.$ to public setValue(value Object) : void from class org.apache.drill.exec.vector.accessor.writer.AbstractFixedWidthWriter.BaseIntWriter | From | To | |
| Move Method public setDecimal(value BigDecimal) : void from class org.apache.drill.exec.vector.accessor.$ to public setDecimal(value BigDecimal) : void from class org.apache.drill.exec.vector.accessor.writer.AbstractFixedWidthWriter.BaseIntWriter | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private projType : ProjectionType from class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.PassThroughColumnTransform to private projType : ProjectionType from class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.AbstractColumnTransform | From | To | |
| Extract Class | 2 | ||
| Extract Class org.apache.drill.exec.vector.accessor.writer.AbstractFixedWidthWriter.BaseIntWriter from class org.apache.drill.exec.vector.accessor.$ | From | To | |
| Extract Class org.apache.drill.exec.vector.accessor.writer.BitColumnWriter from class org.apache.drill.exec.vector.accessor.$ | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.drill.test.rowSet.test.DummyWriterTest renamed to org.apache.drill.test.rowSet.test.TestDummyWriter | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.drill.exec.expr.BooleanType moved to org.apache.drill.common.types.BooleanType | From | To | |
| Extract Variable | 2 | ||
| Extract Variable allowRequiredNulls : boolean in method protected ScanSchemaOptions(builder ScanOrchestratorBuilder) from class org.apache.drill.exec.physical.impl.scan.project.ScanSchemaOrchestrator.ScanSchemaOptions | From | To | |
| Extract Variable majorType : MajorType in method public fromField(field MaterializedField) : ColumnMetadata from class org.apache.drill.exec.record.metadata.MetadataUtils | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type colSchema : MaterializedField to colSchema : ColumnMetadata in method public NullColumnLoader(vectorCache ResultVectorCache, defns List<? extends NullColumnSpec>, nullType MajorType, allowRequired boolean) in class org.apache.drill.exec.physical.impl.scan.project.NullColumnLoader | From | To | |
| Extract Method | 13 | ||
| Extract Method private enableSchemaSupport() : void extracted from public testMultiFragmentStrictSchema() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Extract Method private enableSchemaSupport() : void extracted from public testRequiredColDefault() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Extract Method private enableSchemaSupport() : void extracted from public testMissingRequiredCol() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Extract Method private enableSchemaSupport() : void extracted from public testBasicSchema() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Extract Method private enableSchemaSupport() : void extracted from public testWildcardV3LenientSchema() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Extract Method public fillOffset(newOffset int) : void extracted from protected fillEmpties(valueIndex int) : void in class org.apache.drill.exec.vector.accessor.writer.OffsetVectorWriterImpl | From | To | |
| Extract Method private enableSchemaSupport() : void extracted from public testWildcardV3StrictSchema() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Extract Method private enableSchemaSupport() : void extracted from public testDateColDefault() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Extract Method private writeOffset(width int) : int extracted from protected prepareWrite(width int) : int in class org.apache.drill.exec.vector.accessor.writer.BaseVarWidthWriter | From | To | |
| Extract Method private enableSchemaSupport() : void extracted from public testMultiFileSchemaMissingCol() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Extract Method private enableSchemaSupport() : void extracted from public testSchemaExplicitSort() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Extract Method public isNumericType(type MinorType) : boolean extracted from public isNumericType(type MajorType) : boolean in class org.apache.drill.common.types.Types | From | To | |
| Extract Method private enableSchemaSupport() : void extracted from public testMultiFileSchema() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Rename Method | 3 | ||
| Rename Method protected prepareWrite(writeIndex int) : int renamed to public prepareFill() : int in class org.apache.drill.exec.vector.accessor.writer.OffsetVectorWriterImpl | From | To | |
| Rename Method private resetSchema() : void renamed to private resetSchemaSupport() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema | From | To | |
| Rename Method public setInt(value int) : void renamed to public setBoolean(value boolean) : void in class org.apache.drill.exec.vector.accessor.convert.ConvertBooleanToString | From | To | |
| Pull Up Method | 5 | ||
| Pull Up Method public inputSchema() : ColumnMetadata from class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.PassThroughColumnTransform to public inputSchema() : ColumnMetadata from class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.AbstractColumnTransform | From | To | |
| Pull Up Method public projectionType() : ProjectionType from class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.PassThroughColumnTransform to public projectionType() : ProjectionType from class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.AbstractColumnTransform | From | To | |
| Pull Up Method private enableSchema(enable boolean) : void from class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema to protected enableSchema(enable boolean) : void from class org.apache.drill.exec.store.easy.text.compliant.BaseCsvTest | From | To | |
| Pull Up Method public PassThroughColumnTransform(colDefn ColumnMetadata, projType ProjectionType) from class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.PassThroughColumnTransform to public AbstractColumnTransform(colDefn ColumnMetadata, projType ProjectionType, outputDefn ColumnMetadata) from class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.AbstractColumnTransform | From | To | |
| Pull Up Method public outputSchema() : ColumnMetadata from class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.PassThroughColumnTransform to public outputSchema() : ColumnMetadata from class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.AbstractColumnTransform | From | To | |
| Inline Method | 2 | ||
| Inline Method protected noOpTransform(inputSchema ColumnMetadata, projType ProjectionType) : ColumnTransform inlined to public transform(inputSchema ColumnMetadata, projType ProjectionType) : ColumnTransform in class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl | From | To | |
| Change Return Type | 4 | ||
| Change Return Type Object to String in method public defaultValue() : String in class org.apache.drill.exec.physical.impl.scan.project.ResolvedNullColumn | From | To | |
| Change Return Type MaterializedField to ColumnMetadata in method private selectType(defn NullColumnSpec) : ColumnMetadata in class org.apache.drill.exec.physical.impl.scan.project.NullColumnLoader | From | To | |
| Change Return Type Object to String in method public defaultValue() : String in class org.apache.drill.exec.physical.impl.scan.project.NullColumnLoader.NullColumnSpec | From | To | |
| Change Return Type List<String> to String[] in method public getLiterals() : String[] in class org.apache.drill.common.types.BooleanType | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.AbstractColumnTransform from classes [org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl.PassThroughColumnTransform] | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type literals : List<String> to literals : String[] in class org.apache.drill.common.types.BooleanType | From | To | |
| Change Attribute Type defaultValue : Object to defaultValue : String in class org.apache.drill.exec.physical.impl.scan.project.ResolvedNullColumn | From | To | |
| Extract And Move Method | 4 | ||
| Extract And Move Method protected resetSchema() : void extracted from private resetSchema() : void in class org.apache.drill.exec.store.easy.text.compliant.TestCsvWithSchema & moved to class org.apache.drill.exec.store.easy.text.compliant.BaseCsvTest | From | To | |
| Extract And Move Method public factory(converterClass Class<? extends AbstractWriteConverter>, properties Map<String,String>) : ColumnConversionFactory extracted from public transform(inputSchema ColumnMetadata, projType ProjectionType) : ColumnTransform in class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformerImpl & moved to class org.apache.drill.exec.vector.accessor.convert.StandardConversions | From | To | |
| Extract And Move Method public newInstance(conversionClass Class<? extends AbstractWriteConverter>, baseWriter ScalarWriter, properties Map<String,String>) : AbstractWriteConverter extracted from public newWriter(baseWriter ScalarWriter) : AbstractWriteConverter in class org.apache.drill.exec.vector.accessor.convert.StandardConversions.SimpleWriterConverterFactory & moved to class org.apache.drill.exec.vector.accessor.convert.StandardConversions | From | To | |
| Extract And Move Method public newInstance(conversionClass Class<? extends AbstractWriteConverter>, baseWriter ScalarWriter, properties Map<String,String>) : AbstractWriteConverter extracted from public newWriter(baseWriter ScalarWriter) : AbstractWriteConverter in class org.apache.drill.test.rowSet.test.TestColumnConverter.ConversionTestFixture & moved to class org.apache.drill.exec.vector.accessor.convert.StandardConversions | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter valueIndex : int to fillCount : int in method protected fillEmpties(fillCount int) : void in class org.apache.drill.exec.vector.accessor.writer.OffsetVectorWriterImpl | From | To |