drill ce8bbc01cfde7d714185919be2ca2923d19ea890

ce8bbc01cfde7d714185919be2ca2923d19ea890

Files Diff

Added: 14
Removed: 0
Renamed: 0
Modified: 47

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method public close() : void renamed to public disposeSaslServer() : void in class org.apache.drill.exec.rpc.AbstractServerConnection	From	To
Rename Method public close() : void renamed to public disposeSaslClient() : void in class org.apache.drill.exec.rpc.AbstractClientConnection	From	To
Rename Method public close() : void renamed to public disposeSaslClient() : void in class org.apache.drill.exec.rpc.control.ControlConnection	From	To
Change Parameter Type	4
Change Parameter Type context : SaslChallengeContext to context : SaslChallengeContext<CC> in method public process(context SaslChallengeContext<CC>) : SaslMessage in class org.apache.drill.exec.rpc.security.AuthenticationOutcomeListener.SaslChallengeProcessor	From	To
Change Parameter Type context : SaslChallengeContext to context : SaslChallengeContext<CC> in method public process(context SaslChallengeContext<CC>) : SaslMessage in class org.apache.drill.exec.rpc.security.AuthenticationOutcomeListener.SaslSuccessProcessor	From	To
Change Parameter Type remoteAddress : String to connection : S in method private handleAuthFailure(connection S, sender ResponseSender, e Exception, saslResponseType T) : void in class org.apache.drill.exec.rpc.security.ServerAuthenticationHandler	From	To
Change Parameter Type context : SaslChallengeContext to context : SaslChallengeContext<CC> in method public process(context SaslChallengeContext<CC>) : SaslMessage in class org.apache.drill.exec.rpc.security.AuthenticationOutcomeListener.SaslInProgressProcessor	From	To
Move Method	12
Move Method public stopKdc() : void from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to public stopKdc() : void from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method private setupUsers(keytabDir File) : void from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private setupUsers(keytabDir File) : void from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method public setupKdc() : void from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to public setupKdc() : void from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method private setupUsers(keytabDir File) : void from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private setupUsers(keytabDir File) : void from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method public stopKdc() : void from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to public stopKdc() : void from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method private deleteIfExists(file File) : void from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private deleteIfExists(file File) : void from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method private setupUser(kdc SimpleKdcServer, keytab File, principal String) : void from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private setupUser(kdc SimpleKdcServer, keytab File, principal String) : void from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method private setupUser(kdc SimpleKdcServer, keytab File, principal String) : void from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private setupUser(kdc SimpleKdcServer, keytab File, principal String) : void from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method private getFreePort() : int from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private getFreePort() : int from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method private getFreePort() : int from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private getFreePort() : int from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method public setupKdc() : void from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to public setupKdc() : void from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Method private deleteIfExists(file File) : void from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private deleteIfExists(file File) : void from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute	24
Move Attribute private CLIENT_SHORT_NAME : String from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to public CLIENT_SHORT_NAME : String from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private SERVER_PRINCIPAL : String from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to public SERVER_PRINCIPAL : String from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private logger : org.slf4j.Logger from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private logger : org.slf4j.Logger from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private serverKeytab : File from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to public serverKeytab : File from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private HOSTNAME : String from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private HOSTNAME : String from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private kdcStarted : boolean from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private kdcStarted : boolean from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private HOSTNAME : String from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private HOSTNAME : String from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private kdcStarted : boolean from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private kdcStarted : boolean from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private workspace : File from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to public workspace : File from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private kdcDir : File from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private kdcDir : File from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private SERVER_PRINCIPAL : String from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to public SERVER_PRINCIPAL : String from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private kdcPort : int from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private kdcPort : int from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private kdcDir : File from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private kdcDir : File from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private workspace : File from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to public workspace : File from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private logger : org.slf4j.Logger from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private logger : org.slf4j.Logger from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private clientKeytab : File from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to public clientKeytab : File from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private keytabDir : File from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private keytabDir : File from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private kdc : SimpleKdcServer from class org.apache.drill.exec.rpc.data.TestBitBitKerberos to private kdc : SimpleKdcServer from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private kdc : SimpleKdcServer from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private kdc : SimpleKdcServer from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private keytabDir : File from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private keytabDir : File from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private CLIENT_PRINCIPAL : String from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to public CLIENT_PRINCIPAL : String from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute private serverKeytab : File from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to public serverKeytab : File from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Move Attribute protected TIMEOUT_HANDLER : String from class org.apache.drill.exec.rpc.BasicServer to public TIMEOUT_HANDLER : String from class org.apache.drill.exec.rpc.RpcConstants	From	To
Move Attribute private kdcPort : int from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos to private kdcPort : int from class org.apache.drill.exec.rpc.security.KerberosHelper	From	To
Extract Class	2
Extract Class org.apache.drill.exec.rpc.security.KerberosHelper from class org.apache.drill.exec.rpc.user.security.TestUserBitKerberos	From	To
Extract Class org.apache.drill.exec.rpc.security.KerberosHelper from class org.apache.drill.exec.rpc.data.TestBitBitKerberos	From	To
Rename Attribute	1
Rename Attribute saslClient : SaslClient to connection : C in class org.apache.drill.exec.rpc.security.AuthenticationOutcomeListener.SaslChallengeContext	From	To
Extract Variable	4
Extract Variable connection : S in method private handleSuccess(context SaslResponseContext<S,T>, challenge SaslMessage.Builder, saslServer SaslServer) : void from class org.apache.drill.exec.rpc.security.ServerAuthenticationHandler	From	To
Extract Variable config : DrillConfig in method package UserConnectionConfig(allocator BufferAllocator, context BootStrapContext, handler UserServerRequestHandler) from class org.apache.drill.exec.rpc.user.UserConnectionConfig	From	To
Extract Variable authProvider : AuthenticatorProvider in method protected BitConnectionConfig(allocator BufferAllocator, context BootStrapContext) from class org.apache.drill.exec.rpc.BitConnectionConfig	From	To
Extract Variable authProvider : AuthenticatorProvider in method package UserConnectionConfig(allocator BufferAllocator, context BootStrapContext, handler UserServerRequestHandler) from class org.apache.drill.exec.rpc.user.UserConnectionConfig	From	To
Inline Variable	1
Inline Variable handshake : UserToBitHandshake in method public connect(endpoint DrillbitEndpoint, properties DrillProperties, credentials UserCredentials) : void from class org.apache.drill.exec.rpc.user.UserClient	From	To
Change Attribute Type	1
Change Attribute Type saslClient : SaslClient to connection : C in class org.apache.drill.exec.rpc.security.AuthenticationOutcomeListener.SaslChallengeContext	From	To
Extract And Move Method	1
Extract And Move Method public setEncryption(encrypted boolean) : void extracted from protected validateHandshake(inbound BitToUserHandshake) : void in class org.apache.drill.exec.rpc.user.UserClient & moved to class org.apache.drill.exec.rpc.AbstractRemoteConnection	From	To
Rename Parameter	1
Rename Parameter remoteAddress : String to connection : S in method private handleAuthFailure(connection S, sender ResponseSender, e Exception, saslResponseType T) : void in class org.apache.drill.exec.rpc.security.ServerAuthenticationHandler	From	To

ce8bbc01cfde7d714185919be2ca2923d19ea890

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: