e9065b55ea560e7f737d6fcb4948f9e945b9b14f
Files Diff
- Added: 5
- Removed: 0
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private initFromMetadataCache(selection FileSelection, metaFilePath Path) : FileSelection renamed to private expandSelectionFromMetadataCache(selection FileSelection, metaFilePath Path) : FileSelection in class org.apache.drill.exec.store.parquet.ParquetGroupScan | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type path : String to path : Path in method public readMetadataDirs(fs FileSystem, path Path, metaContext MetadataContext, formatConfig ParquetFormatConfig) : ParquetTableMetadataDirs in class org.apache.drill.exec.store.parquet.Metadata | From | To | |
| Change Parameter Type path : String to path : Path in method public readBlockMeta(fs FileSystem, path Path, metaContext MetadataContext, formatConfig ParquetFormatConfig) : ParquetTableMetadataBase in class org.apache.drill.exec.store.parquet.Metadata | From | To | |
| Change Parameter Type path : String to path : Path in method private readBlockMeta(path Path, dirsOnly boolean, metaContext MetadataContext) : void in class org.apache.drill.exec.store.parquet.Metadata | From | To | |
| Rename Variable | 3 | ||
| Rename Variable relative_path_metadata_t2 : String to absolutePathsMetadataT2 : String in method public testMetadataCacheAbsolutePaths() : void in class org.apache.drill.exec.store.parquet.TestParquetMetadataCache | From | To | |
| Rename Variable parentDirString : String to metadataParentDirPath : String in method private readBlockMeta(path Path, dirsOnly boolean, metaContext MetadataContext) : void in class org.apache.drill.exec.store.parquet.Metadata | From | To | |
| Rename Variable relative_path_metadata_t1 : String to absolutePathsMetadataT1 : String in method public testMetadataCacheAbsolutePaths() : void in class org.apache.drill.exec.store.parquet.TestParquetMetadataCache | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [selectionRoot : String, cacheFileRoot : String] to selection : FileSelection in method public ParquetGroupScan(userName String, selection FileSelection, formatPlugin ParquetFormatPlugin, columns List<SchemaPath>, filter LogicalExpression) in class org.apache.drill.exec.store.parquet.ParquetGroupScan | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable p : Path to path : Path in method private readBlockMeta(path Path, dirsOnly boolean, metaContext MetadataContext) : void in class org.apache.drill.exec.store.parquet.Metadata | From | To | |
| Extract Variable | 2 | ||
| Extract Variable query : String in method public testMetadataCacheAbsolutePaths() : void from class org.apache.drill.exec.store.parquet.TestParquetMetadataCache | From | To | |
| Extract Variable expectedRowCount : int in method public testMetadataCacheAbsolutePaths() : void from class org.apache.drill.exec.store.parquet.TestParquetMetadataCache | From | To | |
| Extract Method | 2 | ||
| Extract Method private checkForInitializingEntriesWithSelectionRoot() : boolean extracted from public ParquetGroupScan(userName String, selection FileSelection, formatPlugin ParquetFormatPlugin, selectionRoot String, cacheFileRoot String, columns List<SchemaPath>, filter LogicalExpression) in class org.apache.drill.exec.store.parquet.ParquetGroupScan | From | To | |
| Extract Method protected copyMetaDataCacheToTempWithReplacements(srcFileOnClassPath String, destFolderInTmp String, metaFileName String, customStringReplacement String) : void extracted from protected copyMetaDataCacheToTempReplacingInternalPaths(srcFileOnClassPath String, destFolderInTmp String, metaFileName String) : void in class org.apache.drill.BaseTestQuery | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method public setMetadataCacheCorrupted(metadataCacheCorrupted boolean) : void extracted from private readBlockMeta(path String, dirsOnly boolean, metaContext MetadataContext) : void in class org.apache.drill.exec.store.parquet.Metadata & moved to class org.apache.drill.exec.store.dfs.MetadataContext | From | To | |
| Extract And Move Method public areCorruptDatesAutoCorrected() : boolean extracted from private initFromMetadataCache(selection FileSelection, metaFilePath Path) : FileSelection in class org.apache.drill.exec.store.parquet.ParquetGroupScan & moved to class org.apache.drill.exec.store.parquet.ParquetFormatConfig | From | To | |
| Extract And Move Method public areCorruptDatesAutoCorrected() : boolean extracted from private getParquetFileMetadata_v3(parquetTableMetadata ParquetTableMetadata_v3, file FileStatus) : ParquetFileMetadata_v3 in class org.apache.drill.exec.store.parquet.Metadata & moved to class org.apache.drill.exec.store.parquet.ParquetFormatConfig | From | To |