ee399317a1faa44e18aedcb11cfa5d4d5c0941aa
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 63
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public plainOldJavaCapable(flag boolean) : void renamed to public plainJavaCapable(flag boolean) : void in class org.apache.drill.exec.expr.CodeGenerator | From | To | |
| Rename Method public isPlainOldJava() : boolean renamed to public isPlainJava() : boolean in class org.apache.drill.exec.expr.CodeGenerator | From | To | |
| Rename Method public preferPlainOldJava(flag boolean) : void renamed to public preferPlainJava(flag boolean) : void in class org.apache.drill.exec.expr.CodeGenerator | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type loader : QueryClassLoader to asPoj : boolean in method private compilationInnerClass(asPoj boolean) : void in class org.apache.drill.exec.compile.TestClassTransformation | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private transformer : ClassTransformer from class org.apache.drill.exec.compile.CodeCompiler to private transformer : ClassTransformer from class org.apache.drill.exec.compile.CodeCompiler.CodeGenCompiler | From | To | |
| Move Attribute private classBuilder : ClassBuilder from class org.apache.drill.exec.compile.CodeCompiler to private classBuilder : ClassBuilder from class org.apache.drill.exec.compile.CodeCompiler.CodeGenCompiler | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.drill.exec.compile.CodeCompiler.CodeGenCompiler from class org.apache.drill.exec.compile.CodeCompiler | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute usePlainOldJava : boolean to usePlainJava : boolean in class org.apache.drill.exec.expr.CodeGenerator | From | To | |
| Rename Attribute plainOldJavaCapable : boolean to plainJavaCapable : boolean in class org.apache.drill.exec.expr.CodeGenerator | From | To | |
| Change Variable Type | 10 | ||
| Change Variable Type w : VectorWrapper to w : VectorWrapper<?> in method public buildSchema() : void in class org.apache.drill.exec.physical.impl.aggregate.HashAggBatch | From | To | |
| Change Variable Type iter : Iterator to iter : Iterator<Path> in method public close() : void in class org.apache.drill.exec.physical.impl.xsort.ExternalSortBatch | From | To | |
| Change Variable Type gen : CodeGenerator to gen : CodeGenerator<Object> in method private mockFragmentContext(initReservation long, maxAllocation long) : void in class org.apache.drill.exec.physical.unit.PhysicalOpUnitTestBase | From | To | |
| Change Variable Type gen : ClassGenerator to gen : CodeGenerator<Object> in method private mockFragmentContext(initReservation long, maxAllocation long) : void in class org.apache.drill.exec.physical.unit.PhysicalOpUnitTestBase | From | To | |
| Change Variable Type vw : VectorWrapper to vw : VectorWrapper<?> in method public innerNext() : IterOutcome in class org.apache.drill.exec.physical.impl.mergereceiver.MergingRecordBatch | From | To | |
| Change Variable Type w : VectorWrapper to w : VectorWrapper<?> in method public innerNext() : IterOutcome in class org.apache.drill.exec.physical.impl.TopN.TopNBatch | From | To | |
| Change Variable Type w : VectorWrapper to w : VectorWrapper<?> in method public buildSchema() : void in class org.apache.drill.exec.physical.impl.TopN.TopNBatch | From | To | |
| Change Variable Type w : VectorWrapper to w : VectorWrapper<?> in method private allocateOutgoing() : void in class org.apache.drill.exec.physical.impl.mergereceiver.MergingRecordBatch | From | To | |
| Extract Variable | 3 | ||
| Extract Variable codeGen : CodeGenerator<Projector> in method protected setupNewSchema() : boolean from class org.apache.drill.exec.physical.impl.project.ProjectRecordBatch | From | To | |
| Extract Variable innerClass : Class<?> in method package ClassGenerator(codeGenerator CodeGenerator<T>, mappingSet MappingSet, signature SignatureHolder, eval EvaluationVisitor, clazz JDefinedClass, model JCodeModel, optionManager OptionManager) from class org.apache.drill.exec.expr.ClassGenerator | From | To | |
| Extract Variable mods : int in method package ClassGenerator(codeGenerator CodeGenerator<T>, mappingSet MappingSet, signature SignatureHolder, eval EvaluationVisitor, clazz JDefinedClass, model JCodeModel, optionManager OptionManager) from class org.apache.drill.exec.expr.ClassGenerator | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type templateClassDefinition : TemplateClassDefinition to templateClassDefinition : TemplateClassDefinition<Projector> in class org.apache.drill.exec.physical.unit.PhysicalOpUnitTestBase | From | To | |
| Extract Method | 5 | ||
| Extract Method protected newDoubleInner() : DoubleInner extracted from public doDouble() : void in class org.apache.drill.exec.compile.ExampleTemplateWithInner.TheInnerClass | From | To | |
| Extract Method protected newBatchHolder(index int) : BatchHolder extracted from private addBatchHolder() : BatchHolder in class org.apache.drill.exec.physical.impl.common.HashTableTemplate | From | To | |
| Extract Method protected newTheInnerClass() : TheInnerClass extracted from public doInsideOutside() : void in class org.apache.drill.exec.compile.ExampleTemplateWithInner | From | To | |
| Extract Method protected newOutgoingRecordBatch(stats OperatorStats, operator HashPartitionSender, tunnel AccountingDataTunnel, context FragmentContext, allocator BufferAllocator, oppositeMinorFragmentId int) : OutgoingRecordBatch extracted from public setup(context FragmentContext, incoming RecordBatch, popConfig HashPartitionSender, stats OperatorStats, oContext OperatorContext, start int, end int) : void in class org.apache.drill.exec.physical.impl.partitionsender.PartitionerTemplate | From | To | |
| Extract Method protected newBatchHolder() : BatchHolder extracted from private addBatchHolder() : void in class org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate | From | To | |
| Inline Variable | 1 | ||
| Inline Variable cacheMaxSize : int in method public CodeCompiler(config DrillConfig, optionManager OptionManager) from class org.apache.drill.exec.compile.CodeCompiler | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter loader : QueryClassLoader to asPoj : boolean in method private compilationInnerClass(asPoj boolean) : void in class org.apache.drill.exec.compile.TestClassTransformation | From | To |