f481a7c2833b8c7ebabe02a37590cdd3e559ca5e
Files Diff
- Added: 9
- Removed: 0
- Renamed: 0
- Modified: 35
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public getRecordsPerBatch() : int from class org.apache.drill.exec.store.parquet.columnreaders.ParquetSchema to public getCurrentRecordsPerBatch() : int from class org.apache.drill.exec.store.parquet.columnreaders.batchsizing.RecordBatchSizerManager | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractPageEntryReader from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractEntryReader | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type columnPrecInfo : ColumnPrecisionInfo to containerCallback : VarLenColumnBulkInputCallback in method package VarLenAbstractEntryReader(buffer ByteBuffer, entry VarLenColumnBulkEntry, containerCallback VarLenColumnBulkInputCallback) in class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractEntryReader | From | To | |
| Change Parameter Type containerCallbackInput : VLColumnBulkInputCallback to containerCallbackInput : VarLenColumnBulkInputCallback in method package VarLenBulkPageReader(pageInfoInput PageDataInfo, columnPrecInfoInput ColumnPrecisionInfo, containerCallbackInput VarLenColumnBulkInputCallback, fieldOverflowStateContainer FieldOverflowStateContainer) in class org.apache.drill.exec.store.parquet.columnreaders.VarLenBulkPageReader | From | To | |
| Push Down Attribute | 2 | ||
| Push Down Attribute protected columnPrecInfo : ColumnPrecisionInfo from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractEntryReader to protected columnPrecInfo : ColumnPrecisionInfo from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractPageEntryReader | From | To | |
| Push Down Attribute protected pageInfo : PageDataInfo from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractEntryReader to protected pageInfo : PageDataInfo from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractPageEntryReader | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private recordsPerBatch : int from class org.apache.drill.exec.store.parquet.columnreaders.ParquetSchema to private recordsPerBatch : int from class org.apache.drill.exec.store.parquet.columnreaders.batchsizing.RecordBatchSizerManager | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.drill.exec.store.parquet.columnreaders.VarLenColumnBulkInput.VLColumnBulkInputCallback renamed to org.apache.drill.exec.store.parquet.columnreaders.VarLenColumnBulkInput.VarLenColumnBulkInputCallback | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type result : VarLenBulkEntry to result : VarLenColumnBulkEntry in method public next() : VarLenBulkEntry in class org.apache.drill.exec.store.parquet.columnreaders.VarLenColumnBulkInput | From | To | |
| Extract Variable | 1 | ||
| Extract Variable batchNumRecords : int in method private readRecordsInBulk(recordsToReadInThisPass int) : int from class org.apache.drill.exec.store.parquet.columnreaders.VarLenBinaryReader | From | To | |
| Extract Method | 1 | ||
| Extract Method private getRemainingRecords() : int extracted from public next() : VarLenBulkEntry in class org.apache.drill.exec.store.parquet.columnreaders.VarLenColumnBulkInput | From | To | |
| Rename Method | 3 | ||
| Rename Method public getColumnReaders() : List<ColumnReader<?>> renamed to public getFixedLenColumnReaders() : List<ColumnReader<?>> in class org.apache.drill.exec.store.parquet.columnreaders.ReadState | From | To | |
| Rename Method public getRecordsToRead() : long renamed to public getTotalRecordsToRead() : long in class org.apache.drill.exec.store.parquet.columnreaders.ReadState | From | To | |
| Rename Method private getVLEntry(valuesToRead int) : VarLenColumnBulkEntry renamed to private getVarLenEntry(valuesToRead int) : VarLenColumnBulkEntry in class org.apache.drill.exec.store.parquet.columnreaders.VarLenBulkPageReader | From | To | |
| Push Down Method | 3 | ||
| Push Down Method protected bulkProcess() : boolean from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractEntryReader to protected bulkProcess() : boolean from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractPageEntryReader | From | To | |
| Push Down Method protected load(force boolean) : boolean from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractEntryReader to protected load(force boolean) : boolean from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractPageEntryReader | From | To | |
| Push Down Method protected remainingPageData() : int from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractEntryReader to protected remainingPageData() : int from class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractPageEntryReader | From | To | |
| Rename Variable | 2 | ||
| Rename Variable data_len : int to dataLen : int in method private getEntryBulk(valuesToRead int) : VarLenColumnBulkEntry in class org.apache.drill.exec.store.parquet.columnreaders.VarLenEntryReader | From | To | |
| Rename Variable recordsReadInCurrentPass : int to prevReadColumns : int in method private readRecordsInBulk(recordsToReadInThisPass int) : int in class org.apache.drill.exec.store.parquet.columnreaders.VarLenBinaryReader | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractPageEntryReader from classes [org.apache.drill.exec.store.parquet.columnreaders.VarLenEntryDictionaryReader, org.apache.drill.exec.store.parquet.columnreaders.VarLenEntryReader, org.apache.drill.exec.store.parquet.columnreaders.VarLenFixedEntryReader, org.apache.drill.exec.store.parquet.columnreaders.VarLenNullableDictionaryReader, org.apache.drill.exec.store.parquet.columnreaders.VarLenNullableEntryReader, org.apache.drill.exec.store.parquet.columnreaders.VarLenNullableFixedEntryReader] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute columnReaders : List<ColumnReader<?>> to fixedLenColumnReaders : List<ColumnReader<?>> in class org.apache.drill.exec.store.parquet.columnreaders.ReadState | From | To | |
| Rename Attribute numRecordsToRead : long to totalNumRecordsToRead : long in class org.apache.drill.exec.store.parquet.columnreaders.ReadState | From | To | |
| Rename Attribute columnPrecInfo : ColumnPrecisionInfo to containerCallback : VarLenColumnBulkInputCallback in class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractEntryReader | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type columnPrecInfo : ColumnPrecisionInfo to containerCallback : VarLenColumnBulkInputCallback in class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractEntryReader | From | To | |
| Change Attribute Type callback : VLColumnBulkInputCallback to callback : VarLenColumnBulkInputCallback in class org.apache.drill.exec.store.parquet.columnreaders.VarLenColumnBulkInput | From | To | |
| Change Attribute Type containerCallback : VLColumnBulkInputCallback to containerCallback : VarLenColumnBulkInputCallback in class org.apache.drill.exec.store.parquet.columnreaders.VarLenBulkPageReader | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method package setReadFromPage(readFromPage boolean) : void extracted from package getEntry(valuesToRead int) : VarLenColumnBulkEntry in class org.apache.drill.exec.store.parquet.columnreaders.VarLenBulkPageReader & moved to class org.apache.drill.exec.store.parquet.columnreaders.VarLenColumnBulkEntry | From | To | |
| Extract And Move Method public setValuesReadInCurrentPass(valuesReadInCurrentBatch int) : void extracted from public readFields(recordsToReadInThisPass long) : long in class org.apache.drill.exec.store.parquet.columnreaders.VarLenBinaryReader & moved to class org.apache.drill.exec.store.parquet.columnreaders.ReadState | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter columnPrecInfo : ColumnPrecisionInfo to containerCallback : VarLenColumnBulkInputCallback in method package VarLenAbstractEntryReader(buffer ByteBuffer, entry VarLenColumnBulkEntry, containerCallback VarLenColumnBulkInputCallback) in class org.apache.drill.exec.store.parquet.columnreaders.VarLenAbstractEntryReader | From | To |