f8e5e613ff001da79377caea9c8e453e5619499a
Files Diff
- Added: 3
- Removed: 1
- Renamed: 0
- Modified: 30
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private setExceptions(controlsString String) : void renamed to private setControls(controls String) : void in class org.apache.drill.exec.server.TestDrillbitResilience | From | To | |
| Pull Up Method | 5 | ||
| Pull Up Method public ControlHandlerImpl(bee WorkerBee) from class org.apache.drill.exec.work.batch.ControlHandlerImpl to public ControlMessageHandler(bee WorkerBee) from class org.apache.drill.exec.work.batch.ControlMessageHandler | From | To | |
| Pull Up Method private receivingFragmentFinished(finishedReceiver FinishedReceiver) : Ack from class org.apache.drill.exec.work.batch.ControlHandlerImpl to private receivingFragmentFinished(finishedReceiver FinishedReceiver) : Ack from class org.apache.drill.exec.work.batch.ControlMessageHandler | From | To | |
| Pull Up Method public handle(connection ControlConnection, rpcType int, pBody ByteBuf, dBody ByteBuf) : Response from class org.apache.drill.exec.work.batch.ControlHandlerImpl to public handle(connection ControlConnection, rpcType int, pBody ByteBuf, dBody ByteBuf) : Response from class org.apache.drill.exec.work.batch.ControlMessageHandler | From | To | |
| Pull Up Method public startNewRemoteFragment(fragment PlanFragment) : void from class org.apache.drill.exec.work.batch.ControlHandlerImpl to private startNewRemoteFragment(fragment PlanFragment) : void from class org.apache.drill.exec.work.batch.ControlMessageHandler | From | To | |
| Pull Up Method public cancelFragment(handle FragmentHandle) : Ack from class org.apache.drill.exec.work.batch.ControlHandlerImpl to private cancelFragment(handle FragmentHandle) : Ack from class org.apache.drill.exec.work.batch.ControlMessageHandler | From | To | |
| Rename Variable | 2 | ||
| Rename Variable pauseMillis : long to expectedDuration : long in method public pauseInjected() : void in class org.apache.drill.exec.testing.TestPauseInjection | From | To | |
| Rename Variable time : long to actualDuration : long in method public pauseInjected() : void in class org.apache.drill.exec.testing.TestPauseInjection | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute private bee : WorkerBee from class org.apache.drill.exec.work.batch.ControlHandlerImpl to private bee : WorkerBee from class org.apache.drill.exec.work.batch.ControlMessageHandler | From | To | |
| Pull Up Attribute private logger : org.slf4j.Logger from class org.apache.drill.exec.work.batch.ControlHandlerImpl to private logger : org.slf4j.Logger from class org.apache.drill.exec.work.batch.ControlMessageHandler | From | To | |
| Change Return Type | 3 | ||
| Change Return Type ExecutionControlsInjector to void in method public injectChecked(executionControls ExecutionControls, desc String, exceptionClass Class<T>) : void in class org.apache.drill.exec.testing.ExecutionControlsInjector | From | To | |
| Change Return Type ExecutionControlsInjector to void in method public injectUnchecked(executionControls ExecutionControls, desc String) : void in class org.apache.drill.exec.testing.ExecutionControlsInjector | From | To | |
| Change Return Type ExecutionControlsInjector to void in method public injectPause(executionControls ExecutionControls, desc String, logger Logger) : void in class org.apache.drill.exec.testing.ExecutionControlsInjector | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private millis : long from class org.apache.drill.exec.testing.PauseInjection to private millis : long from class org.apache.drill.exec.testing.TestPauseInjection.ResumingThread | From | To | |
| Rename Class | 2 | ||
| Rename Class org.apache.drill.exec.rpc.control.ControlTunnel.CancelFragment renamed to org.apache.drill.exec.rpc.control.ControlTunnel.SignalFragment | From | To | |
| Rename Class org.apache.drill.exec.work.foreman.QueryManager.CancelListener renamed to org.apache.drill.exec.work.foreman.QueryManager.SignalListener | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type ex : Exception to ex : Pointer<Exception> in class org.apache.drill.exec.server.TestDrillbitResilience.WaitUntilCompleteListener | From | To | |
| Change Attribute Type latch : CountDownLatch to latch : ExtendedLatch in class org.apache.drill.exec.server.TestDrillbitResilience.WaitUntilCompleteListener | From | To | |
| Inline Variable | 1 | ||
| Inline Variable e : Exception in method private assertFailsWithException(controls String, exceptionClass Class<? extends Throwable>, exceptionDesc String) : void from class org.apache.drill.exec.server.TestDrillbitResilience | From | To | |
| Extract Method | 1 | ||
| Extract Method private assertCompleteState(result Pair<QueryState,Exception>, expectedState QueryState) : void extracted from public successfullyCompletes() : void in class org.apache.drill.exec.server.TestDrillbitResilience | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter value : Ack to ack : Ack in method public success(ack Ack, buf ByteBuf) : void in class org.apache.drill.exec.work.foreman.QueryManager.SignalListener | From | To | |
| Rename Parameter controlsString : String to controls : String in method private setControls(controls String) : void in class org.apache.drill.exec.server.TestDrillbitResilience | From | To |