27387f06f643dc9a4080913f7468dfac9742ce6c
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 2 | ||
Rename Method private internal_normalize() : void renamed to private internalNormalize() : void in class org.kie.dmn.validation.dtanalysis.model.DTAnalysis | From | To | |
Rename Method private validateSchemaV1_1(s Source) : List<DMNMessage> renamed to private validateSchema(s Source, schema Schema) : List<DMNMessage> in class org.kie.dmn.validation.DMNValidatorImpl | From | To | |
Rename Variable | 3 | ||
Rename Variable validate : List<DMNMessage> to validationMessages : List<DMNMessage> in method public testELEMREF_NOHASH_DefinitionsInput() : void in class org.kie.dmn.validation.ValidatorDMNElementReferenceTest | From | To | |
Rename Variable validate : List<DMNMessage> to validationMessages : List<DMNMessage> in method public testELEMREF_NOHASH_FileInput() : void in class org.kie.dmn.validation.ValidatorDMNElementReferenceTest | From | To | |
Rename Variable validate : List<DMNMessage> to validationMessages : List<DMNMessage> in method public testELEMREF_NOHASH_ReaderInput() : void in class org.kie.dmn.validation.ValidatorDMNElementReferenceTest | From | To | |
Change Return Type | 1 | ||
Change Return Type List<? extends DMNMessage> to List<DMNMessage> in method public asDMNMessages() : List<DMNMessage> in class org.kie.dmn.validation.dtanalysis.model.DTAnalysis | From | To | |
Parameterize Variable | 3 | ||
Parameterize Variable validate : List<DMNMessage> to validationMessages : List<DMNMessage> in method private assertValiadationResult(validationMessages List<DMNMessage>) : void in class org.kie.dmn.validation.ValidatorDMNElementReferenceTest | From | To | |
Replace Variable With Attribute | 1 | ||
Replace Variable With Attribute obj : Object to rules : List<Integer> in method public equals(obj Object) : boolean in class org.kie.dmn.validation.dtanalysis.model.Overlap | From | To | |
Change Variable Type | 2 | ||
Change Variable Type obj : Object to rules : List<Integer> in method public equals(obj Object) : boolean in class org.kie.dmn.validation.dtanalysis.model.Overlap | From | To | |
Change Variable Type results : List<? extends DMNMessage> to results : List<DMNMessage> in method public asDMNMessages() : List<DMNMessage> in class org.kie.dmn.validation.dtanalysis.model.DTAnalysis | From | To | |
Inline Variable | 4 | ||
Inline Variable missingInterval : Interval in method private findGaps(analysis DTAnalysis, ddtaTable DDTATable, jColIdx int, currentIntervals Interval[], activeRules Collection<Integer>) : void from class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To | |
Inline Variable ms : List<Definitions> in method public theseModels(models Definitions...) : List<DMNMessage> from class org.kie.dmn.validation.DMNValidatorImpl.ValidatorBuilderImpl | From | To | |
Extract Method | 17 | ||
Extract Method private findAllowedValues(model DMNModel, typeRef QName) : String extracted from private compileTableOutputClauses(model DMNModel, dt DecisionTable, ddtaTable DDTATable) : void in class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To | |
Extract Method private buildEdgesForHyperrectangleFromIntervals(currentIntervals Interval[], intervalsIndex int) : List<Interval> extracted from private findGaps(analysis DTAnalysis, ddtaTable DDTATable, jColIdx int, currentIntervals Interval[], activeRules Collection<Integer>) : void in class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To | |
Extract Method private assertValiadationResult(validationMessages List<DMNMessage>) : void extracted from public testELEMREF_NOHASH_ReaderInput() : void in class org.kie.dmn.validation.ValidatorDMNElementReferenceTest | From | To | |
Extract Method private verifyUnaryTestsAllEQ(utln UnaryTestListNode, dt DecisionTable) : void extracted from private compileTableOutputClauses(model DMNModel, dt DecisionTable, ddtaTable DDTATable) : void in class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To | |
Extract Method private findBoundsSorted(ddtaTable DDTATable, jColIdx int, activeRules Collection<Integer>) : List<Bound> extracted from private findGaps(analysis DTAnalysis, ddtaTable DDTATable, jColIdx int, currentIntervals Interval[], activeRules Collection<Integer>) : void in class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To | |
Extract Method private getDiscreteValuesSorted(utln UnaryTestListNode) : List<Comparable<?>> extracted from private compileTableOutputClauses(model DMNModel, dt DecisionTable, ddtaTable DDTATable) : void in class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To | |
Extract Method private createIntervalOfRule(discreteValues List, rule int, col int, lowerBoundIdx int, upperBoundIdx int) : Interval extracted from private toIntervals(elements List<BaseNode>, minMax Interval, discreteValues List, rule int, col int) : List<Interval> in class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To | |
Extract Method private validateDefinitions(definitions List<Definitions>, results DMNMessageManager) : void extracted from public theseModels(readers Reader...) : List<DMNMessage> in class org.kie.dmn.validation.DMNValidatorImpl.ValidatorBuilderImpl | From | To | |
Extract Method private getDiscreteValuesSorted(utln UnaryTestListNode) : List<Comparable<?>> extracted from private compileTableInputClauses(model DMNModel, dt DecisionTable, ddtaTable DDTATable) : void in class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To | |
Extract Method private findBoundsSorted(ddtaTable DDTATable, jColIdx int, activeRules Collection<Integer>) : List<Bound> extracted from private findOverlaps(analysis DTAnalysis, ddtaTable DDTATable, jColIdx int, currentIntervals Interval[], activeRules Collection<Integer>) : void in class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To | |
Extract Method private verifyUnaryTestsAllEQ(utln UnaryTestListNode, dt DecisionTable) : void extracted from private compileTableInputClauses(model DMNModel, dt DecisionTable, ddtaTable DDTATable) : void in class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To | |
Extract Method private assertValiadationResult(validationMessages List<DMNMessage>) : void extracted from public testELEMREF_NOHASH_DefinitionsInput() : void in class org.kie.dmn.validation.ValidatorDMNElementReferenceTest | From | To | |
Extract Method private validateDefinitions(definitions List<Definitions>, results DMNMessageManager) : void extracted from public theseModels(models Definitions...) : List<DMNMessage> in class org.kie.dmn.validation.DMNValidatorImpl.ValidatorBuilderImpl | From | To | |
Extract Method private assertValiadationResult(validationMessages List<DMNMessage>) : void extracted from public testELEMREF_NOHASH_FileInput() : void in class org.kie.dmn.validation.ValidatorDMNElementReferenceTest | From | To | |
Extract Method private unmarshallReaders(readers Reader...) : List<Definitions> extracted from public theseModels(readers Reader...) : List<DMNMessage> in class org.kie.dmn.validation.DMNValidatorImpl.ValidatorBuilderImpl | From | To | |
Extract Method private findAllowedValues(model DMNModel, typeRef QName) : String extracted from private compileTableInputClauses(model DMNModel, dt DecisionTable, ddtaTable DDTATable) : void in class org.kie.dmn.validation.dtanalysis.DMNDTAnalyser | From | To |