454dfeb1d9512f9c0daf5981bee381da58dd1619
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 33
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Parameterize Variable | 1 | ||
Parameterize Variable useLeftMemory : boolean to leftTupleMemoryEnabled : boolean in method private insertChildLeftTuple(trgLeftTuples TupleSets<LeftTuple>, leftTuple LeftTuple, rightTuple RightTuple, currentLeftChild LeftTuple, currentRightChild LeftTuple, sink LeftTupleSink, leftTupleMemoryEnabled boolean) : void in class org.drools.core.phreak.PhreakJoinNode | From | To | |
Extract Method | 15 | ||
Extract Method private insertChildLeftTuple(trgLeftTuples TupleSets<LeftTuple>, leftTuple LeftTuple, rightTuple RightTuple, currentLeftChild LeftTuple, currentRightChild LeftTuple, sink LeftTupleSink, leftTupleMemoryEnabled boolean) : void extracted from public doLeftInserts(joinNode JoinNode, sink LeftTupleSink, bm BetaMemory, wm InternalWorkingMemory, srcLeftTuples TupleSets<LeftTuple>, trgLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakJoinNode | From | To | |
Extract Method private insertChildLeftTuple(sink LeftTupleSink, trgLeftTuples TupleSets<LeftTuple>, ltm TupleMemory, leftTuple LeftTuple, pctx PropagationContext, useLeftMemory boolean) : void extracted from public doLeftUpdates(notNode NotNode, sink LeftTupleSink, bm BetaMemory, wm InternalWorkingMemory, srcLeftTuples TupleSets<LeftTuple>, trgLeftTuples TupleSets<LeftTuple>, stagedLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakNotNode | From | To | |
Extract Method private insertChildLeftTuple(sink LeftTupleSink, trgLeftTuples TupleSets<LeftTuple>, leftTuple LeftTuple, pctx PropagationContext, useLeftMemory boolean) : void extracted from public doRightInserts(existsNode ExistsNode, sink LeftTupleSink, bm BetaMemory, wm InternalWorkingMemory, srcRightTuples TupleSets<RightTuple>, trgLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakExistsNode | From | To | |
Extract Method private insertChildLeftTuple(sink LeftTupleSink, trgLeftTuples TupleSets<LeftTuple>, ltm TupleMemory, leftTuple LeftTuple, pctx PropagationContext, useLeftMemory boolean) : void extracted from public doLeftInserts(notNode NotNode, sink LeftTupleSink, bm BetaMemory, wm InternalWorkingMemory, srcLeftTuples TupleSets<LeftTuple>, trgLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakNotNode | From | To | |
Extract Method private insertChildLeftTuple(sink LeftTupleSink, trgLeftTuples TupleSets<LeftTuple>, ltm TupleMemory, leftTuple LeftTuple, pctx PropagationContext, useLeftMemory boolean) : void extracted from public doRightUpdates(notNode NotNode, sink LeftTupleSink, bm BetaMemory, wm InternalWorkingMemory, srcRightTuples TupleSets<RightTuple>, trgLeftTuples TupleSets<LeftTuple>, stagedLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakNotNode | From | To | |
Extract Method private insertChildLeftTuple(sink LeftTupleSink, trgLeftTuples TupleSets<LeftTuple>, ltm TupleMemory, leftTuple LeftTuple, pctx PropagationContext, useLeftMemory boolean) : void extracted from public doRightDeletes(notNode NotNode, sink LeftTupleSink, bm BetaMemory, wm InternalWorkingMemory, srcRightTuples TupleSets<RightTuple>, trgLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakNotNode | From | To | |
Extract Method private insertChildLeftTuple(sink LeftTupleSink, trgLeftTuples TupleSets<LeftTuple>, leftTuple LeftTuple, pctx PropagationContext, useLeftMemory boolean) : void extracted from public doRightUpdates(existsNode ExistsNode, sink LeftTupleSink, bm BetaMemory, wm InternalWorkingMemory, srcRightTuples TupleSets<RightTuple>, trgLeftTuples TupleSets<LeftTuple>, stagedLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakExistsNode | From | To | |
Extract Method private insertChildLeftTuple(trgLeftTuples TupleSets<LeftTuple>, leftTuple LeftTuple, rightTuple RightTuple, currentLeftChild LeftTuple, currentRightChild LeftTuple, sink LeftTupleSink, leftTupleMemoryEnabled boolean) : void extracted from public doRightInserts(joinNode JoinNode, sink LeftTupleSink, bm BetaMemory, wm InternalWorkingMemory, srcRightTuples TupleSets<RightTuple>, trgLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakJoinNode | From | To | |
Extract Method private insertChildLeftTuple(sink LeftTupleSink, trgLeftTuples TupleSets<LeftTuple>, leftTuple LeftTuple, pctx PropagationContext, useLeftMemory boolean) : void extracted from public doLeftUpdates(existsNode ExistsNode, sink LeftTupleSink, bm BetaMemory, wm InternalWorkingMemory, srcLeftTuples TupleSets<LeftTuple>, trgLeftTuples TupleSets<LeftTuple>, stagedLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakExistsNode | From | To | |
Extract Method private insertChildLeftTuple(trgLeftTuples TupleSets<LeftTuple>, leftTuple LeftTuple, rightTuple RightTuple, currentLeftChild LeftTuple, currentRightChild LeftTuple, sink LeftTupleSink, leftTupleMemoryEnabled boolean) : void extracted from public doLeftUpdatesProcessChildren(childLeftTuple LeftTuple, leftTuple LeftTuple, rightTuple RightTuple, stagedLeftTuples TupleSets<LeftTuple>, contextEntry ContextEntry[], constraints BetaConstraints, sink LeftTupleSink, it FastIterator, trgLeftTuples TupleSets<LeftTuple>) : LeftTuple in class org.drools.core.phreak.PhreakJoinNode | From | To | |
Extract Method private insertChildLeftTuple(sink LeftTupleSink, trgLeftTuples TupleSets<LeftTuple>, leftTuple LeftTuple, pctx PropagationContext, useLeftMemory boolean) : void extracted from public doLeftInserts(existsNode ExistsNode, sink LeftTupleSink, bm BetaMemory, wm InternalWorkingMemory, srcLeftTuples TupleSets<LeftTuple>, trgLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakExistsNode | From | To | |
Extract Method private deleteFromTMS(handle InternalFactHandle, key EqualityKey, typeConf ObjectTypeConf, propagationContext PropagationContext) : void extracted from private deleteStated(rule RuleImpl, activation Activation, handle InternalFactHandle, key EqualityKey) : void in class org.drools.core.common.NamedEntryPoint | From | To | |
Extract Method private insertChildLeftTuple(trgLeftTuples TupleSets<LeftTuple>, leftTuple LeftTuple, rightTuple RightTuple, currentLeftChild LeftTuple, currentRightChild LeftTuple, sink LeftTupleSink, leftTupleMemoryEnabled boolean) : void extracted from public doRightUpdatesProcessChildren(childLeftTuple LeftTuple, leftTuple LeftTuple, rightTuple RightTuple, stagedLeftTuples TupleSets<LeftTuple>, contextEntry ContextEntry[], constraints BetaConstraints, sink LeftTupleSink, it FastIterator, trgLeftTuples TupleSets<LeftTuple>) : LeftTuple in class org.drools.core.phreak.PhreakJoinNode | From | To | |
Extract And Move Method | 2 | ||
Extract And Move Method public createPropagationContextForFact(workingMemory InternalWorkingMemory, factHandle InternalFactHandle, propagationType int) : PropagationContext extracted from public expireFacts(context Object, pctx PropagationContext, workingMemory InternalWorkingMemory) : void in class org.drools.core.rule.SlidingTimeWindow & moved to class org.drools.core.common.PhreakPropagationContextFactory | From | To | |
Extract And Move Method public createPropagationContextForFact(workingMemory InternalWorkingMemory, factHandle InternalFactHandle, propagationType int) : PropagationContext extracted from public assertFact(context Object, handle InternalFactHandle, pctx PropagationContext, workingMemory InternalWorkingMemory) : boolean in class org.drools.core.rule.SlidingLengthWindow & moved to class org.drools.core.common.PhreakPropagationContextFactory | From | To |