987d68ab386923edda23002a1c64526812aa4764
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 11
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type argTemplate : Object[] to arguments : QueryArgument[] in method public QueryElement(resultPattern Pattern, queryName String, arguments QueryArgument[], variableIndexes int[], requiredDeclarations Declaration[], openQuery boolean, abductive boolean) in class org.drools.core.rule.QueryElement | From | To | |
| Change Parameter Type arguments : List<Object> to arguments : QueryArgument[] in method private processPositional(context RuleBuildContext, query QueryImpl, params Declaration[], arguments QueryArgument[], requiredDeclarations List<Declaration>, arrayReader InternalReadAccessor, pattern Pattern, base BaseDescr, expression String, result ConstraintConnectiveDescr) : void in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Change Parameter Type arguments : List<Object> to arguments : QueryArgument[] in method private processBinding(context RuleBuildContext, descr BaseDescr, params Declaration[], arguments QueryArgument[], requiredDeclarations List<Declaration>, arrayReader InternalReadAccessor, pattern Pattern, bind BindingDescr) : void in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type originalArgs : Object[] to originalArgs : QueryArgument[] in method private initArgsTemplate(context BuildContext) : QueryArgument[] in class org.drools.core.reteoo.QueryElementNode | From | To | |
| Extract Variable | 1 | ||
| Extract Variable declarationResolver : DeclarationScopeResolver in method private processPositional(context RuleBuildContext, query QueryImpl, params Declaration[], arguments QueryArgument[], requiredDeclarations List<Declaration>, arrayReader InternalReadAccessor, pattern Pattern, base BaseDescr, expression String, result ConstraintConnectiveDescr) : void from class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Inline Variable | 1 | ||
| Inline Variable declrsArray : Declaration[] in method public build(context RuleBuildContext, descr BaseDescr, prefixPattern Pattern, query QueryImpl) : RuleConditionElement from class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Extract Method | 7 | ||
| Extract Method public getActualArguments(leftTuple LeftTuple, workingMemory InternalWorkingMemory) : Object[] extracted from public createDroolsQuery(leftTuple LeftTuple, handle InternalFactHandle, stackEntry StackEntry, pmems List<PathMemory>, qmem QueryElementNodeMemory, sink LeftTupleSink, workingMemory InternalWorkingMemory) : DroolsQuery in class org.drools.core.reteoo.QueryElementNode | From | To | |
| Extract Method private getLiteralQueryArgument(context RuleBuildContext, descr BaseDescr, result ConstraintConnectiveDescr) : QueryArgument extracted from private processPositional(context RuleBuildContext, query QueryImpl, params Declaration[], declrIndexes List<Integer>, varIndexes List<Integer>, arguments List<Object>, requiredDeclarations List<Declaration>, arrayReader InternalReadAccessor, pattern Pattern, base BaseDescr, expression String, result ConstraintConnectiveDescr) : void in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Extract Method private getVariableQueryArgument(arrayReader InternalReadAccessor, params Declaration[], pos int, pattern Pattern, expression String) : QueryArgument extracted from private processPositional(context RuleBuildContext, query QueryImpl, params Declaration[], declrIndexes List<Integer>, varIndexes List<Integer>, arguments List<Object>, requiredDeclarations List<Declaration>, arrayReader InternalReadAccessor, pattern Pattern, base BaseDescr, expression String, result ConstraintConnectiveDescr) : void in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Extract Method private getLiteralQueryArgument(context RuleBuildContext, descr BaseDescr, result ConstraintConnectiveDescr) : QueryArgument extracted from private processBinding(context RuleBuildContext, descr BaseDescr, params Declaration[], declrIndexes List<Integer>, varIndexes List<Integer>, arguments List<Object>, requiredDeclarations List<Declaration>, arrayReader InternalReadAccessor, pattern Pattern, bind BindingDescr) : void in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Extract Method private getParserContext(context RuleBuildContext) : ParserContext extracted from private processPositional(context RuleBuildContext, query QueryImpl, params Declaration[], declrIndexes List<Integer>, varIndexes List<Integer>, arguments List<Object>, requiredDeclarations List<Declaration>, arrayReader InternalReadAccessor, pattern Pattern, base BaseDescr, expression String, result ConstraintConnectiveDescr) : void in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Extract Method private getParserContext(context RuleBuildContext) : ParserContext extracted from private processBinding(context RuleBuildContext, descr BaseDescr, params Declaration[], declrIndexes List<Integer>, varIndexes List<Integer>, arguments List<Object>, requiredDeclarations List<Declaration>, arrayReader InternalReadAccessor, pattern Pattern, bind BindingDescr) : void in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Extract Method private getVariableQueryArgument(arrayReader InternalReadAccessor, params Declaration[], pos int, pattern Pattern, expression String) : QueryArgument extracted from private processBinding(context RuleBuildContext, descr BaseDescr, params Declaration[], declrIndexes List<Integer>, varIndexes List<Integer>, arguments List<Object>, requiredDeclarations List<Declaration>, arrayReader InternalReadAccessor, pattern Pattern, bind BindingDescr) : void in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Rename Method | 1 | ||
| Rename Method public getArgTemplate() : Object[] renamed to public getArguments() : QueryArgument[] in class org.drools.core.rule.QueryElement | From | To | |
| Rename Variable | 1 | ||
| Rename Variable rewrittenExpr : String to expr : String in method private getLiteralQueryArgument(context RuleBuildContext, descr BaseDescr, result ConstraintConnectiveDescr) : QueryArgument in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Object[] to QueryArgument[] in method public getArguments() : QueryArgument[] in class org.drools.core.rule.QueryElement | From | To | |
| Change Return Type void to QueryArgument[] in method private initArgsTemplate(context BuildContext) : QueryArgument[] in class org.drools.core.reteoo.QueryElementNode | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable position : int to pos : int in method private getVariableQueryArgument(arrayReader InternalReadAccessor, params Declaration[], pos int, pattern Pattern, expression String) : QueryArgument in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Parameterize Variable bresult : ConstraintConnectiveDescr to result : ConstraintConnectiveDescr in method private getLiteralQueryArgument(context RuleBuildContext, descr BaseDescr, result ConstraintConnectiveDescr) : QueryArgument in class org.drools.compiler.rule.builder.QueryElementBuilder | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute argTemplate : Object[] to arguments : QueryArgument[] in class org.drools.core.rule.QueryElement | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type argsTemplate : Object[] to argsTemplate : QueryArgument[] in class org.drools.core.reteoo.QueryElementNode | From | To | |
| Change Attribute Type argTemplate : Object[] to arguments : QueryArgument[] in class org.drools.core.rule.QueryElement | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public getActualArguments(leftTuple LeftTuple, workingMemory InternalWorkingMemory) : Object[] extracted from public modifyLeftTuple(leftTuple LeftTuple, context PropagationContext, workingMemory InternalWorkingMemory) : void in class org.drools.reteoo.nodes.ReteQueryElementNode & moved to class org.drools.core.reteoo.QueryElementNode | From | To | |
| Extract And Move Method public getActualArguments(leftTuple LeftTuple, workingMemory InternalWorkingMemory) : Object[] extracted from public doLeftUpdates(queryNode QueryElementNode, qmem QueryElementNodeMemory, wm InternalWorkingMemory, srcLeftTuples TupleSets<LeftTuple>) : void in class org.drools.core.phreak.PhreakQueryNode & moved to class org.drools.core.reteoo.QueryElementNode | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter argTemplate : Object[] to arguments : QueryArgument[] in method public QueryElement(resultPattern Pattern, queryName String, arguments QueryArgument[], variableIndexes int[], requiredDeclarations Declaration[], openQuery boolean, abductive boolean) in class org.drools.core.rule.QueryElement | From | To | |
| Rename Parameter varIndexes : int[] to variableIndexes : int[] in method public setVariableIndexes(variableIndexes int[]) : void in class org.drools.core.rule.QueryElement | From | To |