017b4f0f90c3a40c0f5557916c6ad5c4612606a3
Files Diff
- Added: 3
- Removed: 3
- Renamed: 0
- Modified: 19
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method protected getFreeSubSlotForTask(vertex ExecutionVertex, requestedLocations Iterable<Instance>, groupAssignment SlotSharingGroupAssignment, constraint CoLocationConstraint, localOnly boolean) : SimpleSlot renamed to protected getNewSlotForSharingGroup(vertex ExecutionVertex, requestedLocations Iterable<Instance>, groupAssignment SlotSharingGroupAssignment, constraint CoLocationConstraint, localOnly boolean) : SimpleSlot in class org.apache.flink.runtime.jobmanager.scheduler.Scheduler | From | To | |
| Rename Method public disposeChild(slot SimpleSlot) : void renamed to package releaseChild(slot SimpleSlot) : void in class org.apache.flink.runtime.instance.SharedSlot | From | To | |
| Rename Method public getExecution() : Execution renamed to public getExecutedVertex() : Execution in class org.apache.flink.runtime.instance.SimpleSlot | From | To | |
| Rename Method private returnSlot(slot Slot) : void renamed to private internalDisposeEmptySharedSlot(sharedSlot SharedSlot) : void in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type groupId : AbstractID to groupId : JobVertexID in method private addSharedSlotAndAllocateSubSlot(sharedSlot SharedSlot, locality Locality, groupId JobVertexID, constraint CoLocationConstraint) : SimpleSlot in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Change Parameter Type slot : Slot to sharedSlot : SharedSlot in method private internalDisposeEmptySharedSlot(sharedSlot SharedSlot) : void in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Rename Variable | 3 | ||
| Rename Variable subSlots : Set<Slot> to children : Set<Slot> in method package releaseSharedSlot(sharedSlot SharedSlot) : void in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Rename Variable list : List<SharedSlot> to slotsForGroup : Map<Instance,List<SharedSlot>> in method private internalDisposeEmptySharedSlot(sharedSlot SharedSlot) : void in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Rename Variable slotsForJid : Map<Instance,List<SharedSlot>> to slotsForGroup : Map<Instance,List<SharedSlot>> in method private internalDisposeEmptySharedSlot(sharedSlot SharedSlot) : void in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Inline Method | 3 | ||
| Inline Method public cancel() : void inlined to public releaseSlot() : void in class org.apache.flink.runtime.instance.SimpleSlot | From | To | |
| Inline Method public allocateSimpleSlot(jobID JobID, groupID AbstractID) : SimpleSlot inlined to public allocateSimpleSlot(jobID JobID) : SimpleSlot in class org.apache.flink.runtime.instance.Instance | From | To | |
| Inline Method private removeSharedSlot(sharedSlot SharedSlot) : void inlined to private internalDisposeEmptySharedSlot(sharedSlot SharedSlot) : void in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.flink.runtime.jobmanager.scheduler.SlotSharingGroupAssignment moved to org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Extract Variable | 2 | ||
| Extract Variable groupIdForMap : AbstractID in method private addSharedSlotAndAllocateSubSlot(sharedSlot SharedSlot, locality Locality, groupId JobVertexID, constraint CoLocationConstraint) : SimpleSlot from class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Extract Variable locality : Locality in method private getSlotForTaskInternal(groupId AbstractID, preferredLocations Iterable<Instance>, localOnly boolean) : Pair<SharedSlot,Locality> from class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type list : List<SharedSlot> to slotsForGroup : Map<Instance,List<SharedSlot>> in method private internalDisposeEmptySharedSlot(sharedSlot SharedSlot) : void in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Change Variable Type groupID : AbstractID to groupID : JobVertexID in method protected getNewSlotForSharingGroup(vertex ExecutionVertex, requestedLocations Iterable<Instance>, groupAssignment SlotSharingGroupAssignment, constraint CoLocationConstraint, localOnly boolean) : SimpleSlot in class org.apache.flink.runtime.jobmanager.scheduler.Scheduler | From | To | |
| Extract Method | 2 | ||
| Extract Method package getSlotForTask(constraint CoLocationConstraint, locationPreferences Iterable<Instance>) : SimpleSlot extracted from public getSlotForTask(vertex ExecutionVertex, constraint CoLocationConstraint) : SimpleSlot in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Extract Method package getSlotForTask(vertexID JobVertexID, locationPreferences Iterable<Instance>) : SimpleSlot extracted from public getSlotForTask(vertex ExecutionVertex) : SimpleSlot in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter jID : AbstractID to groupId : AbstractID in method package allocateSubSlot(groupId AbstractID) : SimpleSlot in class org.apache.flink.runtime.instance.SharedSlot | From | To | |
| Rename Parameter sharedSlot : SharedSlot to newSlot : SharedSlot in method public setSharedSlot(newSlot SharedSlot) : void in class org.apache.flink.runtime.jobmanager.scheduler.CoLocationConstraint | From | To | |
| Rename Parameter groupID : AbstractID to groupId : AbstractID in method public SharedSlot(jobID JobID, instance Instance, slotNumber int, assignmentGroup SlotSharingGroupAssignment, parent SharedSlot, groupId AbstractID) in class org.apache.flink.runtime.instance.SharedSlot | From | To | |
| Rename Parameter slot : Slot to sharedSlot : SharedSlot in method private internalDisposeEmptySharedSlot(sharedSlot SharedSlot) : void in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment | From | To | |
| Rename Parameter jID : AbstractID to groupId : AbstractID in method package allocateSharedSlot(groupId AbstractID) : SharedSlot in class org.apache.flink.runtime.instance.SharedSlot | From | To |