0a19c456ac7781d94eb0aaaf8f2ac73d0157bacb
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 24
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 10 | ||
| Rename Method private getCacheDirectory(storageDir File) : File renamed to package getStorageLocation(storageDir File, jobId JobID, key BlobKey) : File in class org.apache.flink.runtime.blob.BlobUtils | From | To | |
| Rename Method public testPutBufferSuccessful() : void renamed to private testPutBufferSuccessfulGet(jobId1 JobID, jobId2 JobID) : void in class org.apache.flink.runtime.blob.BlobServerPutTest | From | To | |
| Rename Method public testDeleteAlreadyDeletedByBlobKey() : void renamed to private testDeleteAlreadyDeleted(jobId JobID) : void in class org.apache.flink.runtime.blob.BlobServerDeleteTest | From | To | |
| Rename Method private receiveAndCheckResponse(is InputStream) : void renamed to private receiveAndCheckGetResponse(is InputStream) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
| Rename Method public testBlobCache() : void renamed to public testBlobNoJobCache() : void in class org.apache.flink.runtime.blob.BlobCacheSuccessTest | From | To | |
| Rename Method public testExceptionOnCreateCacheDirectoryFailure() : void renamed to public testExceptionOnCreateCacheDirectoryFailureNoJob() : void in class org.apache.flink.runtime.blob.BlobUtilsTest | From | To | |
| Rename Method public testBlobFetchWithTooManyFailures() : void renamed to public testBlobNoJobFetchWithTooManyFailures() : void in class org.apache.flink.runtime.blob.BlobCacheRetriesTest | From | To | |
| Rename Method public testDeleteByBlobKeyFails() : void renamed to private testDeleteFails(jobId JobID) : void in class org.apache.flink.runtime.blob.BlobServerDeleteTest | From | To | |
| Rename Method package initStorageDirectory(storageDirectory String) : File renamed to package initLocalStorageDirectory(basePath String) : File in class org.apache.flink.runtime.blob.BlobUtils | From | To | |
| Rename Method private receivePutResponseAndCompare(is InputStream, md MessageDigest) : BlobKey renamed to private receiveAndCheckPutResponse(is InputStream, md MessageDigest) : BlobKey in class org.apache.flink.runtime.blob.BlobClient | From | To | |
| Rename Variable | 7 | ||
| Rename Variable contentAddressable : int to mode : int in method private put(inputStream InputStream, outputStream OutputStream, buf byte[]) : void in class org.apache.flink.runtime.blob.BlobServerConnection | From | To | |
| Rename Variable jobID : JobID to jobId : JobID in method private put(inputStream InputStream, outputStream OutputStream, buf byte[]) : void in class org.apache.flink.runtime.blob.BlobServerConnection | From | To | |
| Rename Variable key1 : BlobKey to key1a : BlobKey in method private testPutBufferSuccessfulGet(jobId1 JobID, jobId2 JobID) : void in class org.apache.flink.runtime.blob.BlobServerPutTest | From | To | |
| Rename Variable key : BlobKey to key1 : BlobKey in method public testDeleteSingleByBlobKey() : void in class org.apache.flink.runtime.blob.BlobServerDeleteTest | From | To | |
| Rename Variable contentAddressable : int to mode : int in method private get(inputStream InputStream, outputStream OutputStream, buf byte[]) : void in class org.apache.flink.runtime.blob.BlobServerConnection | From | To | |
| Rename Variable key2 : BlobKey to key1b : BlobKey in method private testPutBufferSuccessfulGet(jobId1 JobID, jobId2 JobID) : void in class org.apache.flink.runtime.blob.BlobServerPutTest | From | To | |
| Rename Variable type : int to mode : int in method private delete(inputStream InputStream, outputStream OutputStream) : void in class org.apache.flink.runtime.blob.BlobServerConnection | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable blobClient : BlobClient to client : BlobClient in method private deleteHelper(client BlobClient, jobId JobID, key BlobKey) : void in class org.apache.flink.runtime.blob.BlobServerDeleteTest | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute CONTENT_ADDRESSABLE : byte to CONTENT_FOR_JOB : byte in class org.apache.flink.runtime.blob.BlobServerProtocol | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type tempFileCounter : AtomicInteger to tempFileCounter : AtomicLong in class org.apache.flink.runtime.blob.BlobServer | From | To | |
| Extract Method | 17 | ||
| Extract Method private testBlobFetchRetriesHa(jobId JobID) : void extracted from public testBlobFetchRetriesHa() : void in class org.apache.flink.runtime.blob.BlobCacheRetriesTest | From | To | |
| Extract Method private uploadJarFile(serverAddress InetSocketAddress, blobClientConfig Configuration, testFile File) : void extracted from package uploadJarFile(blobServer BlobServer, blobClientConfig Configuration) : void in class org.apache.flink.runtime.blob.BlobClientTest | From | To | |
| Extract Method private deleteHelper(client BlobClient, jobId JobID, key BlobKey) : void extracted from public testDeleteAlreadyDeletedByBlobKey() : void in class org.apache.flink.runtime.blob.BlobServerDeleteTest | From | To | |
| Extract Method private deleteHelper(client BlobClient, jobId JobID, key BlobKey) : void extracted from public testDeleteByBlobKeyFails() : void in class org.apache.flink.runtime.blob.BlobServerDeleteTest | From | To | |
| Extract Method package getFileHelper(blobClient BlobClient, jobId JobID, blobKey BlobKey) : InputStream extracted from public testConcurrentGetOperations() : void in class org.apache.flink.runtime.blob.BlobServerGetTest | From | To | |
| Extract Method private getFileInternal(jobId JobID, requiredBlob BlobKey) : File extracted from public getFile(requiredBlob BlobKey) : File in class org.apache.flink.runtime.blob.BlobCache | From | To | |
| Extract Method public deleteInternal(jobId JobID, key BlobKey) : void extracted from public delete(blobKey BlobKey) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
| Extract Method package getInternal(jobId JobID, blobKey BlobKey) : InputStream extracted from public get(blobKey BlobKey) : InputStream in class org.apache.flink.runtime.blob.BlobClient | From | To | |
| Extract Method private deleteGlobalInternal(jobId JobID, key BlobKey) : void extracted from public deleteGlobal(key BlobKey) : void in class org.apache.flink.runtime.blob.BlobCache | From | To | |
| Extract Method package deleteInternal(jobId JobID, key BlobKey) : void extracted from public delete(key BlobKey) : void in class org.apache.flink.runtime.blob.BlobServer | From | To | |
| Extract Method private getFileInternal(jobId JobID, requiredBlob BlobKey) : File extracted from public getFile(requiredBlob BlobKey) : File in class org.apache.flink.runtime.blob.BlobServer | From | To | |
| Extract Method private deleteHelper(client BlobClient, jobId JobID, key BlobKey) : void extracted from public testConcurrentDeleteOperations() : void in class org.apache.flink.runtime.blob.BlobServerDeleteTest | From | To | |
| Extract Method private deleteInternal(jobId JobID, key BlobKey) : void extracted from public delete(key BlobKey) : void in class org.apache.flink.runtime.blob.BlobCache | From | To | |
| Extract Method private readFileFully(inputStream InputStream, incomingFile File, buf byte[]) : BlobKey extracted from private put(inputStream InputStream, outputStream OutputStream, buf byte[]) : void in class org.apache.flink.runtime.blob.BlobServerConnection | From | To | |
| Extract Method private ensureClientIsClosed(client BlobClient) : void extracted from public testDeleteSingleByBlobKey() : void in class org.apache.flink.runtime.blob.BlobServerDeleteTest | From | To | |
| Extract Method private testPutBufferSuccessfulGet(jobId JobID, key1 BlobKey, key2 BlobKey, data byte[], serverAddress InetSocketAddress, config Configuration) : void extracted from public testPutBufferSuccessful() : void in class org.apache.flink.runtime.blob.BlobServerPutTest | From | To | |
| Extract Method private verifyDeleted(client BlobClient, jobId JobID, key BlobKey, serverAddress InetSocketAddress, config Configuration) : BlobClient extracted from public testGetFailsDuringLookup() : void in class org.apache.flink.runtime.blob.BlobServerGetTest | From | To | |
| Rename Parameter | 6 | ||
| Rename Parameter requiredBlob : BlobKey to key : BlobKey in method public getFile(key BlobKey) : File in class org.apache.flink.runtime.blob.BlobServer | From | To | |
| Rename Parameter storageDirectory : String to basePath : String in method package initLocalStorageDirectory(basePath String) : File in class org.apache.flink.runtime.blob.BlobUtils | From | To | |
| Rename Parameter jobID : JobID to jobId : JobID in method private sendGetHeader(outputStream OutputStream, jobId JobID, blobKey BlobKey) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
| Rename Parameter requiredBlob : BlobKey to key : BlobKey in method public getFile(key BlobKey) : File in class org.apache.flink.runtime.blob.BlobCache | From | To | |
| Rename Parameter jobID : JobID to jobId : JobID in method private sendPutHeader(outputStream OutputStream, jobId JobID) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
| Rename Parameter blobKey : BlobKey to key : BlobKey in method public delete(key BlobKey) : void in class org.apache.flink.runtime.blob.BlobClient | From | To |