1804aa33d0996810ad35bfa4dd526c86a1e12828
Files Diff
- Added: 19
- Removed: 6
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 2 | ||
| Rename Variable address : String to actorAddress : String in method private extractAddressHostname(actorRef ActorRef) : Tuple2<String,String> in class org.apache.flink.runtime.rpc.akka.AkkaRpcService | From | To | |
| Rename Variable akkaInvocationHandler : InvocationHandler to invocationHandler : InvocationHandler in method public checkedApply(obj Object) : C in class org.apache.flink.runtime.rpc.akka.AkkaRpcService.connectInternal.resultFuture.map | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Executor to MainThreadExecutor in method protected getMainThreadExecutor() : MainThreadExecutor in class org.apache.flink.runtime.rpc.RpcEndpoint | From | To | |
| Move Class | 6 | ||
| Move Class org.apache.flink.runtime.rpc.akka.messages.CallAsync moved to org.apache.flink.runtime.rpc.messages.CallAsync | From | To | |
| Move Class org.apache.flink.runtime.rpc.akka.messages.LocalRpcInvocation moved to org.apache.flink.runtime.rpc.messages.LocalRpcInvocation | From | To | |
| Move Class org.apache.flink.runtime.rpc.akka.messages.RunAsync moved to org.apache.flink.runtime.rpc.messages.RunAsync | From | To | |
| Move Class org.apache.flink.runtime.rpc.akka.messages.RpcInvocation moved to org.apache.flink.runtime.rpc.messages.RpcInvocation | From | To | |
| Move Class org.apache.flink.runtime.rpc.akka.messages.RemoteRpcInvocation moved to org.apache.flink.runtime.rpc.messages.RemoteRpcInvocation | From | To | |
| Move Class org.apache.flink.runtime.rpc.akka.messages.Shutdown moved to org.apache.flink.runtime.rpc.messages.Shutdown | From | To | |
| Parameterize Variable | 3 | ||
| Parameterize Variable rpcInvocation : RpcInvocation to message : Object in method protected ask(message Object, timeout Time) : CompletableFuture<?> in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Parameterize Variable rpcInvocation : RpcInvocation to message : Object in method protected tell(message Object) : void in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Parameterize Variable futureTimeout : Time to timeout : Time in method protected ask(message Object, timeout Time) : CompletableFuture<?> in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type rpcInvocation : RpcInvocation to message : Object in method protected tell(message Object) : void in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Change Variable Type resultFuture : scala.concurrent.Future<C> to resultFuture : Future<C> in method private connectInternal(address String, clazz Class<C>, invocationHandlerFactory Function<ActorRef,InvocationHandler>) : CompletableFuture<C> in class org.apache.flink.runtime.rpc.akka.AkkaRpcService | From | To | |
| Change Variable Type identify : scala.concurrent.Future<Object> to identify : Future<Object> in method private connectInternal(address String, clazz Class<C>, invocationHandlerFactory Function<ActorRef,InvocationHandler>) : CompletableFuture<C> in class org.apache.flink.runtime.rpc.akka.AkkaRpcService | From | To | |
| Change Variable Type rpcInvocation : RpcInvocation to message : Object in method protected ask(message Object, timeout Time) : CompletableFuture<?> in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.apache.flink.runtime.rpc.messages.ControlMessage from classes [org.apache.flink.runtime.rpc.messages.Shutdown] | From | To | |
| Extract Method | 9 | ||
| Extract Method protected sendErrorIfSender(throwable Throwable) : void extracted from public onReceive(message Object) : void in class org.apache.flink.runtime.rpc.akka.AkkaRpcActor | From | To | |
| Extract Method protected createRpcInvocationMessage(methodName String, parameterTypes Class<?>[], args Object[]) : RpcInvocation extracted from public invoke(proxy Object, method Method, args Object[]) : Object in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Extract Method private invokeRpc(method Method, args Object[]) : Object extracted from public invoke(proxy Object, method Method, args Object[]) : Object in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Extract Method protected ask(message Object, timeout Time) : CompletableFuture<?> extracted from public invoke(proxy Object, method Method, args Object[]) : Object in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Extract Method protected ask(message Object, timeout Time) : CompletableFuture<?> extracted from public callAsync(callable Callable<V>, callTimeout Time) : CompletableFuture<V> in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Extract Method private extractAddressHostname(actorRef ActorRef) : Tuple2<String,String> extracted from public connect(address String, clazz Class<C>) : CompletableFuture<C> in class org.apache.flink.runtime.rpc.akka.AkkaRpcService | From | To | |
| Extract Method private connectInternal(address String, clazz Class<C>, invocationHandlerFactory Function<ActorRef,InvocationHandler>) : CompletableFuture<C> extracted from public connect(address String, clazz Class<C>) : CompletableFuture<C> in class org.apache.flink.runtime.rpc.akka.AkkaRpcService | From | To | |
| Extract Method protected tell(message Object) : void extracted from public scheduleRunAsync(runnable Runnable, delayMillis long) : void in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Extract Method protected tell(message Object) : void extracted from public invoke(proxy Object, method Method, args Object[]) : Object in class org.apache.flink.runtime.rpc.akka.AkkaInvocationHandler | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type mainThreadExecutor : Executor to mainThreadExecutor : MainThreadExecutor in class org.apache.flink.runtime.rpc.RpcEndpoint | From | To |