2004286d29b7971376e778ec763d9c688b41dc10
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type executionPredicate : Predicate<Execution> to executionPredicate : Predicate<AccessExecution> in method public waitForAllExecutionsPredicate(executionGraph ExecutionGraph, executionPredicate Predicate<AccessExecution>, maxWaitMillis long) : void in class org.apache.flink.runtime.executiongraph.ExecutionGraphTestUtils | From | To | |
| Rename Variable | 2 | ||
| Rename Variable secondResourceManagerGateway : TestingResourceManagerGateway to testingResourceManagerGateway : TestingResourceManagerGateway in method private createAndRegisterTestingResourceManagerGateway() : TestingResourceManagerGateway in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Rename Variable resourceManagerGateway : TestingResourceManagerGateway to testingResourceManagerGateway : TestingResourceManagerGateway in method private createAndRegisterTestingResourceManagerGateway() : TestingResourceManagerGateway in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable resourceManagerGateway : TestingResourceManagerGateway to testingResourceManagerGateway : TestingResourceManagerGateway in method private notifyResourceManagerLeaderListeners(testingResourceManagerGateway TestingResourceManagerGateway) : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type isDeploying : Predicate<Execution> to isDeploying : Predicate<AccessExecution> in method public testConstraintsAfterRestart() : void in class org.apache.flink.runtime.executiongraph.ExecutionGraphCoLocationRestartTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable resourceManagerAddress : String in method public testResourceManagerConnectionAfterRegainingLeadership() : void from class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method | 16 | ||
| Extract Method private createAndRegisterTestingResourceManagerGateway() : TestingResourceManagerGateway extracted from public testReleasingTaskExecutorIfNoMoreSlotsRegistered() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private startTaskManagers() : void extracted from public start() : void in class org.apache.flink.runtime.minicluster.MiniCluster | From | To | |
| Extract Method private notifyResourceManagerLeaderListeners(testingResourceManagerGateway TestingResourceManagerGateway) : void extracted from public testSlotRequestTimeoutWhenNoSlotOffering() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private notifyResourceManagerLeaderListeners(testingResourceManagerGateway TestingResourceManagerGateway) : void extracted from public testReconnectionAfterDisconnect() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private createAndRegisterTestingResourceManagerGateway() : TestingResourceManagerGateway extracted from public testCloseUnestablishedResourceManagerConnection() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private notifyResourceManagerLeaderListeners(testingResourceManagerGateway TestingResourceManagerGateway) : void extracted from public testResourceManagerConnectionAfterRegainingLeadership() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private createSingleVertexJobGraph() : JobGraph extracted from private createSingleVertexJobWithRestartStrategy() : JobGraph in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private createAndRegisterTestingResourceManagerGateway() : TestingResourceManagerGateway extracted from public testSlotRequestTimeoutWhenNoSlotOffering() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private createAndRegisterTestingResourceManagerGateway() : TestingResourceManagerGateway extracted from public testReconnectionAfterDisconnect() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private notifyResourceManagerLeaderListeners(testingResourceManagerGateway TestingResourceManagerGateway) : void extracted from public testRequestPartitionState() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method public allExecutionsPredicate(executionPredicate Predicate<AccessExecution>) : Predicate<AccessExecutionGraph> extracted from public waitForAllExecutionsPredicate(executionGraph ExecutionGraph, executionPredicate Predicate<Execution>, maxWaitMillis long) : void in class org.apache.flink.runtime.executiongraph.ExecutionGraphTestUtils | From | To | |
| Extract Method private createAndRegisterTestingResourceManagerGateway() : TestingResourceManagerGateway extracted from public testResourceManagerConnectionAfterRegainingLeadership() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private createAndRegisterTestingResourceManagerGateway() : TestingResourceManagerGateway extracted from public testRequestPartitionState() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private notifyResourceManagerLeaderListeners(testingResourceManagerGateway TestingResourceManagerGateway) : void extracted from public testReleasingTaskExecutorIfNoMoreSlotsRegistered() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private notifyResourceManagerLeaderListeners(testingResourceManagerGateway TestingResourceManagerGateway) : void extracted from public testCloseUnestablishedResourceManagerConnection() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Extract Method private createJobMaster(configuration Configuration, jobGraph JobGraph, highAvailabilityServices HighAvailabilityServices, jobManagerSharedServices JobManagerSharedServices, heartbeatServices HeartbeatServices, onCompletionActions OnCompletionActions) : JobMaster extracted from private createJobMaster(configuration Configuration, jobGraph JobGraph, highAvailabilityServices HighAvailabilityServices, jobManagerSharedServices JobManagerSharedServices, heartbeatServices HeartbeatServices) : JobMaster in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type taskManagers : TaskExecutor[] to taskManagers : List<TaskExecutor> in class org.apache.flink.runtime.minicluster.MiniCluster | From | To |