259a3a5569952458140afc8e9ad96eac0c330162
Files Diff
- Added: 6
- Removed: 0
- Renamed: 0
- Modified: 14
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method private hasJobBeenSubmitted() : boolean renamed to protected isClientConnected() : boolean in class org.apache.flink.runtime.client.JobClientActor | From | To | |
| Rename Method public testConnectionTimeoutWithoutJobManager() : void renamed to public testConnectionTimeoutWithoutJobManagerForSubmission() : void in class org.apache.flink.runtime.client.JobClientActorTest | From | To | |
| Rename Method private isConnected() : boolean renamed to private isJobManagerConnected() : boolean in class org.apache.flink.runtime.client.JobClientActor | From | To | |
| Push Down Method | 2 | ||
| Push Down Method public createJobClientActorProps(leaderRetrievalService LeaderRetrievalService, timeout FiniteDuration, sysoutUpdates boolean) : Props from class org.apache.flink.runtime.client.JobClientActor to public createActorProps(leaderRetrievalService LeaderRetrievalService, timeout FiniteDuration, sysoutUpdates boolean) : Props from class org.apache.flink.runtime.client.JobAttachmentClientActor | From | To | |
| Push Down Method public createJobClientActorProps(leaderRetrievalService LeaderRetrievalService, timeout FiniteDuration, sysoutUpdates boolean) : Props from class org.apache.flink.runtime.client.JobClientActor to public createActorProps(leaderRetrievalService LeaderRetrievalService, timeout FiniteDuration, sysoutUpdates boolean) : Props from class org.apache.flink.runtime.client.JobSubmissionClientActor | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.apache.flink.runtime.client.JobSubmissionClientActor from class org.apache.flink.runtime.client.JobClientActor | From | To | |
| Inline Method | 1 | ||
| Inline Method private tryToSubmitJob(jobGraph JobGraph) : void inlined to protected handleMessage(message Object) : void in class org.apache.flink.runtime.client.JobClientActor | From | To | |
| Rename Variable | 1 | ||
| Rename Variable future : Future<Object> to submissionFuture : Future<Object> in method public submitJob(actorSystem ActorSystem, leaderRetrievalService LeaderRetrievalService, jobGraph JobGraph, timeout FiniteDuration, sysoutLogUpdates boolean, classLoader ClassLoader) : JobListeningContext in class org.apache.flink.runtime.client.JobClient | From | To | |
| Push Down Attribute | 2 | ||
| Push Down Attribute private jobSuccessfullySubmitted : boolean from class org.apache.flink.runtime.client.JobClientActor to private jobSuccessfullySubmitted : boolean from class org.apache.flink.runtime.client.JobSubmissionClientActor | From | To | |
| Push Down Attribute private jobGraph : JobGraph from class org.apache.flink.runtime.client.JobClientActor to private jobGraph : JobGraph from class org.apache.flink.runtime.client.JobSubmissionClientActor | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute terminated : boolean to toBeTerminated : boolean in class org.apache.flink.runtime.client.JobClientActor | From | To | |
| Rename Attribute submitter : ActorRef to client : ActorRef in class org.apache.flink.runtime.client.JobClientActor | From | To | |
| Extract Variable | 2 | ||
| Extract Variable replyMessage : Object in method protected handleMessage(message Object) : void from class org.apache.flink.runtime.client.JobClientActor | From | To | |
| Extract Variable jobID : JobID in method public awaitJobResult(listeningContext JobListeningContext) : JobExecutionResult from class org.apache.flink.runtime.client.JobClient | From | To | |
| Extract Method | 2 | ||
| Extract Method public awaitJobResult(listeningContext JobListeningContext) : JobExecutionResult extracted from public submitJobAndWait(actorSystem ActorSystem, leaderRetrievalService LeaderRetrievalService, jobGraph JobGraph, timeout FiniteDuration, sysoutLogUpdates boolean, classLoader ClassLoader) : JobExecutionResult in class org.apache.flink.runtime.client.JobClient | From | To | |
| Extract Method public submitJob(actorSystem ActorSystem, leaderRetrievalService LeaderRetrievalService, jobGraph JobGraph, timeout FiniteDuration, sysoutLogUpdates boolean, classLoader ClassLoader) : JobListeningContext extracted from public submitJobAndWait(actorSystem ActorSystem, leaderRetrievalService LeaderRetrievalService, jobGraph JobGraph, timeout FiniteDuration, sysoutLogUpdates boolean, classLoader ClassLoader) : JobExecutionResult in class org.apache.flink.runtime.client.JobClient | From | To |