3126bf522925a4f9a5cbf4c33077dbe7664363fa
Files Diff
- Added: 9
- Removed: 1
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public getBytesWritten() : long renamed to public getBytesBlocked() : long in class org.apache.flink.streaming.runtime.io.BufferSpiller | From | To | |
| Rename Method private rollOverInternal(newBuffer boolean) : SpilledBufferOrEventSequence renamed to private rollOver(newBuffer boolean) : BufferOrEventSequence in class org.apache.flink.streaming.runtime.io.BufferSpiller | From | To | |
| Pull Up Method | 6 | ||
| Pull Up Method public testRollOverEmptySequences() : void from class org.apache.flink.streaming.runtime.io.BufferSpillerTest to public testRollOverEmptySequences() : void from class org.apache.flink.streaming.runtime.io.BufferBlockerTestBase | From | To | |
| Pull Up Method private generateRandomBuffer(size int, channelIndex int) : BufferOrEvent from class org.apache.flink.streaming.runtime.io.BufferSpillerTest to public generateRandomBuffer(size int, channelIndex int) : BufferOrEvent from class org.apache.flink.streaming.runtime.io.BufferBlockerTestBase | From | To | |
| Pull Up Method public testSpillWhileReading() : void from class org.apache.flink.streaming.runtime.io.BufferSpillerTest to public testSpillWhileReading() : void from class org.apache.flink.streaming.runtime.io.BufferBlockerTestBase | From | To | |
| Pull Up Method public testSpillAndRollOverSimple() : void from class org.apache.flink.streaming.runtime.io.BufferSpillerTest to public testSpillAndRollOverSimple() : void from class org.apache.flink.streaming.runtime.io.BufferBlockerTestBase | From | To | |
| Pull Up Method private validateBuffer(boe BufferOrEvent, expectedSize int, expectedChannelIndex int) : void from class org.apache.flink.streaming.runtime.io.BufferSpillerTest to private validateBuffer(boe BufferOrEvent, expectedSize int, expectedChannelIndex int) : void from class org.apache.flink.streaming.runtime.io.BufferBlockerTestBase | From | To | |
| Pull Up Method private generateRandomEvent(rnd Random, numChannels int) : BufferOrEvent from class org.apache.flink.streaming.runtime.io.BufferSpillerTest to private generateRandomEvent(rnd Random, numChannels int) : BufferOrEvent from class org.apache.flink.streaming.runtime.io.BufferBlockerTestBase | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type ioManager : IOManager to bufferBlocker : BufferBlocker in method public BarrierBuffer(inputGate InputGate, bufferBlocker BufferBlocker) in class org.apache.flink.streaming.runtime.io.BarrierBuffer | From | To | |
| Change Parameter Type ioManager : IOManager to bufferBlocker : BufferBlocker in method public BarrierBuffer(inputGate InputGate, bufferBlocker BufferBlocker, maxBufferedBytes long) in class org.apache.flink.streaming.runtime.io.BarrierBuffer | From | To | |
| Change Parameter Type sequence : BufferSpiller.SpilledBufferOrEventSequence to sequence : BufferOrEventSequence in method private SequenceToConsume(bufferRnd Random, events ArrayList<BufferOrEvent>, sequence BufferOrEventSequence, numBuffersAndEvents int, numChannels int) in class org.apache.flink.streaming.runtime.io.BufferBlockerTestBase.SequenceToConsume | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private PAGE_SIZE : int from class org.apache.flink.streaming.runtime.io.BufferSpillerTest to protected PAGE_SIZE : int from class org.apache.flink.streaming.runtime.io.BufferBlockerTestBase | From | To | |
| Change Return Type | 1 | ||
| Change Return Type SpilledBufferOrEventSequence to BufferOrEventSequence in method private rollOver(newBuffer boolean) : BufferOrEventSequence in class org.apache.flink.streaming.runtime.io.BufferSpiller | From | To | |
| Move Class | 3 | ||
| Move Class org.apache.flink.streaming.runtime.io.BufferSpillerTest.SequenceToConsume moved to org.apache.flink.streaming.runtime.io.BufferBlockerTestBase.SequenceToConsume | From | To | |
| Move Class org.apache.flink.streaming.runtime.io.BarrierBufferTest.CheckpointMatcher moved to org.apache.flink.streaming.runtime.io.BarrierBufferTestBase.CheckpointMatcher | From | To | |
| Move Class org.apache.flink.streaming.runtime.io.BarrierBufferTest.ValidatingCheckpointHandler moved to org.apache.flink.streaming.runtime.io.BarrierBufferTestBase.ValidatingCheckpointHandler | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.flink.streaming.runtime.io.BufferBlockerTestBase from classes [org.apache.flink.streaming.runtime.io.BufferSpillerTest] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute bufferSpiller : BufferSpiller to bufferBlocker : BufferBlocker in class org.apache.flink.streaming.runtime.io.BarrierBuffer | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type seq : BufferSpiller.SpilledBufferOrEventSequence to seq : BufferOrEventSequence in method public cleanup() : void in class org.apache.flink.streaming.runtime.io.BarrierBuffer | From | To | |
| Extract Interface | 2 | ||
| Extract Interface org.apache.flink.streaming.runtime.io.BufferBlocker from classes [org.apache.flink.streaming.runtime.io.BufferSpiller] | From | To | |
| Extract Interface org.apache.flink.streaming.runtime.io.BufferOrEventSequence from classes [org.apache.flink.streaming.runtime.io.BufferSpiller.SpilledBufferOrEventSequence] | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type sequence : BufferSpiller.SpilledBufferOrEventSequence to sequence : BufferOrEventSequence in class org.apache.flink.streaming.runtime.io.BufferBlockerTestBase.SequenceToConsume | From | To | |
| Change Attribute Type queuedBuffered : ArrayDeque<BufferSpiller.SpilledBufferOrEventSequence> to queuedBuffered : ArrayDeque<BufferOrEventSequence> in class org.apache.flink.streaming.runtime.io.BarrierBuffer | From | To | |
| Change Attribute Type currentBuffered : BufferSpiller.SpilledBufferOrEventSequence to currentBuffered : BufferOrEventSequence in class org.apache.flink.streaming.runtime.io.BarrierBuffer | From | To | |
| Change Attribute Type bufferSpiller : BufferSpiller to bufferBlocker : BufferBlocker in class org.apache.flink.streaming.runtime.io.BarrierBuffer | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter ioManager : IOManager to bufferBlocker : BufferBlocker in method public BarrierBuffer(inputGate InputGate, bufferBlocker BufferBlocker, maxBufferedBytes long) in class org.apache.flink.streaming.runtime.io.BarrierBuffer | From | To | |
| Rename Parameter ioManager : IOManager to bufferBlocker : BufferBlocker in method public BarrierBuffer(inputGate InputGate, bufferBlocker BufferBlocker) in class org.apache.flink.streaming.runtime.io.BarrierBuffer | From | To |