3d07a97c82c3947935bf13b3f60aafce274a6cff
Files Diff
- Added: 7
- Removed: 6
- Renamed: 0
- Modified: 19
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Added | |
| junit:junit:4.12 | |
| com.squareup.okhttp3:okhttp:3.11.0 | |
| com.typesafe.akka:akka-remote_2.11:2.4.20 | |
| net.bytebuddy:byte-buddy:1.8.15 | |
| org.joda:joda-convert:1.7 | |
| com.typesafe.akka:akka-testkit_2.11:2.4.20 | |
| org.apache.zookeeper:zookeeper:3.4.10 | |
| com.esotericsoftware.kryo:kryo:2.24.0 | |
| org.scala-lang:scala-reflect:2.11.12 | |
| org.scala-lang:scala-library:2.11.12 | |
| com.typesafe.akka:akka-protobuf_2.11:2.4.20 | |
| com.typesafe.akka:akka-stream_2.11:2.4.20 | |
| com.google.guava:guava:19.0 | |
| org.apache.flink:flink-shaded-guava:18.0-6.0 | |
| org.apache.commons:commons-lang3:3.3.2 | |
| org.tukaani:xz:1.5 | |
| com.fasterxml.jackson.core:jackson-core:2.8.11 | |
| log4j:log4j:1.2.17 | |
| org.apache.flink:flink-shaded-netty:4.1.32.Final-6.0 | |
| com.typesafe.akka:akka-slf4j_2.11:2.4.20 | |
| com.fasterxml.jackson.core:jackson-databind:2.8.11.2 | |
| commons-logging:commons-logging:1.1.3 | |
| org.javassist:javassist:3.19.0-GA | |
| org.reflections:reflections:0.9.10 | |
| com.google.code.findbugs:jsr305:1.3.9 | |
| org.apache.avro:avro:1.8.2 | |
| org.apache.flink:flink-shaded-asm:5.0.4-6.0 | |
| net.bytebuddy:byte-buddy-agent:1.8.15 | |
| com.typesafe:config:1.3.0 | |
| org.codehaus.janino:janino:3.0.7 | |
| com.typesafe.akka:akka-camel_2.11:2.4.20 | |
| org.hamcrest:hamcrest-core:1.3 | |
| org.objenesis:objenesis:2.1 | |
| com.github.scopt:scopt_2.11:3.5.0 | |
| org.apache.flink:flink-shaded-asm-6:6.2.1-6.0 | |
| com.typesafe.akka:akka-actor_2.11:2.4.20 | |
| org.apache.commons:commons-compress:1.18 | |
| org.apache.httpcomponents:httpcore:4.4.6 | |
| com.fasterxml.jackson.core:jackson-annotations:2.8.11 | |
| commons-codec:commons-codec:1.10 | |
| joda-time:joda-time:2.5 | |
| commons-cli:commons-cli:1.3.1 | |
| org.slf4j:slf4j-log4j12:1.7.15 | |
| org.apache.flink:flink-shaded-jackson:2.7.9-6.0 | |
| org.apache.flink:flink-shaded-jackson-module-jsonSchema:2.7.9-6.0 | |
| org.codehaus.janino:commons-compiler:3.0.7 | |
| org.scala-lang.modules:scala-xml_2.11:1.0.5 | |
| org.apache.flink:flink-test-utils-junit:1.8-SNAPSHOT-2.4.1 | |
| commons-io:commons-io:2.4 | |
| org.apache.httpcomponents:httpclient:4.5.3 | |
| com.squareup.okio:okio:1.14.0 | |
| commons-configuration:commons-configuration:1.7 | |
| com.github.oshi:oshi-core:3.4.0 | |
| org.slf4j:slf4j-api:1.7.15 | |
| org.xerial.snappy:snappy-java:1.1.4 | |
| com.101tec:zkclient:0.7 | |
| org.apache.kafka:kafka-clients:2.0.1 | |
| org.clapper:grizzled-slf4j_2.11:1.3.2 | |
| org.apache.commons:commons-math3:3.5 | |
| org.scala-lang:scala-compiler:2.11.12 | |
| commons-collections:commons-collections:3.2.2 | |
| org.scalatest:scalatest_2.11:3.0.0 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 5 | ||
| Rename Method public rowTypeToCsvSchema(rowType RowTypeInfo) : CsvSchema renamed to public convert(rowType RowTypeInfo) : CsvSchema in class org.apache.flink.formats.csv.CsvRowSchemaConverter | From | To | |
| Rename Method public supportedProperties() : List<String> renamed to public supportedFormatProperties() : List<String> in class org.apache.flink.formats.csv.CsvRowFormatFactory | From | To | |
| Rename Method private convertArray(row Row, rowTypeInfo RowTypeInfo) : ArrayNode renamed to private createRowRuntimeConverter(rowTypeInfo RowTypeInfo, isTopLevel boolean) : RuntimeConverter in class org.apache.flink.formats.csv.CsvRowSerializationSchema | From | To | |
| Rename Method private convertRow(root JsonNode, rowTypeInfo RowTypeInfo) : Row renamed to private createRowRuntimeConverter(rowTypeInfo RowTypeInfo, ignoreParseErrors boolean, isTopLevel boolean) : RuntimeConverter in class org.apache.flink.formats.csv.CsvRowDeserializationSchema | From | To | |
| Rename Method private validateAndGetProperties(propertiesMap Map<String,String>) : DescriptorProperties renamed to private getValidatedProperties(propertiesMap Map<String,String>) : DescriptorProperties in class org.apache.flink.formats.csv.CsvRowFormatFactory | From | To | |
| Move And Rename Method | 2 | ||
| Move And Rename Method public setNullValue(s String) : void from class org.apache.flink.formats.csv.CsvRowSerializationSchema to public setNullLiteral(s String) : Builder from class org.apache.flink.formats.csv.CsvRowSerializationSchema.Builder | From | To | |
| Move And Rename Method public setNullValue(s String) : void from class org.apache.flink.formats.csv.CsvRowDeserializationSchema to public setNullLiteral(s String) : Builder from class org.apache.flink.formats.csv.CsvRowSerializationSchema.Builder | From | To | |
| Move Method | 5 | ||
| Move Method public setQuoteCharacter(c char) : void from class org.apache.flink.formats.csv.CsvRowDeserializationSchema to public setQuoteCharacter(c char) : Builder from class org.apache.flink.formats.csv.CsvRowDeserializationSchema.Builder | From | To | |
| Move Method public setEscapeCharacter(c char) : void from class org.apache.flink.formats.csv.CsvRowSerializationSchema to public setEscapeCharacter(c char) : Builder from class org.apache.flink.formats.csv.CsvRowDeserializationSchema.Builder | From | To | |
| Move Method public setEscapeCharacter(c char) : void from class org.apache.flink.formats.csv.CsvRowDeserializationSchema to public setEscapeCharacter(c char) : Builder from class org.apache.flink.formats.csv.CsvRowDeserializationSchema.Builder | From | To | |
| Move Method public setArrayElementDelimiter(s String) : void from class org.apache.flink.formats.csv.CsvRowSerializationSchema to public setArrayElementDelimiter(delimiter String) : Builder from class org.apache.flink.formats.csv.CsvRowDeserializationSchema.Builder | From | To | |
| Move Method public setQuoteCharacter(c char) : void from class org.apache.flink.formats.csv.CsvRowSerializationSchema to public setQuoteCharacter(c char) : Builder from class org.apache.flink.formats.csv.CsvRowDeserializationSchema.Builder | From | To | |
| Inline Method | 2 | ||
| Inline Method private testSchemaSerializationSchema(properties Map<String,String>) : void inlined to public testSchema() : void in class org.apache.flink.formats.csv.CsvRowFormatFactoryTest | From | To | |
| Inline Method private testSchemaDeserializationSchema(properties Map<String,String>) : void inlined to public testSchema() : void in class org.apache.flink.formats.csv.CsvRowFormatFactoryTest | From | To | |
| Rename Variable | 9 | ||
| Rename Variable infos : TypeInformation<?>[] to types : TypeInformation<?>[] in method public convert(rowType RowTypeInfo) : CsvSchema in class org.apache.flink.formats.csv.CsvRowSchemaConverter | From | To | |
| Rename Variable expected2 : CsvRowDeserializationSchema to expectedSer : CsvRowSerializationSchema in method public testSchema() : void in class org.apache.flink.formats.csv.CsvRowFormatFactoryTest | From | To | |
| Rename Variable schema : CsvRowSerializationSchema to schemaBuilder : CsvRowSerializationSchema.Builder in method public createSerializationSchema(properties Map<String,String>) : SerializationSchema<Row> in class org.apache.flink.formats.csv.CsvRowFormatFactory | From | To | |
| Rename Variable fields : String[] to fieldNames : String[] in method private createRowRuntimeConverter(rowTypeInfo RowTypeInfo, ignoreParseErrors boolean, isTopLevel boolean) : RuntimeConverter in class org.apache.flink.formats.csv.CsvRowDeserializationSchema | From | To | |
| Rename Variable types : TypeInformation<?>[] to fieldTypes : TypeInformation<?>[] in method private createRowRuntimeConverter(rowTypeInfo RowTypeInfo, ignoreParseErrors boolean, isTopLevel boolean) : RuntimeConverter in class org.apache.flink.formats.csv.CsvRowDeserializationSchema | From | To | |
| Rename Variable fields : String[] to fieldNames : String[] in method private createRowRuntimeConverter(rowTypeInfo RowTypeInfo, isTopLevel boolean) : RuntimeConverter in class org.apache.flink.formats.csv.CsvRowSerializationSchema | From | To | |
| Rename Variable schema : CsvRowDeserializationSchema to schemaBuilder : CsvRowDeserializationSchema.Builder in method public createDeserializationSchema(properties Map<String,String>) : DeserializationSchema<Row> in class org.apache.flink.formats.csv.CsvRowFormatFactory | From | To | |
| Rename Variable types : TypeInformation[] to fieldTypes : TypeInformation[] in method private createRowRuntimeConverter(rowTypeInfo RowTypeInfo, isTopLevel boolean) : RuntimeConverter in class org.apache.flink.formats.csv.CsvRowSerializationSchema | From | To | |
| Rename Variable expected1 : SerializationSchema to expectedDeser : CsvRowDeserializationSchema in method public testSchema() : void in class org.apache.flink.formats.csv.CsvRowFormatFactoryTest | From | To | |
| Change Return Type | 9 | ||
| Change Return Type void to Builder in method public setArrayElementDelimiter(delimiter String) : Builder in class org.apache.flink.formats.csv.CsvRowDeserializationSchema.Builder | From | To | |
| Change Return Type void to Builder in method public setQuoteCharacter(c char) : Builder in class org.apache.flink.formats.csv.CsvRowDeserializationSchema.Builder | From | To | |
| Change Return Type Row to RuntimeConverter in method private createRowRuntimeConverter(rowTypeInfo RowTypeInfo, ignoreParseErrors boolean, isTopLevel boolean) : RuntimeConverter in class org.apache.flink.formats.csv.CsvRowDeserializationSchema | From | To | |
| Change Return Type void to Builder in method public setNullLiteral(s String) : Builder in class org.apache.flink.formats.csv.CsvRowSerializationSchema.Builder | From | To | |
| Change Return Type ArrayNode to RuntimeConverter in method private createRowRuntimeConverter(rowTypeInfo RowTypeInfo, isTopLevel boolean) : RuntimeConverter in class org.apache.flink.formats.csv.CsvRowSerializationSchema | From | To | |
| Change Return Type void to Builder in method public setEscapeCharacter(c char) : Builder in class org.apache.flink.formats.csv.CsvRowDeserializationSchema.Builder | From | To | |
| Extract Class | 2 | ||
| Extract Class org.apache.flink.formats.csv.CsvRowSerializationSchema.Builder from class org.apache.flink.formats.csv.CsvRowSerializationSchema | From | To | |
| Extract Class org.apache.flink.formats.csv.CsvRowDeserializationSchema.Builder from class org.apache.flink.formats.csv.CsvRowDeserializationSchema | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type expected2 : CsvRowDeserializationSchema to expectedSer : CsvRowSerializationSchema in method public testSchema() : void in class org.apache.flink.formats.csv.CsvRowFormatFactoryTest | From | To | |
| Change Variable Type expected1 : SerializationSchema to expectedDeser : CsvRowDeserializationSchema in method public testSchema() : void in class org.apache.flink.formats.csv.CsvRowFormatFactoryTest | From | To | |
| Change Variable Type schema : CsvRowSerializationSchema to schemaBuilder : CsvRowSerializationSchema.Builder in method public createSerializationSchema(properties Map<String,String>) : SerializationSchema<Row> in class org.apache.flink.formats.csv.CsvRowFormatFactory | From | To | |
| Change Variable Type schema : CsvRowDeserializationSchema to schemaBuilder : CsvRowDeserializationSchema.Builder in method public createDeserializationSchema(properties Map<String,String>) : DeserializationSchema<Row> in class org.apache.flink.formats.csv.CsvRowFormatFactory | From | To | |
| Extract Variable | 1 | ||
| Extract Variable rowArity : int in method private assembleRowRuntimeConverter(ignoreParseErrors boolean, isTopLevel boolean, fieldNames String[], fieldConverters RuntimeConverter[]) : RuntimeConverter from class org.apache.flink.formats.csv.CsvRowDeserializationSchema | From | To | |
| Extract Method | 3 | ||
| Extract Method private createFieldRuntimeConverters(fieldTypes TypeInformation<?>[]) : RuntimeConverter[] extracted from private convertArray(row Row, rowTypeInfo RowTypeInfo) : ArrayNode in class org.apache.flink.formats.csv.CsvRowSerializationSchema | From | To | |
| Extract Method private assembleRowRuntimeConverter(ignoreParseErrors boolean, isTopLevel boolean, fieldNames String[], fieldConverters RuntimeConverter[]) : RuntimeConverter extracted from private convertRow(root JsonNode, rowTypeInfo RowTypeInfo) : Row in class org.apache.flink.formats.csv.CsvRowDeserializationSchema | From | To | |
| Extract Method private createObjectArrayRuntimeConverter(elementType TypeInformation<?>) : RuntimeConverter extracted from private convertArray(row Row, rowTypeInfo RowTypeInfo) : ArrayNode in class org.apache.flink.formats.csv.CsvRowSerializationSchema | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter s : String to delimiter : String in method public setArrayElementDelimiter(delimiter String) : Builder in class org.apache.flink.formats.csv.CsvRowDeserializationSchema.Builder | From | To |