41dba8bb71fd615bcab219a48708fb2b9c4762be
Files Diff
- Added: 4
- Removed: 1
- Renamed: 0
- Modified: 7
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method private respondAsLeader(ctx ChannelHandlerContext, request HttpRequest, requestPath String) : void renamed to private respondToRequest(ctx ChannelHandlerContext, request HttpRequest, requestPath String) : void in class org.apache.flink.runtime.webmonitor.files.StaticFileServerHandler | From | To | |
Pull Up Method | 1 | ||
Pull Up Method public channelRead0(ctx ChannelHandlerContext, routed Routed) : void from class org.apache.flink.runtime.webmonitor.files.StaticFileServerHandler to protected channelRead0(channelHandlerContext ChannelHandlerContext, routed Routed) : void from class org.apache.flink.runtime.webmonitor.RedirectHandler | From | To | |
Change Parameter Type | 3 | ||
Change Parameter Type handler : RuntimeMonitorHandlerBase to handler : T in method private delete(router Router, handler T) : void in class org.apache.flink.runtime.webmonitor.WebRuntimeMonitor | From | To | |
Change Parameter Type handler : RuntimeMonitorHandlerBase to handler : T in method private get(router Router, handler T) : void in class org.apache.flink.runtime.webmonitor.WebRuntimeMonitor | From | To | |
Change Parameter Type handler : RuntimeMonitorHandlerBase to handler : T in method private post(router Router, handler T) : void in class org.apache.flink.runtime.webmonitor.WebRuntimeMonitor | From | To | |
Pull Up Attribute | 3 | ||
Pull Up Attribute private httpsEnabled : boolean from class org.apache.flink.runtime.webmonitor.files.StaticFileServerHandler to protected httpsEnabled : boolean from class org.apache.flink.runtime.webmonitor.RedirectHandler | From | To | |
Pull Up Attribute private timeout : Time from class org.apache.flink.runtime.webmonitor.files.StaticFileServerHandler to protected timeout : Time from class org.apache.flink.runtime.webmonitor.RedirectHandler | From | To | |
Pull Up Attribute private logger : Logger from class org.apache.flink.runtime.webmonitor.files.StaticFileServerHandler to protected logger : Logger from class org.apache.flink.runtime.webmonitor.RedirectHandler | From | To | |
Change Return Type | 3 | ||
Change Return Type FullHttpResponse to HttpResponse in method public getErrorResponse(throwable Throwable) : HttpResponse in class org.apache.flink.runtime.webmonitor.handlers.HandlerRedirectUtils | From | To | |
Change Return Type FullHttpResponse to HttpResponse in method public getResponse(status HttpResponseStatus, message String) : HttpResponse in class org.apache.flink.runtime.webmonitor.handlers.HandlerRedirectUtils | From | To | |
Change Return Type FullHttpResponse to HttpResponse in method public getErrorResponse(throwable Throwable, status HttpResponseStatus) : HttpResponse in class org.apache.flink.runtime.webmonitor.handlers.HandlerRedirectUtils | From | To | |
Extract Superclass | 1 | ||
Extract Superclass org.apache.flink.runtime.webmonitor.RedirectHandler from classes [org.apache.flink.runtime.webmonitor.RuntimeMonitorHandler, org.apache.flink.runtime.webmonitor.files.StaticFileServerHandler, org.apache.flink.runtime.webmonitor.handlers.TaskManagerLogHandler] | From | To | |
Change Variable Type | 1 | ||
Change Variable Type finalResponse : FullHttpResponse to finalResponse : HttpResponse in method protected respondAsLeader(ctx ChannelHandlerContext, routed Routed, jobManagerGateway JobManagerGateway) : void in class org.apache.flink.runtime.webmonitor.RuntimeMonitorHandler | From | To | |
Extract Interface | 1 | ||
Extract Interface org.apache.flink.runtime.webmonitor.WebHandler from classes [org.apache.flink.runtime.webmonitor.RuntimeMonitorHandler, org.apache.flink.runtime.webmonitor.handlers.TaskManagerLogHandler] | From | To | |
Rename Parameter | 2 | ||
Rename Parameter ctx : ChannelHandlerContext to channelHandlerContext : ChannelHandlerContext in method protected channelRead0(channelHandlerContext ChannelHandlerContext, routed Routed) : void in class org.apache.flink.runtime.webmonitor.RedirectHandler | From | To | |
Rename Parameter localJobManagerAddressPromise : CompletableFuture<String> to localJobManagerAddressFuture : CompletableFuture<String> in method public StaticFileServerHandler(retriever GatewayRetriever<T>, localJobManagerAddressFuture CompletableFuture<String>, timeout Time, rootPath File, httpsEnabled boolean) in class org.apache.flink.runtime.webmonitor.files.StaticFileServerHandler | From | To |