47dc69970996aa2a57c0dbfde866d3dac6d53001
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public getResourceManagerId() : ResourceID from class org.apache.flink.runtime.taskexecutor.TaskExecutorToResourceManagerConnection to public getResourceManagerResourceId() : ResourceID from class org.apache.flink.runtime.taskexecutor.EstablishedResourceManagerConnection | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type registerTaskExecutorFunction : Function<Tuple5<String,ResourceID,SlotReport,Integer,HardwareDescription>,CompletableFuture<RegistrationResponse>> to registerTaskExecutorFunction : Function<Tuple4<String,ResourceID,Integer,HardwareDescription>,CompletableFuture<RegistrationResponse>> in method public setRegisterTaskExecutorFunction(registerTaskExecutorFunction Function<Tuple4<String,ResourceID,Integer,HardwareDescription>,CompletableFuture<RegistrationResponse>>) : void in class org.apache.flink.runtime.resourcemanager.utils.TestingResourceManagerGateway | From | To | |
| Change Parameter Type registrationListener : RegistrationConnectionListener<TaskExecutorRegistrationSuccess> to registrationListener : RegistrationConnectionListener<TaskExecutorToResourceManagerConnection,TaskExecutorRegistrationSuccess> in method public TaskExecutorToResourceManagerConnection(log Logger, rpcService RpcService, taskManagerAddress String, taskManagerResourceId ResourceID, dataPort int, hardwareDescription HardwareDescription, resourceManagerAddress String, resourceManagerId ResourceManagerId, executor Executor, registrationListener RegistrationConnectionListener<TaskExecutorToResourceManagerConnection,TaskExecutorRegistrationSuccess>) in class org.apache.flink.runtime.taskexecutor.TaskExecutorToResourceManagerConnection | From | To | |
| Rename Variable | 1 | ||
| Rename Variable slotAllocationException : SlotAllocationException to taskManagerException : TaskManagerException in method public requestSlot(slotId SlotID, jobId JobID, allocationId AllocationID, targetAddress String, resourceManagerId ResourceManagerId, timeout Time) : CompletableFuture<Acknowledge> in class org.apache.flink.runtime.taskexecutor.TaskExecutor | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private resourceManagerResourceId : ResourceID from class org.apache.flink.runtime.taskexecutor.TaskExecutorToResourceManagerConnection to private resourceManagerResourceId : ResourceID from class org.apache.flink.runtime.taskexecutor.EstablishedResourceManagerConnection | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type slotAllocationException : SlotAllocationException to taskManagerException : TaskManagerException in method public requestSlot(slotId SlotID, jobId JobID, allocationId AllocationID, targetAddress String, resourceManagerId ResourceManagerId, timeout Time) : CompletableFuture<Acknowledge> in class org.apache.flink.runtime.taskexecutor.TaskExecutor | From | To | |
| Change Variable Type currentFunction : Function<Tuple5<String,ResourceID,SlotReport,Integer,HardwareDescription>,CompletableFuture<RegistrationResponse>> to currentFunction : Function<Tuple4<String,ResourceID,Integer,HardwareDescription>,CompletableFuture<RegistrationResponse>> in method public registerTaskExecutor(taskExecutorAddress String, resourceId ResourceID, dataPort int, hardwareDescription HardwareDescription, timeout Time) : CompletableFuture<RegistrationResponse> in class org.apache.flink.runtime.resourcemanager.utils.TestingResourceManagerGateway | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type registerTaskExecutorFunction : Function<Tuple5<String,ResourceID,SlotReport,Integer,HardwareDescription>,CompletableFuture<RegistrationResponse>> to registerTaskExecutorFunction : Function<Tuple4<String,ResourceID,Integer,HardwareDescription>,CompletableFuture<RegistrationResponse>> in class org.apache.flink.runtime.resourcemanager.utils.TestingResourceManagerGateway | From | To | |
| Change Attribute Type registrationListener : RegistrationConnectionListener<TaskExecutorRegistrationSuccess> to registrationListener : RegistrationConnectionListener<TaskExecutorToResourceManagerConnection,TaskExecutorRegistrationSuccess> in class org.apache.flink.runtime.taskexecutor.TaskExecutorToResourceManagerConnection | From | To | |
| Extract Method | 2 | ||
| Extract Method private reconnectToResourceManager(cause Exception) : void extracted from public disconnectResourceManager(cause Exception) : void in class org.apache.flink.runtime.taskexecutor.TaskExecutor | From | To | |
| Extract Method private createTaskExecutor(taskManagerServices TaskManagerServices) : TaskExecutor extracted from public testMaximumRegistrationDuration() : void in class org.apache.flink.runtime.taskexecutor.TaskExecutorTest | From | To |