517b3f87214168a445b5751cda210ecf3a292fd6
Files Diff
- Added: 13
- Removed: 1
- Renamed: 0
- Modified: 70
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public close() : void from class org.apache.flink.runtime.state.StateInitializationContextImpl to private closeFromRegistry(closeable Closeable, registry CloseableRegistry) : void from class org.apache.flink.streaming.api.operators.AbstractStreamOperator | From | To | |
| Change Parameter Type | 13 | ||
| Change Parameter Type taskFactory : BiFunction<Environment,TaskStateSnapshot,? extends OneInputStreamTask<IN,OUT>> to taskFactory : Function<Environment,? extends StreamTask<OUT,?>> in method public OneInputStreamTaskTestHarness(taskFactory Function<Environment,? extends StreamTask<OUT,?>>, inputType TypeInformation<IN>, outputType TypeInformation<OUT>) in class org.apache.flink.streaming.runtime.tasks.OneInputStreamTaskTestHarness | From | To | |
| Change Parameter Type initialState : TaskStateSnapshot to timeProvider : ProcessingTimeService in method public OneInputStreamTask(env Environment, timeProvider ProcessingTimeService) in class org.apache.flink.streaming.runtime.tasks.OneInputStreamTask | From | To | |
| Change Parameter Type taskFactory : BiFunction<Environment,TaskStateSnapshot,? extends OneInputStreamTask<IN,OUT>> to taskFactory : Function<Environment,? extends StreamTask<OUT,?>> in method public OneInputStreamTaskTestHarness(taskFactory Function<Environment,? extends StreamTask<OUT,?>>, numInputGates int, numInputChannelsPerGate int, inputType TypeInformation<IN>, outputType TypeInformation<OUT>) in class org.apache.flink.streaming.runtime.tasks.OneInputStreamTaskTestHarness | From | To | |
| Change Parameter Type taskFactory : BiFunction<Environment,TaskStateSnapshot,? extends StreamTask<OUT,?>> to taskFactory : Function<Environment,? extends StreamTask<OUT,?>> in method public StreamTaskTestHarness(taskFactory Function<Environment,? extends StreamTask<OUT,?>>, outputType TypeInformation<OUT>) in class org.apache.flink.streaming.runtime.tasks.StreamTaskTestHarness | From | To | |
| Change Parameter Type operatorStateHandles : Collection<OperatorStateHandle> to rawOperatorStateInputs : Iterable<StatePartitionStreamProvider> in method public StateInitializationContextImpl(restored boolean, operatorStateStore OperatorStateStore, keyedStateStore KeyedStateStore, rawKeyedStateInputs Iterable<KeyGroupStatePartitionStreamProvider>, rawOperatorStateInputs Iterable<StatePartitionStreamProvider>) in class org.apache.flink.runtime.state.StateInitializationContextImpl | From | To | |
| Change Parameter Type stateHandles : Optional<TaskStateSnapshot> to restore : Optional<JobManagerTaskRestore> in method private createRunAndCheckpointOperatorChain(headId OperatorID, headOperator OneInputStreamOperator<String,String>, tailId OperatorID, tailOperator OneInputStreamOperator<String,String>, restore Optional<JobManagerTaskRestore>) : JobManagerTaskRestore in class org.apache.flink.streaming.runtime.tasks.RestoreStreamTaskTest | From | To | |
| Change Parameter Type environment : Environment to environment : MockEnvironment in method public OneInputStreamOperatorTestHarness(operator OneInputStreamOperator<IN,OUT>, typeSerializerIn TypeSerializer<IN>, environment MockEnvironment) in class org.apache.flink.streaming.util.OneInputStreamOperatorTestHarness | From | To | |
| Change Parameter Type environment : Environment to environment : MockEnvironment in method public OneInputStreamOperatorTestHarness(operator OneInputStreamOperator<IN,OUT>, environment MockEnvironment) in class org.apache.flink.streaming.util.OneInputStreamOperatorTestHarness | From | To | |
| Change Parameter Type environment : Environment to env : MockEnvironment in method private AbstractStreamOperatorTestHarness(operator StreamOperator<OUT>, env MockEnvironment, environmentIsInternal boolean) in class org.apache.flink.streaming.util.AbstractStreamOperatorTestHarness | From | To | |
| Change Parameter Type environment : Environment to env : MockEnvironment in method public AbstractStreamOperatorTestHarness(operator StreamOperator<OUT>, env MockEnvironment) in class org.apache.flink.streaming.util.AbstractStreamOperatorTestHarness | From | To | |
| Change Parameter Type environment : Environment to environment : MockEnvironment in method public KeyedOneInputStreamOperatorTestHarness(operator OneInputStreamOperator<IN,OUT>, keySelector KeySelector<IN,K>, keyType TypeInformation<K>, environment MockEnvironment) in class org.apache.flink.streaming.util.KeyedOneInputStreamOperatorTestHarness | From | To | |
| Change Parameter Type taskFactory : BiFunction<Environment,TaskStateSnapshot,? extends TwoInputStreamTask<IN1,IN2,OUT>> to taskFactory : Function<Environment,? extends TwoInputStreamTask<IN1,IN2,OUT>> in method public TwoInputStreamTaskTestHarness(taskFactory Function<Environment,? extends TwoInputStreamTask<IN1,IN2,OUT>>, numInputGates int, numInputChannelsPerGate int, inputGateAssignment int[], inputType1 TypeInformation<IN1>, inputType2 TypeInformation<IN2>, outputType TypeInformation<OUT>) in class org.apache.flink.streaming.runtime.tasks.TwoInputStreamTaskTestHarness | From | To | |
| Change Parameter Type taskFactory : BiFunction<Environment,TaskStateSnapshot,? extends TwoInputStreamTask<IN1,IN2,OUT>> to taskFactory : Function<Environment,? extends TwoInputStreamTask<IN1,IN2,OUT>> in method public TwoInputStreamTaskTestHarness(taskFactory Function<Environment,? extends TwoInputStreamTask<IN1,IN2,OUT>>, inputType1 TypeInformation<IN1>, inputType2 TypeInformation<IN2>, outputType TypeInformation<OUT>) in class org.apache.flink.streaming.runtime.tasks.TwoInputStreamTaskTestHarness | From | To | |
| Move Method | 1 | ||
| Move Method private transform(keyedStateHandles Collection<KeyedStateHandle>) : Collection<KeyGroupsStateHandle> from class org.apache.flink.runtime.state.StateInitializationContextImpl to private transform(keyedStateHandles Collection<KeyedStateHandle>) : Collection<KeyGroupsStateHandle> from class org.apache.flink.streaming.api.operators.StreamTaskStateInitializerImpl | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private operatorStateBackend : OperatorStateBackend from class org.apache.flink.streaming.runtime.tasks.StreamTaskTest.StateBackendTestSource to package operatorStateBackend : OperatorStateBackend from class org.apache.flink.streaming.runtime.tasks.StreamTaskTest.TestStreamSource | From | To | |
| Move Attribute private keyedStateBackend : AbstractKeyedStateBackend<?> from class org.apache.flink.streaming.runtime.tasks.StreamTask to package keyedStateBackend : AbstractKeyedStateBackend<?> from class org.apache.flink.streaming.runtime.tasks.StreamTaskTest.TestStreamSource | From | To | |
| Move Attribute private keyedStateBackend : AbstractKeyedStateBackend<?> from class org.apache.flink.streaming.runtime.tasks.StreamTask to private keyedStateBackend : AbstractKeyedStateBackend<?> from class org.apache.flink.streaming.api.operators.StreamTaskStateInitializerImpl.StreamOperatorStateContextImpl | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.flink.streaming.runtime.tasks.StreamTaskTest.TestStreamSource from class org.apache.flink.streaming.runtime.tasks.StreamTaskTest.StateBackendTestSource | From | To | |
| Move Class | 3 | ||
| Move Class org.apache.flink.runtime.state.StateInitializationContextImpl.OperatorStateStreamIterator moved to org.apache.flink.streaming.api.operators.StreamTaskStateInitializerImpl.OperatorStateStreamIterator | From | To | |
| Move Class org.apache.flink.runtime.state.StateInitializationContextImpl.AbstractStateStreamIterator moved to org.apache.flink.streaming.api.operators.StreamTaskStateInitializerImpl.AbstractStateStreamIterator | From | To | |
| Move Class org.apache.flink.runtime.state.StateInitializationContextImpl.KeyGroupStreamIterator moved to org.apache.flink.streaming.api.operators.StreamTaskStateInitializerImpl.KeyGroupStreamIterator | From | To | |
| Change Variable Type | 7 | ||
| Change Variable Type environment1 : AcknowledgeStreamMockEnvironment to restore : JobManagerTaskRestore in method public testRestoreWithoutState() : void in class org.apache.flink.streaming.runtime.tasks.RestoreStreamTaskTest | From | To | |
| Change Variable Type mockEnvironment : Environment to mockEnvironment : MockEnvironment in method private testUserExceptionHandling(outputMode AsyncDataStream.OutputMode) : void in class org.apache.flink.streaming.api.operators.async.AsyncWaitOperatorTest | From | To | |
| Change Variable Type mockenvironment : Environment to mockEnvironment : MockEnvironment in method private testTimeoutExceptionHandling(outputMode AsyncDataStream.OutputMode) : void in class org.apache.flink.streaming.api.operators.async.AsyncWaitOperatorTest | From | To | |
| Change Variable Type environment1 : AcknowledgeStreamMockEnvironment to restore : JobManagerTaskRestore in method public testRestoreHeadWithNewId() : void in class org.apache.flink.streaming.runtime.tasks.RestoreStreamTaskTest | From | To | |
| Change Variable Type environment : Environment to environment : MockEnvironment in method public testClosingWithBlockedEmitter() : void in class org.apache.flink.streaming.api.operators.async.AsyncWaitOperatorTest | From | To | |
| Change Variable Type mockEnvironment : Environment to mockEnvironment : MockEnvironment in method public testAsyncTimeout() : void in class org.apache.flink.streaming.api.operators.async.AsyncWaitOperatorTest | From | To | |
| Change Variable Type environment1 : AcknowledgeStreamMockEnvironment to restore : JobManagerTaskRestore in method public testRestoreTailWithNewId() : void in class org.apache.flink.streaming.runtime.tasks.RestoreStreamTaskTest | From | To | |
| Extract Variable | 5 | ||
| Extract Variable checkpointId : long in method public run() : void from class org.apache.flink.streaming.runtime.tasks.StreamTask.AsyncCheckpointRunnable | From | To | |
| Extract Variable streamSource : TestStreamSource<Long,MockSourceFunction> in method public testStateBackendClosingOnFailure() : void from class org.apache.flink.streaming.runtime.tasks.StreamTaskTest | From | To | |
| Extract Variable streamSource : TestStreamSource<Long,MockSourceFunction> in method public testStateBackendLoadingAndClosing() : void from class org.apache.flink.streaming.runtime.tasks.StreamTaskTest | From | To | |
| Extract Variable resourceProfiles : List<ResourceProfile> in method public testSlotAllocation() : void from class org.apache.flink.runtime.taskexecutor.TaskExecutorITCase | From | To | |
| Extract Variable environment : Environment in method public setup(containingTask StreamTask<?,?>, config StreamConfig, output Output<StreamRecord<OUT>>) : void from class org.apache.flink.streaming.api.operators.AbstractStreamOperator | From | To | |
| Rename Method | 3 | ||
| Rename Method public notifyOfCompletedCheckpoint(checkpointId long) : void renamed to public notifyCheckpointComplete(checkpointId long) : void in class org.apache.flink.streaming.api.operators.AbstractStreamOperator | From | To | |
| Rename Method public notifyOfCompletedCheckpoint(checkpointId long) : void renamed to public notifyCheckpointComplete(checkpointId long) : void in class org.apache.flink.streaming.runtime.operators.GenericWriteAheadSink | From | To | |
| Rename Method public notifyOfCompletedCheckpoint(checkpointId long) : void renamed to public notifyCheckpointComplete(checkpointId long) : void in class org.apache.flink.streaming.api.operators.AbstractUdfStreamOperator | From | To | |
| Rename Variable | 5 | ||
| Rename Variable mockenvironment : Environment to mockEnvironment : MockEnvironment in method private testTimeoutExceptionHandling(outputMode AsyncDataStream.OutputMode) : void in class org.apache.flink.streaming.api.operators.async.AsyncWaitOperatorTest | From | To | |
| Rename Variable environment1 : AcknowledgeStreamMockEnvironment to restore : JobManagerTaskRestore in method public testRestoreTailWithNewId() : void in class org.apache.flink.streaming.runtime.tasks.RestoreStreamTaskTest | From | To | |
| Rename Variable environment1 : AcknowledgeStreamMockEnvironment to restore : JobManagerTaskRestore in method public testRestoreHeadWithNewId() : void in class org.apache.flink.streaming.runtime.tasks.RestoreStreamTaskTest | From | To | |
| Rename Variable environment1 : AcknowledgeStreamMockEnvironment to restore : JobManagerTaskRestore in method public testRestoreWithoutState() : void in class org.apache.flink.streaming.runtime.tasks.RestoreStreamTaskTest | From | To | |
| Rename Variable massagedOperatorStateHandles : OperatorSubtaskState to operatorSubtaskState : OperatorSubtaskState in method public initializeState(operatorStateHandles OperatorStateHandles) : void in class org.apache.flink.streaming.util.AbstractStreamOperatorTestHarness | From | To | |
| Inline Method | 3 | ||
| Inline Method private initializeOperators(restored boolean) : void inlined to private initializeState() : void in class org.apache.flink.streaming.runtime.tasks.StreamTask | From | To | |
| Inline Method public getOperatorStateHandles() : Collection<OperatorStateHandle> inlined to public getRawOperatorStateInputs() : Iterable<StatePartitionStreamProvider> in class org.apache.flink.runtime.state.StateInitializationContextImpl | From | To | |
| Inline Method public invoke(mockEnv StreamMockEnvironment, initialState TaskStateSnapshot) : void inlined to public invoke(mockEnv StreamMockEnvironment) : void in class org.apache.flink.streaming.runtime.tasks.StreamTaskTestHarness | From | To | |
| Change Return Type | 3 | ||
| Change Return Type AcknowledgeStreamMockEnvironment to JobManagerTaskRestore in method private createRunAndCheckpointOperatorChain(headId OperatorID, headOperator OneInputStreamOperator<String,String>, tailId OperatorID, tailOperator OneInputStreamOperator<String,String>, restore Optional<JobManagerTaskRestore>) : JobManagerTaskRestore in class org.apache.flink.streaming.runtime.tasks.RestoreStreamTaskTest | From | To | |
| Change Return Type Environment to MockEnvironment in method public getEnvironment() : MockEnvironment in class org.apache.flink.streaming.util.AbstractStreamOperatorTestHarness | From | To | |
| Change Return Type Environment to MockEnvironment in method private createMockEnvironment() : MockEnvironment in class org.apache.flink.streaming.api.operators.async.AsyncWaitOperatorTest | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute keyGroupsStateHandles : Collection<KeyGroupsStateHandle> to rawKeyedStateInputs : Iterable<KeyGroupStatePartitionStreamProvider> in class org.apache.flink.runtime.state.StateInitializationContextImpl | From | To | |
| Rename Attribute operatorStateHandles : Collection<OperatorStateHandle> to rawOperatorStateInputs : Iterable<StatePartitionStreamProvider> in class org.apache.flink.runtime.state.StateInitializationContextImpl | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type environment : Environment to environment : MockEnvironment in class org.apache.flink.streaming.util.AbstractStreamOperatorTestHarness | From | To | |
| Change Attribute Type operatorStateHandles : Collection<OperatorStateHandle> to rawOperatorStateInputs : Iterable<StatePartitionStreamProvider> in class org.apache.flink.runtime.state.StateInitializationContextImpl | From | To | |
| Change Attribute Type taskFactory : BiFunction<Environment,TaskStateSnapshot,? extends StreamTask<OUT,?>> to taskFactory : Function<Environment,? extends StreamTask<OUT,?>> in class org.apache.flink.streaming.runtime.tasks.StreamTaskTestHarness | From | To | |
| Change Attribute Type keyGroupsStateHandles : Collection<KeyGroupsStateHandle> to rawKeyedStateInputs : Iterable<KeyGroupStatePartitionStreamProvider> in class org.apache.flink.runtime.state.StateInitializationContextImpl | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public getTaskStateManager() : TestTaskStateManager extracted from private AbstractStreamOperatorTestHarness(operator StreamOperator<OUT>, environment Environment, environmentIsInternal boolean) in class org.apache.flink.streaming.util.AbstractStreamOperatorTestHarness & moved to class org.apache.flink.runtime.operators.testutils.MockEnvironment | From | To | |
| Rename Parameter | 6 | ||
| Rename Parameter environment : Environment to env : MockEnvironment in method public AbstractStreamOperatorTestHarness(operator StreamOperator<OUT>, env MockEnvironment) in class org.apache.flink.streaming.util.AbstractStreamOperatorTestHarness | From | To | |
| Rename Parameter operatorStateHandles : Collection<OperatorStateHandle> to rawOperatorStateInputs : Iterable<StatePartitionStreamProvider> in method public StateInitializationContextImpl(restored boolean, operatorStateStore OperatorStateStore, keyedStateStore KeyedStateStore, rawKeyedStateInputs Iterable<KeyGroupStatePartitionStreamProvider>, rawOperatorStateInputs Iterable<StatePartitionStreamProvider>) in class org.apache.flink.runtime.state.StateInitializationContextImpl | From | To | |
| Rename Parameter stateHandles : Optional<TaskStateSnapshot> to restore : Optional<JobManagerTaskRestore> in method private createRunAndCheckpointOperatorChain(headId OperatorID, headOperator OneInputStreamOperator<String,String>, tailId OperatorID, tailOperator OneInputStreamOperator<String,String>, restore Optional<JobManagerTaskRestore>) : JobManagerTaskRestore in class org.apache.flink.streaming.runtime.tasks.RestoreStreamTaskTest | From | To | |
| Rename Parameter environment : Environment to env : MockEnvironment in method private AbstractStreamOperatorTestHarness(operator StreamOperator<OUT>, env MockEnvironment, environmentIsInternal boolean) in class org.apache.flink.streaming.util.AbstractStreamOperatorTestHarness | From | To | |
| Rename Parameter invocationOnMock : InvocationOnMock to invocation : InvocationOnMock in method public answer(invocation InvocationOnMock) : Object in class org.apache.flink.streaming.runtime.tasks.StreamTaskTest.testEmptySubtaskStateLeadsToStatelessAcknowledgment.acknowledgeCheckpoint.when.doAnswer | From | To | |
| Rename Parameter initialState : TaskStateSnapshot to timeProvider : ProcessingTimeService in method public OneInputStreamTask(env Environment, timeProvider ProcessingTimeService) in class org.apache.flink.streaming.runtime.tasks.OneInputStreamTask | From | To |