5b1e127f7b3acd8f82893dda394fbcb7fe93d20d
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 43
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 7 | ||
| Rename Method public notifyBuffersAvailable(buffers long) : void renamed to public notifyDataAvailable() : void in class org.apache.flink.runtime.io.network.partition.ResultSubpartitionView | From | To | |
| Rename Method public notifyBuffersAvailable(buffers long) : void renamed to public notifyDataAvailable() : void in class org.apache.flink.runtime.io.network.partition.SpillableSubpartitionView | From | To | |
| Rename Method public notifyBuffersAvailable(numBuffers long) : void renamed to public notifyDataAvailable() : void in class org.apache.flink.runtime.io.network.partition.PipelinedSubpartitionView | From | To | |
| Rename Method public notifyBuffersAvailable(numBuffers long) : void renamed to public notifyDataAvailable() : void in class org.apache.flink.runtime.io.network.partition.BufferAvailabilityListener | From | To | |
| Rename Method package getNumBuffersAvailable() : long renamed to package hasBuffersAvailable() : boolean in class org.apache.flink.runtime.io.network.netty.CreditBasedSequenceNumberingViewReader | From | To | |
| Rename Method public notifyBuffersAvailable(buffers long) : void renamed to public notifyDataAvailable() : void in class org.apache.flink.runtime.io.network.partition.SpilledSubpartitionView | From | To | |
| Rename Method private tryWriteAndClearBuffer(targetChannel int, serializer RecordSerializer<T>) : boolean renamed to private tryFinishCurrentBufferBuilder(targetChannel int, serializer RecordSerializer<T>) : boolean in class org.apache.flink.runtime.io.network.api.writer.RecordWriter | From | To | |
| Rename Variable | 1 | ||
| Rename Variable bufferConsumer : BufferConsumer to bufferBuilder : BufferBuilder in method private tryFinishCurrentBufferBuilder(targetChannel int, serializer RecordSerializer<T>) : boolean in class org.apache.flink.runtime.io.network.api.writer.RecordWriter | From | To | |
| Change Return Type | 6 | ||
| Change Return Type BufferAndAvailability to Optional<BufferAndAvailability> in method package abstract getNextBuffer() : Optional<BufferAndAvailability> in class org.apache.flink.runtime.io.network.partition.consumer.InputChannel | From | To | |
| Change Return Type BufferAndAvailability to Optional<BufferAndAvailability> in method public getNextBuffer() : Optional<BufferAndAvailability> in class org.apache.flink.runtime.io.network.partition.consumer.UnknownInputChannel | From | To | |
| Change Return Type long to boolean in method package hasBuffersAvailable() : boolean in class org.apache.flink.runtime.io.network.netty.CreditBasedSequenceNumberingViewReader | From | To | |
| Change Return Type BufferAndAvailability to Optional<BufferAndAvailability> in method package getNextBuffer() : Optional<BufferAndAvailability> in class org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel | From | To | |
| Change Return Type BufferAndAvailability to Optional<BufferAndAvailability> in method package getNextBuffer() : Optional<BufferAndAvailability> in class org.apache.flink.runtime.io.network.partition.consumer.InputChannelTest.MockInputChannel | From | To | |
| Change Return Type BufferAndAvailability to Optional<BufferAndAvailability> in method package getNextBuffer() : Optional<BufferAndAvailability> in class org.apache.flink.runtime.io.network.partition.consumer.LocalInputChannel | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.flink.runtime.io.network.partition.SpillableSubpartitionTest.AwaitableBufferAvailablityListener moved to org.apache.flink.runtime.io.network.partition.AwaitableBufferAvailablityListener | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute numBuffersAvailable : AtomicLong to dataAvailableNotification : AtomicBoolean in class org.apache.flink.runtime.io.network.util.TestSubpartitionConsumer | From | To | |
| Rename Attribute bufferConsumers : Optional<BufferConsumer>[] to bufferBuilders : Optional<BufferBuilder>[] in class org.apache.flink.runtime.io.network.api.writer.RecordWriter | From | To | |
| Rename Attribute numBuffersAvailable : AtomicLong to buffersAvailable : AtomicBoolean in class org.apache.flink.runtime.io.network.netty.CreditBasedSequenceNumberingViewReader | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type bufferConsumer : BufferConsumer to bufferBuilder : BufferBuilder in method private tryFinishCurrentBufferBuilder(targetChannel int, serializer RecordSerializer<T>) : boolean in class org.apache.flink.runtime.io.network.api.writer.RecordWriter | From | To | |
| Change Variable Type answer : Answer<InputChannel.BufferAndAvailability> to answer : Answer<Optional<BufferAndAvailability>> in method public readEndOfPartitionEvent() : TestInputChannel in class org.apache.flink.runtime.io.network.partition.consumer.TestInputChannel | From | To | |
| Change Variable Type answer : Answer<BufferAndAvailability> to answer : Answer<Optional<BufferAndAvailability>> in method private setupInputChannels() : void in class org.apache.flink.runtime.io.network.partition.consumer.StreamTestSingleInputGate | From | To | |
| Change Variable Type answer : Answer<InputChannel.BufferAndAvailability> to answer : Answer<Optional<BufferAndAvailability>> in method private wrapIterator(iterator MutableObjectIterator<T>) : IteratorWrappingTestSingleInputGate<T> in class org.apache.flink.runtime.io.network.partition.consumer.IteratorWrappingTestSingleInputGate | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type numBuffersAvailable : AtomicLong to dataAvailableNotification : AtomicBoolean in class org.apache.flink.runtime.io.network.util.TestSubpartitionConsumer | From | To | |
| Change Attribute Type bufferConsumers : Optional<BufferConsumer>[] to bufferBuilders : Optional<BufferBuilder>[] in class org.apache.flink.runtime.io.network.api.writer.RecordWriter | From | To | |
| Change Attribute Type stubbing : OngoingStubbing<InputChannel.BufferAndAvailability> to stubbing : OngoingStubbing<Optional<BufferAndAvailability>> in class org.apache.flink.runtime.io.network.partition.consumer.TestInputChannel | From | To | |
| Change Attribute Type buffersInBacklog : int to buffersInBacklog : AtomicInteger in class org.apache.flink.runtime.io.network.netty.PartitionRequestQueueTest.DefaultBufferResultSubpartitionView | From | To | |
| Change Attribute Type numBuffersAvailable : AtomicLong to buffersAvailable : AtomicBoolean in class org.apache.flink.runtime.io.network.netty.CreditBasedSequenceNumberingViewReader | From | To | |
| Extract Method | 9 | ||
| Extract Method private registerAvailableReader(reader NetworkSequenceViewReader) : void extracted from public userEventTriggered(ctx ChannelHandlerContext, msg Object) : void in class org.apache.flink.runtime.io.network.netty.PartitionRequestQueue | From | To | |
| Extract Method private notifyDataAvailable() : void extracted from private add(bufferConsumer BufferConsumer, finish boolean) : boolean in class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Extract Method private requestNewBufferBuilder(targetChannel int) : BufferBuilder extracted from private sendToTarget(record T, targetChannel int) : void in class org.apache.flink.runtime.io.network.api.writer.RecordWriter | From | To | |
| Extract Method private pollAvailableReader() : NetworkSequenceViewReader extracted from public userEventTriggered(ctx ChannelHandlerContext, msg Object) : void in class org.apache.flink.runtime.io.network.netty.PartitionRequestQueue | From | To | |
| Extract Method private notifyDataAvailable() : void extracted from public createReadView(availabilityListener BufferAvailabilityListener) : PipelinedSubpartitionView in class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Extract Method private registerAvailableReader(reader NetworkSequenceViewReader) : void extracted from private writeAndFlushNextMessageIfPossible(channel Channel) : void in class org.apache.flink.runtime.io.network.netty.PartitionRequestQueue | From | To | |
| Extract Method private pollAvailableReader() : NetworkSequenceViewReader extracted from private writeAndFlushNextMessageIfPossible(channel Channel) : void in class org.apache.flink.runtime.io.network.netty.PartitionRequestQueue | From | To | |
| Extract Method private processBufferConsumers() : void extracted from public addBufferConsumer(bufferConsumer BufferConsumer, targetChannel int) : void in class org.apache.flink.runtime.io.network.api.writer.AbstractCollectingResultPartitionWriter | From | To | |
| Extract Method private registerAvailableReader(reader NetworkSequenceViewReader) : void extracted from private enqueueAvailableReader(reader NetworkSequenceViewReader) : void in class org.apache.flink.runtime.io.network.netty.PartitionRequestQueue | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter awaitedNumNotifiedBuffers : long to awaitedNumNotifications : long in method package awaitNotifications(awaitedNumNotifications long, timeoutMillis long) : void in class org.apache.flink.runtime.io.network.partition.AwaitableBufferAvailablityListener | From | To |