695bc56a9e20b9d86eea14a02899b400d324a7ea
Files Diff
- Added: 13
- Removed: 8
- Renamed: 0
- Modified: 21
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public testTableSourceFactoryDiscovery() : void renamed to public testTableFactoryDiscovery() : void in class org.apache.flink.table.client.gateway.local.DependencyTest | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type result : DynamicResult<T> to result : Result<T> in method private deployJob(context ExecutionContext<T>, jobGraph JobGraph, result Result<T>) : void in class org.apache.flink.table.client.gateway.local.ProgramDeployer | From | To | |
| Change Parameter Type result : DynamicResult<C> to result : Result<C> in method public ProgramDeployer(context ExecutionContext<C>, jobName String, jobGraph JobGraph, result Result<C>, awaitJobResult boolean) in class org.apache.flink.table.client.gateway.local.ProgramDeployer | From | To | |
| Change Parameter Type context : ExecutionContext<T> to context : ExecutionContext<C> in method private executeQueryInternal(context ExecutionContext<C>, query String) : ResultDescriptor in class org.apache.flink.table.client.gateway.local.LocalExecutor | From | To | |
| Rename Variable | 1 | ||
| Rename Variable cmdCall : SqlCommandCall to parsedLine : Optional<SqlCommandCall> in method private parseCommand(line String) : Optional<SqlCommandCall> in class org.apache.flink.table.client.cli.CliClient | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute private clusterId : C from class org.apache.flink.table.client.gateway.local.MaterializedCollectBatchResult to protected clusterId : C from class org.apache.flink.table.client.gateway.local.result.BasicResult | From | To | |
| Pull Up Attribute private clusterId : C from class org.apache.flink.table.client.gateway.local.CollectStreamResult to protected clusterId : C from class org.apache.flink.table.client.gateway.local.result.BasicResult | From | To | |
| Change Return Type | 2 | ||
| Change Return Type SqlCommandCall to Optional<SqlCommandCall> in method public parse(stmt String) : Optional<SqlCommandCall> in class org.apache.flink.table.client.cli.SqlCommandParser | From | To | |
| Change Return Type JobExecutionResult to void in method private deployJob(context ExecutionContext<T>, jobGraph JobGraph, result Result<T>) : void in class org.apache.flink.table.client.gateway.local.ProgramDeployer | From | To | |
| Move Class | 7 | ||
| Move Class org.apache.flink.table.client.gateway.local.ChangelogResult moved to org.apache.flink.table.client.gateway.local.result.ChangelogResult | From | To | |
| Move Class org.apache.flink.table.client.gateway.local.MaterializedCollectBatchResult moved to org.apache.flink.table.client.gateway.local.result.MaterializedCollectBatchResult | From | To | |
| Move Class org.apache.flink.table.client.gateway.local.MaterializedCollectStreamResult moved to org.apache.flink.table.client.gateway.local.result.MaterializedCollectStreamResult | From | To | |
| Move Class org.apache.flink.table.client.gateway.local.MaterializedResult moved to org.apache.flink.table.client.gateway.local.result.MaterializedResult | From | To | |
| Move Class org.apache.flink.table.client.gateway.local.CollectStreamResult moved to org.apache.flink.table.client.gateway.local.result.CollectStreamResult | From | To | |
| Move Class org.apache.flink.table.client.gateway.local.ChangelogCollectStreamResult moved to org.apache.flink.table.client.gateway.local.result.ChangelogCollectStreamResult | From | To | |
| Move Class org.apache.flink.table.client.gateway.local.DynamicResult moved to org.apache.flink.table.client.gateway.local.result.DynamicResult | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.flink.table.client.gateway.local.result.BasicResult from classes [org.apache.flink.table.client.gateway.local.result.CollectStreamResult, org.apache.flink.table.client.gateway.local.result.MaterializedCollectBatchResult] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute TABLE_SOURCE_FACTORY_JAR_FILE : String to TABLE_FACTORY_JAR_FILE : String in class org.apache.flink.table.client.gateway.local.DependencyTest | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type cmdCall : SqlCommandCall to cmdCall : Optional<SqlCommandCall> in method public open() : void in class org.apache.flink.table.client.cli.CliClient | From | To | |
| Change Variable Type cmdCall : SqlCommandCall to parsedLine : Optional<SqlCommandCall> in method private parseCommand(line String) : Optional<SqlCommandCall> in class org.apache.flink.table.client.cli.CliClient | From | To | |
| Change Variable Type deployer : ProgramDeployer<T> to deployer : ProgramDeployer<C> in method private executeQueryInternal(context ExecutionContext<C>, query String) : ResultDescriptor in class org.apache.flink.table.client.gateway.local.LocalExecutor | From | To | |
| Change Variable Type result : DynamicResult<T> to result : DynamicResult<C> in method private executeQueryInternal(context ExecutionContext<C>, query String) : ResultDescriptor in class org.apache.flink.table.client.gateway.local.LocalExecutor | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type result : DynamicResult<C> to result : Result<C> in class org.apache.flink.table.client.gateway.local.ProgramDeployer | From | To | |
| Extract Method | 4 | ||
| Extract Method private deployJobOnExistingCluster(clusterId T, clusterDescriptor ClusterDescriptor<T>, jobGraph JobGraph, result Result<T>) : void extracted from private deployJob(context ExecutionContext<T>, jobGraph JobGraph, result DynamicResult<T>) : JobExecutionResult in class org.apache.flink.table.client.gateway.local.ProgramDeployer | From | To | |
| Extract Method private openCli(context SessionContext, executor Executor) : void extracted from private start() : void in class org.apache.flink.table.client.SqlClient | From | To | |
| Extract Method private deployJobOnNewCluster(clusterDescriptor ClusterDescriptor<T>, jobGraph JobGraph, result Result<T>, classLoader ClassLoader) : void extracted from private deployJob(context ExecutionContext<T>, jobGraph JobGraph, result DynamicResult<T>) : JobExecutionResult in class org.apache.flink.table.client.gateway.local.ProgramDeployer | From | To | |
| Extract Method private parseCommand(line String) : Optional<SqlCommandCall> extracted from public open() : void in class org.apache.flink.table.client.cli.CliClient | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter query : String to selectQuery : String in method private createTable(tableEnv TableEnvironment, selectQuery String) : Table in class org.apache.flink.table.client.gateway.local.LocalExecutor | From | To |