771277b42427d55b52a28d5893c71c3b8de97807
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 14
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public getNumberPendingSlotRequests() : int renamed to public getNumberPendingTaskManagerSlots() : int in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Rename Method public createTestingResourceActions() : TestingResourceActions renamed to public build() : TestingResourceActions in class org.apache.flink.runtime.resourcemanager.slotmanager.TestingResourceActionsBuilder | From | To | |
| Rename Method protected getNumberPendingSlotRequests() : int renamed to protected getNumberRequiredTaskManagerSlots() : int in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type allocateResourceConsumer : Consumer<ResourceProfile> to allocateResourceFunction : FunctionWithException<ResourceProfile,Collection<ResourceProfile>,ResourceManagerException> in method public TestingResourceActions(releaseResourceConsumer BiConsumer<InstanceID,Exception>, allocateResourceFunction FunctionWithException<ResourceProfile,Collection<ResourceProfile>,ResourceManagerException>, notifyAllocationFailureConsumer Consumer<Tuple3<JobID,AllocationID,Exception>>) in class org.apache.flink.runtime.resourcemanager.slotmanager.TestingResourceActions | From | To | |
| Change Return Type | 6 | ||
| Change Return Type void to Collection<ResourceProfile> in method public allocateResource(resourceProfile ResourceProfile) : Collection<ResourceProfile> in class org.apache.flink.runtime.resourcemanager.ResourceManager.ResourceActionsImpl | From | To | |
| Change Return Type void to Collection<ResourceProfile> in method public allocateResource(resourceProfile ResourceProfile) : Collection<ResourceProfile> in class org.apache.flink.runtime.resourcemanager.slotmanager.TestingResourceActions | From | To | |
| Change Return Type void to Collection<ResourceProfile> in method public allocateResource(resourceProfile ResourceProfile) : Collection<ResourceProfile> in class org.apache.flink.runtime.resourcemanager.slotmanager.ResourceActions | From | To | |
| Change Return Type void to Collection<ResourceProfile> in method public abstract startNewWorker(resourceProfile ResourceProfile) : Collection<ResourceProfile> in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Change Return Type void to Collection<ResourceProfile> in method public startNewWorker(resourceProfile ResourceProfile) : Collection<ResourceProfile> in class org.apache.flink.yarn.YarnResourceManager | From | To | |
| Change Return Type void to Collection<ResourceProfile> in method public startNewWorker(resourceProfile ResourceProfile) : Collection<ResourceProfile> in class org.apache.flink.mesos.runtime.clusterframework.MesosResourceManager | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute allocateResourceConsumer : Consumer<ResourceProfile> to allocateResourceFunction : FunctionWithException<ResourceProfile,Collection<ResourceProfile>,ResourceManagerException> in class org.apache.flink.runtime.resourcemanager.slotmanager.TestingResourceActionsBuilder | From | To | |
| Rename Attribute allocateResourceConsumer : Consumer<ResourceProfile> to allocateResourceFunction : FunctionWithException<ResourceProfile,Collection<ResourceProfile>,ResourceManagerException> in class org.apache.flink.runtime.resourcemanager.slotmanager.TestingResourceActions | From | To | |
| Extract Variable | 2 | ||
| Extract Variable resourceProfile : ResourceProfile in method private internalRequestSlot(pendingSlotRequest PendingSlotRequest) : void from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Extract Variable cause : FlinkException in method private checkTaskManagerTimeouts() : void from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type allocateResourceConsumer : Consumer<ResourceProfile> to allocateResourceFunction : FunctionWithException<ResourceProfile,Collection<ResourceProfile>,ResourceManagerException> in class org.apache.flink.runtime.resourcemanager.slotmanager.TestingResourceActionsBuilder | From | To | |
| Change Attribute Type allocateResourceConsumer : Consumer<ResourceProfile> to allocateResourceFunction : FunctionWithException<ResourceProfile,Collection<ResourceProfile>,ResourceManagerException> in class org.apache.flink.runtime.resourcemanager.slotmanager.TestingResourceActions | From | To | |
| Extract Method | 5 | ||
| Extract Method private requestYarnContainerIfRequired(resource Resource, priority Priority) : void extracted from public onContainersAllocated(containers List<Container>) : void in class org.apache.flink.yarn.YarnResourceManager | From | To | |
| Extract Method private requestYarnContainerIfRequired(resource Resource, priority Priority) : void extracted from public onContainersCompleted(statuses List<ContainerStatus>) : void in class org.apache.flink.yarn.YarnResourceManager | From | To | |
| Extract Method private createSlotRequest(jobId JobID, resourceProfile ResourceProfile) : SlotRequest extracted from private createSlotRequest(jobId1 JobID) : SlotRequest in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest | From | To | |
| Extract Method private createAndRegisterTaskManagerSlot(slotId SlotID, resourceProfile ResourceProfile, taskManagerConnection TaskExecutorConnection) : TaskManagerSlot extracted from private registerSlot(slotId SlotID, allocationId AllocationID, jobId JobID, resourceProfile ResourceProfile, taskManagerConnection TaskExecutorConnection) : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Extract Method private createSlotReport(taskExecutorResourceId ResourceID, numberSlots int, resourceProfile ResourceProfile) : SlotReport extracted from private createSlotReport(taskExecutorResourceId ResourceID, numberSlots int) : SlotReport in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter jobId1 : JobID to jobId : JobID in method private createSlotRequest(jobId JobID) : SlotRequest in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest | From | To | |
| Rename Parameter allocateResourceConsumer : Consumer<ResourceProfile> to allocateResourceFunction : FunctionWithException<ResourceProfile,Collection<ResourceProfile>,ResourceManagerException> in method public TestingResourceActions(releaseResourceConsumer BiConsumer<InstanceID,Exception>, allocateResourceFunction FunctionWithException<ResourceProfile,Collection<ResourceProfile>,ResourceManagerException>, notifyAllocationFailureConsumer Consumer<Tuple3<JobID,AllocationID,Exception>>) in class org.apache.flink.runtime.resourcemanager.slotmanager.TestingResourceActions | From | To | |
| Rename Parameter jobId1 : JobID to jobId : JobID in method private createSlotRequest(jobId JobID, resourceProfile ResourceProfile) : SlotRequest in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest | From | To |