782ec6dc4c3a4d4825c8f99af0b596be766c1312
Files Diff
- Added: 14
- Removed: 2
- Renamed: 0
- Modified: 15
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 1 | ||
Change Parameter Type statusId : StatusId to id : Id in method public QueueStatus(id Id) in class org.apache.flink.runtime.rest.messages.queue.QueueStatus | From | To | |
Move Method | 1 | ||
Move Method public getLocation() : String from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointTriggerResponseBody to public getLocation() : String from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointInfo | From | To | |
Move Attribute | 4 | ||
Move Attribute private FIELD_NAME_LOCATION : String from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointTriggerResponseBody to private FIELD_NAME_LOCATION : String from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointInfo | From | To | |
Move Attribute public location : String from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointTriggerResponseBody to private location : String from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointInfo | From | To | |
Move Attribute private FIELD_NAME_STATUS : String from class org.apache.flink.runtime.rest.messages.queue.QueueStatus to private FIELD_NAME_STATUS : String from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointResponseBody | From | To | |
Move Attribute private FIELD_NAME_STATUS : String from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointTriggerResponseBody to private FIELD_NAME_STATUS : String from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointResponseBody | From | To | |
Extract Class | 2 | ||
Extract Class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointResponseBody from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointTriggerResponseBody | From | To | |
Extract Class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointInfo from class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointTriggerResponseBody | From | To | |
Rename Class | 2 | ||
Rename Class org.apache.flink.runtime.rest.messages.queue.QueueStatus.StatusId renamed to org.apache.flink.runtime.rest.messages.queue.QueueStatus.Id | From | To | |
Rename Class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointMessageParameters renamed to org.apache.flink.runtime.rest.messages.job.savepoints.SavepointTriggerMessageParameters | From | To | |
Change Variable Type | 2 | ||
Change Variable Type params : SavepointMessageParameters to savepointStatusMessageParameters : SavepointStatusMessageParameters in method private waitForSavepointCompletion(jobId JobID, savepointTriggerId SavepointTriggerId) : SavepointInfo in class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
Change Variable Type headers : SavepointTriggerHeaders to savepointStatusHeaders : SavepointStatusHeaders in method private waitForSavepointCompletion(jobId JobID, savepointTriggerId SavepointTriggerId) : SavepointInfo in class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
Extract Method | 2 | ||
Extract Method private waitForSavepointCompletion(jobId JobID, savepointTriggerId SavepointTriggerId) : SavepointInfo extracted from public triggerSavepoint(jobId JobID, savepointDirectory String) : CompletableFuture<String> in class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
Extract Method protected assertOriginalEqualsToUnmarshalled(expected R, actual R) : void extracted from public testJsonMarshalling() : void in class org.apache.flink.runtime.rest.messages.RestRequestMarshallingTestBase | From | To | |
Rename Method | 1 | ||
Rename Method public getStatusId() : StatusId renamed to public getId() : Id in class org.apache.flink.runtime.rest.messages.queue.QueueStatus | From | To | |
Rename Variable | 2 | ||
Rename Variable headers : SavepointTriggerHeaders to savepointStatusHeaders : SavepointStatusHeaders in method private waitForSavepointCompletion(jobId JobID, savepointTriggerId SavepointTriggerId) : SavepointInfo in class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
Rename Variable params : SavepointMessageParameters to savepointStatusMessageParameters : SavepointStatusMessageParameters in method private waitForSavepointCompletion(jobId JobID, savepointTriggerId SavepointTriggerId) : SavepointInfo in class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
Change Return Type | 3 | ||
Change Return Type Class<EmptyRequestBody> to Class<SavepointTriggerRequestBody> in method public getRequestClass() : Class<SavepointTriggerRequestBody> in class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointTriggerHeaders | From | To | |
Change Return Type StatusId to Id in method public getId() : Id in class org.apache.flink.runtime.rest.messages.queue.QueueStatus | From | To | |
Change Return Type SavepointMessageParameters to SavepointTriggerMessageParameters in method public getUnresolvedMessageParameters() : SavepointTriggerMessageParameters in class org.apache.flink.runtime.rest.messages.job.savepoints.SavepointTriggerHeaders | From | To | |
Parameterize Variable | 1 | ||
Parameterize Variable unmarshalled : R to actual : R in method protected assertOriginalEqualsToUnmarshalled(expected R, actual R) : void in class org.apache.flink.runtime.rest.messages.RestRequestMarshallingTestBase | From | To | |
Rename Attribute | 1 | ||
Rename Attribute statusId : StatusId to id : Id in class org.apache.flink.runtime.rest.messages.queue.QueueStatus | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type statusId : StatusId to id : Id in class org.apache.flink.runtime.rest.messages.queue.QueueStatus | From | To | |
Rename Parameter | 1 | ||
Rename Parameter statusId : StatusId to id : Id in method public QueueStatus(id Id) in class org.apache.flink.runtime.rest.messages.queue.QueueStatus | From | To |