flink 7bca9e4613ff30ab6a9c11e673a785f3f5c86e69

7bca9e4613ff30ab6a9c11e673a785f3f5c86e69

Files Diff

Added: 2
Removed: 0
Renamed: 0
Modified: 32

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method public abstract releaseSlot() : void renamed to public abstract releaseInstanceSlot() : void in class org.apache.flink.runtime.instance.Slot	From	To
Rename Method public releaseSlot() : void renamed to public releaseInstanceSlot() : void in class org.apache.flink.runtime.instance.SharedSlot	From	To
Rename Method public getTerminationFuture() : CompletableFuture<ExecutionState> renamed to public getTerminalStateFuture() : CompletableFuture<ExecutionState> in class org.apache.flink.runtime.executiongraph.Execution	From	To
Move And Inline Method	1
Move And Inline Method public isCanceled() : boolean moved from class org.apache.flink.runtime.instance.TestingLogicalSlot to class org.apache.flink.runtime.executiongraph.ExecutionGraphSchedulingTest & inlined to public testTimeoutForSlotAllocation() : void	From	To
Rename Variable	1
Rename Variable ev : Execution to payload1 : TestingPayload in method public testSetExecutionVertex() : void in class org.apache.flink.runtime.instance.SimpleSlotTest	From	To
Change Return Type	9
Change Return Type boolean to CompletableFuture<Boolean> in method public returnAllocatedSlot(slot Slot) : CompletableFuture<Boolean> in class org.apache.flink.runtime.jobmanager.slots.SlotOwner	From	To
Change Return Type boolean to CompletableFuture<Boolean> in method public returnAllocatedSlot(slot Slot) : CompletableFuture<Boolean> in class org.apache.flink.runtime.instance.SlotPool.ProviderAndOwner	From	To
Change Return Type boolean to CompletableFuture<Boolean> in method public returnAllocatedSlot(slot Slot) : CompletableFuture<Boolean> in class org.apache.flink.runtime.executiongraph.utils.SimpleSlotProvider	From	To
Change Return Type void to CompletableFuture<?> in method public releaseSlot() : CompletableFuture<?> in class org.apache.flink.runtime.instance.SimpleSlot	From	To
Change Return Type void to CompletableFuture<?> in method public releaseSlot() : CompletableFuture<?> in class org.apache.flink.runtime.instance.LogicalSlot	From	To
Change Return Type boolean to CompletableFuture<Boolean> in method public returnAllocatedSlot(slot Slot) : CompletableFuture<Boolean> in class org.apache.flink.runtime.executiongraph.ExecutionTest.SingleSlotTestingSlotOwner	From	To
Change Return Type void to CompletableFuture<?> in method public releaseSlot() : CompletableFuture<?> in class org.apache.flink.runtime.instance.TestingLogicalSlot	From	To
Change Return Type boolean to CompletableFuture<Boolean> in method public returnAllocatedSlot(slot Slot) : CompletableFuture<Boolean> in class org.apache.flink.runtime.instance.Instance	From	To
Change Return Type CompletableFuture<ExecutionState> to CompletableFuture<?> in method public cancel() : CompletableFuture<?> in class org.apache.flink.runtime.executiongraph.ExecutionVertex	From	To
Rename Class	1
Rename Class org.apache.flink.runtime.executiongraph.ExecutionTest.TestingSlotOwner renamed to org.apache.flink.runtime.executiongraph.ExecutionTest.SingleSlotTestingSlotOwner	From	To
Replace Variable With Attribute	1
Replace Variable With Attribute exec : Execution to payload : Payload in method public releaseSlot() : CompletableFuture<?> in class org.apache.flink.runtime.instance.SimpleSlot	From	To
Rename Attribute	1
Rename Attribute executionReference : AtomicReference<Execution> to payloadReference : AtomicReference<Payload> in class org.apache.flink.runtime.instance.TestingLogicalSlot	From	To
Change Variable Type	5
Change Variable Type slotOwner : TestingSlotOwner to slotOwner : SingleSlotTestingSlotOwner in method public testSlotReleaseOnExecutionCancellationInScheduled() : void in class org.apache.flink.runtime.executiongraph.ExecutionTest	From	To
Change Variable Type slotOwner : TestingSlotOwner to slotOwner : SingleSlotTestingSlotOwner in method public testSlotReleaseOnFailedResourceAssignment() : void in class org.apache.flink.runtime.executiongraph.ExecutionTest	From	To
Change Variable Type ev : Execution to payload1 : TestingPayload in method public testSetExecutionVertex() : void in class org.apache.flink.runtime.instance.SimpleSlotTest	From	To
Change Variable Type slotOwner : TestingSlotOwner to slotOwner : SingleSlotTestingSlotOwner in method public testSlotReleaseOnExecutionCancellationInRunning() : void in class org.apache.flink.runtime.executiongraph.ExecutionTest	From	To
Change Variable Type exec : Execution to payload : Payload in method public releaseSlot() : CompletableFuture<?> in class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract Interface	1
Extract Interface org.apache.flink.runtime.instance.LogicalSlot.Payload from classes [org.apache.flink.runtime.executiongraph.Execution]	From	To
Change Attribute Type	1
Change Attribute Type executionReference : AtomicReference<Execution> to payloadReference : AtomicReference<Payload> in class org.apache.flink.runtime.instance.TestingLogicalSlot	From	To
Extract Method	4
Extract Method private releaseAssignedResource() : void extracted from private processFail(t Throwable, isCallback boolean, userAccumulators Map<String,Accumulator<?,?>>, metrics IOMetrics) : boolean in class org.apache.flink.runtime.executiongraph.Execution	From	To
Extract Method private releaseAssignedResource() : void extracted from package cancelingComplete(userAccumulators Map<String,Accumulator<?,?>>, metrics IOMetrics) : void in class org.apache.flink.runtime.executiongraph.Execution	From	To
Extract Method private releaseAssignedResource() : void extracted from public cancel() : void in class org.apache.flink.runtime.executiongraph.Execution	From	To
Extract Method private releaseAssignedResource() : void extracted from package markFinished(userAccumulators Map<String,Accumulator<?,?>>, metrics IOMetrics) : void in class org.apache.flink.runtime.executiongraph.Execution	From	To
Extract And Move Method	17
Extract And Move Method public releaseInstanceSlot() : void extracted from public testImmediateReleaseOneLevel() : void in class org.apache.flink.runtime.instance.SharedSlotsTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public allocateSimpleSlotsAndReleaseFromLeaves() : void in class org.apache.flink.runtime.instance.SharedSlotsTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public testSlotReleasedWhenScheduledQueued() : void in class org.apache.flink.runtime.executiongraph.ExecutionVertexSchedulingTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public failAllocation(allocationID AllocationID, cause Exception) : void in class org.apache.flink.runtime.instance.SlotPool & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public markDead() : void in class org.apache.flink.runtime.instance.Instance & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public testImmediateReleaseTwoLevel() : void in class org.apache.flink.runtime.instance.SharedSlotsTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public testStateTransitions() : void in class org.apache.flink.runtime.instance.SimpleSlotTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public releaseTaskManager(resourceID ResourceID) : CompletableFuture<Acknowledge> in class org.apache.flink.runtime.instance.SlotPool & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public cancelAndReleaseAllSlots() : void in class org.apache.flink.runtime.instance.Instance & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from package releaseSharedSlot(sharedSlot SharedSlot) : void in class org.apache.flink.runtime.instance.SlotSharingGroupAssignment & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public testReleaseTwoLevelsFromRoot() : void in class org.apache.flink.runtime.instance.SharedSlotsTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public testSetExecutionVertex() : void in class org.apache.flink.runtime.instance.SimpleSlotTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public testSlotReleasedWhenScheduledImmediately() : void in class org.apache.flink.runtime.executiongraph.ExecutionVertexSchedulingTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public testAllocatingAndCancellingSlots() : void in class org.apache.flink.runtime.instance.InstanceTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from private scheduleTask(task ScheduledUnit, queueIfNoResource boolean, preferredLocations Iterable<TaskManagerLocation>) : Object in class org.apache.flink.runtime.jobmanager.scheduler.Scheduler & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public testAllocateAndReleaseTwoLevels() : void in class org.apache.flink.runtime.instance.SharedSlotsTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To
Extract And Move Method public releaseInstanceSlot() : void extracted from public allocateAndReleaseInMixedOrder() : void in class org.apache.flink.runtime.instance.SharedSlotsTest & moved to class org.apache.flink.runtime.instance.SimpleSlot	From	To

7bca9e4613ff30ab6a9c11e673a785f3f5c86e69

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: