7e9dfdf3de82ffedcba9ef71668f075ac8597bcc
Files Diff
- Added: 11
- Removed: 4
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public getExecutor() : Executor from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest.TestingSlotManager to public getAsyncExecutor() : Executor from class org.apache.flink.runtime.resourcemanager.TestingSlotManager.TestingResourceManagerServices | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type taskExecutorGateway : TaskExecutorGateway to taskExecutorRegistration : TaskExecutorRegistration in method public ResourceSlot(slotId SlotID, resourceProfile ResourceProfile, taskExecutorRegistration TaskExecutorRegistration) in class org.apache.flink.runtime.clusterframework.types.ResourceSlot | From | To | |
| Change Parameter Type slotManager : SlotManager to slotManagerFactory : SlotManagerFactory in method public StandaloneResourceManager(rpcService RpcService, highAvailabilityServices HighAvailabilityServices, slotManagerFactory SlotManagerFactory) in class org.apache.flink.runtime.resourcemanager.StandaloneResourceManager | From | To | |
| Change Parameter Type slotManager : SlotManager to slotManagerFactory : SlotManagerFactory in method public ResourceManager(rpcService RpcService, highAvailabilityServices HighAvailabilityServices, slotManagerFactory SlotManagerFactory) in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Move Method | 3 | ||
| Move Method public getResourceID() : ResourceID from class org.apache.flink.runtime.taskexecutor.SlotReport to public getResourceID() : ResourceID from class org.apache.flink.runtime.resourcemanager.messages.taskexecutor.TMSlotRequestReply | From | To | |
| Move Method public allocateResource(resourceProfile ResourceProfile) : void from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest.TestingSlotManager to public allocateResource(resourceProfile ResourceProfile) : void from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest.TestingSlotManager.TestingRmServices | From | To | |
| Move Method public getAsyncExecutor() : Executor from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest.TestingSlotManager to public getAsyncExecutor() : Executor from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest.TestingSlotManager.TestingRmServices | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private allocatedContainers : List<ResourceProfile> from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest.TestingSlotManager to private allocatedContainers : List<ResourceProfile> from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest.TestingSlotManager.TestingRmServices | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest.TestingSlotManager.TestingRmServices from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest.TestingSlotManager | From | To | |
| Move And Rename Class | 4 | ||
| Move And Rename Class org.apache.flink.runtime.resourcemanager.SlotRequestReply moved and renamed to org.apache.flink.runtime.resourcemanager.messages.jobmanager.RMSlotRequestReply | From | To | |
| Move And Rename Class org.apache.flink.runtime.resourcemanager.SlotRequestRegistered moved and renamed to org.apache.flink.runtime.resourcemanager.messages.jobmanager.RMSlotRequestRegistered | From | To | |
| Move And Rename Class org.apache.flink.runtime.resourcemanager.SlotRequestRejected moved and renamed to org.apache.flink.runtime.resourcemanager.messages.jobmanager.RMSlotRequestRejected | From | To | |
| Move And Rename Class org.apache.flink.runtime.resourcemanager.slotmanager.SimpleSlotManager moved and renamed to org.apache.flink.runtime.resourcemanager.TestingSlotManager | From | To | |
| Extract Variable | 1 | ||
| Extract Variable allocationID : AllocationID in method public testMultipleSlotRequestsWithOneSlot() : void from class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type slotRequestReply : SlotRequestReply to slotRequestReply : RMSlotRequestReply in method public testSlotsUnavailableRequest() : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotProtocolTest | From | To | |
| Change Variable Type slotRequestReply : SlotRequestReply to slotRequestReply : RMSlotRequestReply in method public testSlotAvailableRequest() : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotProtocolTest | From | To | |
| Change Variable Type taskExecutorGateway : TaskExecutorGateway to taskExecutorRegistration : TaskExecutorRegistration in method public registerTaskExecutor(resourceID ResourceID, registration TaskExecutorRegistration, slotReport SlotReport) : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Extract Method | 1 | ||
| Extract Method protected createResourceManagerServices() : ResourceManagerServices extracted from public start() : void in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Rename Method | 5 | ||
| Rename Method public updateSlotStatus(slotReport SlotReport) : void renamed to public registerTaskExecutor(resourceID ResourceID, registration TaskExecutorRegistration, slotReport SlotReport) : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Rename Method public testExistingInUseSlotAdjustedToEmpty() : void renamed to public testMultipleSlotRequestsWithOneSlot() : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest | From | To | |
| Rename Method public getExecutor() : Executor renamed to public getMainThreadExecutor() : Executor in class org.apache.flink.runtime.resourcemanager.ResourceManager.DefaultResourceManagerServices | From | To | |
| Rename Method public getTaskExecutorGateway() : TaskExecutorGateway renamed to public getTaskExecutorRegistration() : TaskExecutorRegistration in class org.apache.flink.runtime.clusterframework.types.ResourceSlot | From | To | |
| Rename Method public getExecutor() : Executor renamed to public getMainThreadExecutor() : Executor in class org.apache.flink.runtime.resourcemanager.ResourceManagerServices | From | To | |
| Rename Variable | 3 | ||
| Rename Variable taskExecutorGateway : TaskExecutorGateway to taskExecutorRegistration : TaskExecutorRegistration in method public registerTaskExecutor(resourceID ResourceID, registration TaskExecutorRegistration, slotReport SlotReport) : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Rename Variable currentAllocationId : AllocationID to expectedAllocationId : AllocationID in method package handleSlotRequestFailedAtTaskManager(originalRequest SlotRequest, slotId SlotID) : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Rename Variable removedSlotRequest : SlotRequest to slotRequest : SlotRequest in method private handleFreeSlot(freeSlot ResourceSlot) : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Inline Method | 1 | ||
| Inline Method package updateSlotStatus(reportedStatus SlotStatus) : void inlined to public registerTaskExecutor(resourceID ResourceID, registration TaskExecutorRegistration, slotReport SlotReport) : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Change Return Type | 6 | ||
| Change Return Type SlotRequestRegistered to RMSlotRequestRegistered in method public requestSlot(request SlotRequest) : RMSlotRequestRegistered in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Change Return Type TaskExecutorGateway to TaskExecutorRegistration in method public getTaskExecutorRegistration() : TaskExecutorRegistration in class org.apache.flink.runtime.clusterframework.types.ResourceSlot | From | To | |
| Change Return Type boolean to void in method private registerNewSlot(slot ResourceSlot) : void in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Change Return Type Future<SlotRequestReply> to Future<RMSlotRequestReply> in method public requestSlot(jobMasterLeaderID UUID, resourceManagerLeaderID UUID, slotRequest SlotRequest, timeout Time) : Future<RMSlotRequestReply> in class org.apache.flink.runtime.resourcemanager.ResourceManagerGateway | From | To | |
| Change Return Type SlotRequestReply to RMSlotRequestReply in method public requestSlot(jobMasterLeaderID UUID, resourceManagerLeaderID UUID, slotRequest SlotRequest) : RMSlotRequestReply in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Change Return Type ResourceManager to StandaloneResourceManager in method private createAndStartResourceManager(rmLeaderElectionService TestingLeaderElectionService) : StandaloneResourceManager in class org.apache.flink.runtime.resourcemanager.ResourceManagerTaskExecutorTest | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute taskExecutorGateways : Map<ResourceID,WorkerType> to taskExecutors : Map<ResourceID,WorkerRegistration<WorkerType>> in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Rename Attribute taskManagerGateways : Map<ResourceID,TaskExecutorGateway> to taskManagers : Map<ResourceID,TaskExecutorRegistration> in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Rename Attribute taskExecutorGateway : TaskExecutorGateway to taskExecutorRegistration : TaskExecutorRegistration in class org.apache.flink.runtime.clusterframework.types.ResourceSlot | From | To | |
| Rename Attribute taskExecutorGateway : TaskExecutorGateway to taskExecutorRegistration : TaskExecutorRegistration in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type taskManagerGateways : Map<ResourceID,TaskExecutorGateway> to taskManagers : Map<ResourceID,TaskExecutorRegistration> in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManager | From | To | |
| Change Attribute Type taskExecutorGateway : TaskExecutorGateway to taskExecutorRegistration : TaskExecutorRegistration in class org.apache.flink.runtime.clusterframework.types.ResourceSlot | From | To | |
| Change Attribute Type taskExecutorGateway : TaskExecutorGateway to taskExecutorRegistration : TaskExecutorRegistration in class org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerTest | From | To | |
| Change Attribute Type taskExecutorGateways : Map<ResourceID,WorkerType> to taskExecutors : Map<ResourceID,WorkerRegistration<WorkerType>> in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter taskExecutorGateway : TaskExecutorGateway to taskExecutorRegistration : TaskExecutorRegistration in method public ResourceSlot(slotId SlotID, resourceProfile ResourceProfile, taskExecutorRegistration TaskExecutorRegistration) in class org.apache.flink.runtime.clusterframework.types.ResourceSlot | From | To | |
| Rename Parameter slotManager : SlotManager to slotManagerFactory : SlotManagerFactory in method public StandaloneResourceManager(rpcService RpcService, highAvailabilityServices HighAvailabilityServices, slotManagerFactory SlotManagerFactory) in class org.apache.flink.runtime.resourcemanager.StandaloneResourceManager | From | To | |
| Rename Parameter slotManager : SlotManager to slotManagerFactory : SlotManagerFactory in method public ResourceManager(rpcService RpcService, highAvailabilityServices HighAvailabilityServices, slotManagerFactory SlotManagerFactory) in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To |