85bae442e62d55a66e3943ea6615cda2a51a7b5f
Files Diff
- Added: 8
- Removed: 3
- Renamed: 0
- Modified: 45
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type slot : SimpleSlot to slot : LogicalSlot in method public deployToSlot(slot LogicalSlot) : void in class org.apache.flink.runtime.executiongraph.ExecutionVertex | From | To | |
| Move Method | 3 | ||
| Move Method public execute(command Runnable) : void from class org.apache.flink.core.testutils.ManuallyTriggeredDirectExecutor to public execute(command Runnable) : void from class org.apache.flink.runtime.concurrent.ManuallyTriggeredScheduledExecutor | From | To | |
| Move Method public numQueuedRunnables() : int from class org.apache.flink.core.testutils.ManuallyTriggeredDirectExecutor to public numQueuedRunnables() : int from class org.apache.flink.runtime.concurrent.ManuallyTriggeredScheduledExecutor | From | To | |
| Move Method public trigger() : void from class org.apache.flink.core.testutils.ManuallyTriggeredDirectExecutor to public trigger() : void from class org.apache.flink.runtime.concurrent.ManuallyTriggeredScheduledExecutor | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private queuedRunnables : ArrayDeque<Runnable> from class org.apache.flink.core.testutils.ManuallyTriggeredDirectExecutor to private queuedRunnables : ArrayDeque<Runnable> from class org.apache.flink.runtime.concurrent.ManuallyTriggeredScheduledExecutor | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.flink.runtime.executiongraph.IndividualRestartsConcurrencyTest renamed to org.apache.flink.runtime.executiongraph.ConcurrentFailoverStrategyExecutionGraphTest | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type allVertices : ArrayList<ExecutionVertex> to connectedExecutions : List<ExecutionVertex> in method protected createFailoverRegion(eg ExecutionGraph, connectedExecutions List<ExecutionVertex>) : FailoverRegion in class org.apache.flink.runtime.executiongraph.failover.RestartPipelinedRegionStrategy | From | To | |
| Change Variable Type slot : SimpleSlot to testingLogicalSlot : TestingLogicalSlot in method public testFailExternallyDuringDeploy() : void in class org.apache.flink.runtime.executiongraph.ExecutionVertexDeploymentTest | From | To | |
| Extract Variable | 5 | ||
| Extract Variable jobInformation : JobInformation in method private createSampleGraph(jid JobID, failoverStrategy Factory, restartStrategy RestartStrategy, slotProvider SlotProvider, parallelism int) : ExecutionGraph from class org.apache.flink.runtime.executiongraph.ConcurrentFailoverStrategyExecutionGraphTest | From | To | |
| Extract Variable directExecutor : DirectScheduledExecutorService in method public testNoResourceAvailableFailure() : void from class org.apache.flink.runtime.executiongraph.ExecutionGraphDeploymentTest | From | To | |
| Extract Variable executorService : DirectScheduledExecutorService in method private setupExecution(v1 JobVertex, dop1 int, v2 JobVertex, dop2 int) : Tuple2<ExecutionGraph,Map<ExecutionAttemptID,Execution>> from class org.apache.flink.runtime.executiongraph.ExecutionGraphDeploymentTest | From | To | |
| Extract Variable restartStrategy : TestRestartStrategy in method public testRestartWithSlotSharingAndNotEnoughResources() : void from class org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest | From | To | |
| Extract Variable executionGraph : ExecutionGraph in method public scheduleForExecution(slotProvider SlotProvider, queued boolean, locationPreferenceConstraint LocationPreferenceConstraint, allPreviousExecutionGraphAllocationIds Set<AllocationID>) : CompletableFuture<Void> from class org.apache.flink.runtime.executiongraph.Execution | From | To | |
| Inline Variable | 1 | ||
| Inline Variable slotReturnFuture : CompletableFuture<Boolean> in method private returnSlotToOwner(terminalStateFuture CompletableFuture<?>) : void from class org.apache.flink.runtime.jobmaster.slotpool.SingleLogicalSlot | From | To | |
| Extract Method | 5 | ||
| Extract Method protected createFailoverRegion(eg ExecutionGraph, connectedExecutions List<ExecutionVertex>) : FailoverRegion extracted from private generateAllFailoverRegion(newJobVerticesTopological List<ExecutionJobVertex>) : void in class org.apache.flink.runtime.executiongraph.failover.RestartPipelinedRegionStrategy | From | To | |
| Extract Method protected createFailoverRegion(eg ExecutionGraph, connectedExecutions List<ExecutionVertex>) : FailoverRegion extracted from private makeAllOneRegion(jobVertices List<ExecutionJobVertex>) : void in class org.apache.flink.runtime.executiongraph.failover.RestartPipelinedRegionStrategy | From | To | |
| Extract Method public runAsync(runnable Runnable) : void extracted from public execute(runnable Runnable) : void in class org.apache.flink.runtime.rpc.RpcEndpoint.MainThreadExecutor | From | To | |
| Extract Method protected createTerminationFutureOverAllConnectedVertexes() : CompletableFuture<Void> extracted from private cancel(globalModVersionOfFailover long) : void in class org.apache.flink.runtime.executiongraph.failover.FailoverRegion | From | To | |
| Extract Method private assertRunningInJobMasterMainThread() : void extracted from public scheduleForExecution(slotProvider SlotProvider, queued boolean, locationPreferenceConstraint LocationPreferenceConstraint, allPreviousExecutionGraphAllocationIds Set<AllocationID>) : CompletableFuture<Void> in class org.apache.flink.runtime.executiongraph.Execution | From | To | |
| Rename Method | 7 | ||
| Rename Method public fail(cause Throwable) : void renamed to public failSync(cause Throwable) : void in class org.apache.flink.runtime.jobmaster.TestingPayload | From | To | |
| Rename Method public fail(t Throwable) : void renamed to public failSync(t Throwable) : void in class org.apache.flink.runtime.executiongraph.Execution | From | To | |
| Rename Method public fail(cause Throwable) : void renamed to public failSync(cause Throwable) : void in class org.apache.flink.runtime.jobmaster.slotpool.SingleLogicalSlotTest.CountingFailPayload | From | To | |
| Rename Method public fail(cause Throwable) : void renamed to public failSync(cause Throwable) : void in class org.apache.flink.runtime.jobmaster.slotpool.DummyPayload | From | To | |
| Rename Method public fail(cause Throwable) : void renamed to public failSync(cause Throwable) : void in class org.apache.flink.runtime.jobmaster.slotpool.SingleLogicalSlotTest.ManualTestingPayload | From | To | |
| Rename Method public testConcurrentGlobalFailAndRestarts() : void renamed to public testGlobalFailAndRestarts() : void in class org.apache.flink.runtime.executiongraph.ExecutionGraphRestartTest | From | To | |
| Rename Method public fail(cause Throwable) : void renamed to public failSync(cause Throwable) : void in class org.apache.flink.runtime.jobmaster.LogicalSlot.Payload | From | To | |
| Rename Variable | 1 | ||
| Rename Variable slot : SimpleSlot to testingLogicalSlot : TestingLogicalSlot in method public testFailExternallyDuringDeploy() : void in class org.apache.flink.runtime.executiongraph.ExecutionVertexDeploymentTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type CompletableFuture<?> to void in method private signalPayloadRelease(cause Throwable) : void in class org.apache.flink.runtime.jobmaster.slotpool.SingleLogicalSlot | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable allVertices : ArrayList<ExecutionVertex> to connectedExecutions : List<ExecutionVertex> in method protected createFailoverRegion(eg ExecutionGraph, connectedExecutions List<ExecutionVertex>) : FailoverRegion in class org.apache.flink.runtime.executiongraph.failover.RestartPipelinedRegionStrategy | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute executor : Executor to executionGraph : ExecutionGraph in class org.apache.flink.runtime.executiongraph.failover.RestartPipelinedRegionStrategy | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type executor : Executor to executionGraph : ExecutionGraph in class org.apache.flink.runtime.executiongraph.failover.RestartPipelinedRegionStrategy | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public failAsync(cause Throwable) : void extracted from private signalPayloadRelease(cause Throwable) : CompletableFuture<?> in class org.apache.flink.runtime.jobmaster.slotpool.SingleLogicalSlot & moved to class org.apache.flink.runtime.jobmaster.slotpool.DummyPayload | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter runnable : Runnable to command : Runnable in method public execute(command Runnable) : void in class org.apache.flink.runtime.rpc.RpcEndpoint.MainThreadExecutor | From | To |