85bea23ace3133e1b2d239c4ee87270a201b9b6a
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 38
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public testgetNioBufferThreadSafe() : void renamed to public testGetNioBufferThreadSafe() : void in class org.apache.flink.runtime.io.network.buffer.BufferTest | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public getArray() : byte[] from class org.apache.flink.core.memory.HybridMemorySegment to public getArray() : byte[] from class org.apache.flink.core.memory.MemorySegment | From | To | |
| Push Down Method | 10 | ||
| Push Down Method public getRecycler() : BufferRecycler from class org.apache.flink.runtime.io.network.buffer.Buffer to public getRecycler() : BufferRecycler from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Method public getMemorySegment() : MemorySegment from class org.apache.flink.runtime.io.network.buffer.Buffer to public getMemorySegment() : MemorySegment from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Method public setSize(newSize int) : void from class org.apache.flink.runtime.io.network.buffer.Buffer to public setSize(writerIndex int) : void from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Method public getSize() : int from class org.apache.flink.runtime.io.network.buffer.Buffer to public getSize() : int from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Method public toString() : String from class org.apache.flink.runtime.io.network.buffer.Buffer to public toString() : String from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Method public recycle() : void from class org.apache.flink.runtime.io.network.buffer.Buffer to public recycle() : void from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Method public isBuffer() : boolean from class org.apache.flink.runtime.io.network.buffer.Buffer to public isBuffer() : boolean from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Method public tagAsEvent() : void from class org.apache.flink.runtime.io.network.buffer.Buffer to public tagAsEvent() : void from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Method public getSizeUnsafe() : int from class org.apache.flink.runtime.io.network.buffer.Buffer to public getSizeUnsafe() : int from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Method public isRecycled() : boolean from class org.apache.flink.runtime.io.network.buffer.Buffer to public isRecycled() : boolean from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method public Buffer(memorySegment MemorySegment, recycler BufferRecycler) from class org.apache.flink.runtime.io.network.buffer.Buffer to public NetworkBuffer(memorySegment MemorySegment, recycler BufferRecycler) from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public createBuffer() : Buffer moved from class org.apache.flink.runtime.io.network.util.TestBufferFactory to class org.apache.flink.runtime.io.network.partition.SubpartitionTestBase & inlined to private verifyViewReleasedAfterParentRelease(partition ResultSubpartition) : void | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.apache.flink.runtime.io.network.buffer.NetworkBuffer from class org.apache.flink.runtime.io.network.buffer.Buffer | From | To | |
| Push Down Attribute | 4 | ||
| Push Down Attribute private isBuffer : boolean from class org.apache.flink.runtime.io.network.buffer.Buffer to private isBuffer : boolean from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Attribute private recycler : BufferRecycler from class org.apache.flink.runtime.io.network.buffer.Buffer to private recycler : BufferRecycler from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Attribute private memorySegment : MemorySegment from class org.apache.flink.runtime.io.network.buffer.Buffer to private memorySegment : MemorySegment from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Push Down Attribute private currentSize : int from class org.apache.flink.runtime.io.network.buffer.Buffer to private currentSize : int from class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.flink.runtime.io.network.buffer.AbstractByteBufTest from classes [org.apache.flink.runtime.io.network.buffer.BufferTest] | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type buffer : Buffer to buffer : NetworkBuffer in method private decodeBufferOrEvent(inputChannel RemoteInputChannel, bufferOrEvent NettyMessage.BufferResponse, isStagedBuffer boolean) : boolean in class org.apache.flink.runtime.io.network.netty.PartitionRequestClientHandler | From | To | |
| Change Variable Type buffer : Buffer to buffer : NetworkBuffer in method public run() : void in class org.apache.flink.runtime.io.network.netty.PartitionRequestClientHandler.BufferListenerTask | From | To | |
| Change Variable Type buffer : Buffer to buffer : NetworkBuffer in method private decodeBufferOrEvent(inputChannel RemoteInputChannel, bufferOrEvent NettyMessage.BufferResponse) : void in class org.apache.flink.runtime.io.network.netty.CreditBasedClientHandler | From | To | |
| Extract Variable | 4 | ||
| Extract Variable buffer1 : NetworkBuffer in method public testWriteRead() : void from class org.apache.flink.runtime.io.disk.iomanager.BufferFileWriterFileSegmentReaderTest | From | To | |
| Extract Variable buffer : Buffer in method public getNextBuffer() : BufferAndBacklog from class org.apache.flink.runtime.io.network.netty.CancelPartitionRequestTest.InfiniteSubpartitionView | From | To | |
| Extract Variable size : int in method private decodeBufferOrEvent(inputChannel RemoteInputChannel, bufferOrEvent NettyMessage.BufferResponse) : void from class org.apache.flink.runtime.io.network.netty.CreditBasedClientHandler | From | To | |
| Extract Variable receivedSize : int in method private decodeBufferOrEvent(inputChannel RemoteInputChannel, bufferOrEvent NettyMessage.BufferResponse, isStagedBuffer boolean) : boolean from class org.apache.flink.runtime.io.network.netty.PartitionRequestClientHandler | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type availableBuffer : AtomicReference<Buffer> to availableBuffer : AtomicReference<NetworkBuffer> in class org.apache.flink.runtime.io.network.netty.PartitionRequestClientHandler.BufferListenerTask | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter bufferSize : int to dataSize : int in method public createBuffer(dataSize int) : Buffer in class org.apache.flink.runtime.io.network.util.TestBufferFactory | From | To | |
| Rename Parameter newSize : int to writerIndex : int in method public setSize(writerIndex int) : void in class org.apache.flink.runtime.io.network.buffer.NetworkBuffer | From | To | |
| Rename Parameter newSize : int to writerIndex : int in method public setSize(writerIndex int) : void in class org.apache.flink.runtime.io.network.buffer.Buffer | From | To |