flink 8cdf2ff7e5817acc0c239ce31c098daf33d326b7

8cdf2ff7e5817acc0c239ce31c098daf33d326b7

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 4

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private assertExactlyOnceForDirectory(targetDirectory File, expectedValues List<String>) : void renamed to private assertExactlyOnce(expectedValues List<String>) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Move And Rename Method	2
Move And Rename Method public open() : void from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest.TestContext to private setUpTestHarness() : void from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Move And Rename Method public close() : void from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest.TestContext to private closeTestHarness() : void from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Change Parameter Type	4
Change Parameter Type pendingTransaction : TXN to pendingTransaction : TransactionHolder<TXN> in method public State(pendingTransaction TransactionHolder<TXN>, pendingCommitTransactions List<TransactionHolder<TXN>>, context Optional<CONTEXT>) in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.State	From	To
Change Parameter Type pendingTransaction : TXN to pendingTransaction : TransactionHolder<TXN> in method public setPendingTransaction(pendingTransaction TransactionHolder<TXN>) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.State	From	To
Change Parameter Type pendingCommitTransactions : List<TXN> to pendingCommitTransactions : List<TransactionHolder<TXN>> in method public State(pendingTransaction TransactionHolder<TXN>, pendingCommitTransactions List<TransactionHolder<TXN>>, context Optional<CONTEXT>) in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.State	From	To
Change Parameter Type pendingCommitTransactions : List<TXN> to pendingCommitTransactions : List<TransactionHolder<TXN>> in method public setPendingCommitTransactions(pendingCommitTransactions List<TransactionHolder<TXN>>) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.State	From	To
Rename Variable	2
Rename Variable pendingTxn : TXN to pendingTxnHandle : TXN in method public copy(source DataInputView, target DataOutputView) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.StateSerializer	From	To
Rename Variable pendingCommitTxn : TXN to pendingCommitTxnHandle : TXN in method public copy(source DataInputView, target DataOutputView) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.StateSerializer	From	To
Change Return Type	2
Change Return Type List<TXN> to List<TransactionHolder<TXN>> in method public getPendingCommitTransactions() : List<TransactionHolder<TXN>> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.State	From	To
Change Return Type TXN to TransactionHolder<TXN> in method public getPendingTransaction() : TransactionHolder<TXN> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.State	From	To
Move Attribute	6
Move Attribute public harness : OneInputStreamOperatorTestHarness<String,Object> from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest.TestContext to private harness : OneInputStreamOperatorTestHarness<String,Object> from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Move Attribute public tmpDirectory : File from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest.TestContext to private tmpDirectory : File from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Move Attribute private targetDirectory : File from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest.FileBasedSinkFunction to private targetDirectory : File from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Move Attribute private tmpDirectory : File from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest.FileBasedSinkFunction to private tmpDirectory : File from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Move Attribute public targetDirectory : File from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest.TestContext to private targetDirectory : File from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Move Attribute public sinkFunction : FileBasedSinkFunction from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest.TestContext to private sinkFunction : FileBasedSinkFunction from class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Rename Attribute	2
Rename Attribute context : TestContext to harness : OneInputStreamOperatorTestHarness<String,Object> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Rename Attribute currentTransaction : TXN to currentTransactionHolder : TransactionHolder<TXN> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction	From	To
Change Variable Type	8
Change Variable Type pendingCommitTxns : List<TXN> to pendingCommitTxns : List<TransactionHolder<TXN>> in method public deserialize(source DataInputView) : State<TXN,CONTEXT> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.StateSerializer	From	To
Change Variable Type pendingTransaction : TXN to pendingTransaction : TransactionHolder<TXN> in method public notifyCheckpointComplete(checkpointId long) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction	From	To
Change Variable Type pendingCommitTransactions : List<TXN> to pendingCommitTransactions : List<TransactionHolder<TXN>> in method public serialize(record State<TXN,CONTEXT>, target DataOutputView) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.StateSerializer	From	To
Change Variable Type entry : Map.Entry<Long,TXN> to entry : Map.Entry<Long,TransactionHolder<TXN>> in method public notifyCheckpointComplete(checkpointId long) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction	From	To
Change Variable Type recoveredTransactions : List<TXN> to recoveredTransactions : List<TransactionHolder<TXN>> in method public initializeState(context FunctionInitializationContext) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction	From	To
Change Variable Type copiedPendingCommitTransactions : List<TXN> to copiedPendingCommitTransactions : List<TransactionHolder<TXN>> in method public copy(from State<TXN,CONTEXT>) : State<TXN,CONTEXT> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.StateSerializer	From	To
Change Variable Type pendingTransactionIterator : Iterator<Map.Entry<Long,TXN>> to pendingTransactionIterator : Iterator<Map.Entry<Long,TransactionHolder<TXN>>> in method public notifyCheckpointComplete(checkpointId long) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction	From	To
Change Variable Type recoveredTransaction : TXN to recoveredTransaction : TransactionHolder<TXN> in method public initializeState(context FunctionInitializationContext) : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction	From	To
Extract Method	2
Extract Method private closeTestHarness() : void extracted from public tearDown() : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Extract Method private closeTestHarness() : void extracted from public testFailBeforeNotify() : void in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Change Attribute Type	5
Change Attribute Type currentTransaction : TXN to currentTransactionHolder : TransactionHolder<TXN> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction	From	To
Change Attribute Type pendingTransaction : TXN to pendingTransaction : TransactionHolder<TXN> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.State	From	To
Change Attribute Type context : TestContext to harness : OneInputStreamOperatorTestHarness<String,Object> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunctionTest	From	To
Change Attribute Type pendingCommitTransactions : LinkedHashMap<Long,TXN> to pendingCommitTransactions : LinkedHashMap<Long,TransactionHolder<TXN>> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction	From	To
Change Attribute Type pendingCommitTransactions : List<TXN> to pendingCommitTransactions : List<TransactionHolder<TXN>> in class org.apache.flink.streaming.api.functions.sink.TwoPhaseCommitSinkFunction.State	From	To

8cdf2ff7e5817acc0c239ce31c098daf33d326b7

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: