98a01630b531185cedb5696669afa993eddd2b07
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public testRegisterJobMasterFromInvalidAddress() : void renamed to public testRegisterTaskExecutorFromInvalidAddress() : void in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Rename Method private mockJobMaster(jobMasterAddress String) : JobID renamed to private mockTaskExecutor(taskExecutorAddress String) : ResourceID in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Rename Method public testRegisterJobMasterWithUnmatchedLeaderSessionId() : void renamed to public testRegisterTaskExecutorWithUnmatchedLeaderSessionId() : void in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Move Method | 3 | ||
| Move Method public grantLeadership(leaderSessionID UUID) : void from class org.apache.flink.runtime.resourcemanager.ResourceManager to public grantLeadership(leaderSessionID UUID) : void from class org.apache.flink.runtime.resourcemanager.ResourceManager.ResourceManagerLeaderContender | From | To | |
| Move Method public handleError(exception Exception) : void from class org.apache.flink.runtime.resourcemanager.ResourceManager to public handleError(exception Exception) : void from class org.apache.flink.runtime.resourcemanager.ResourceManager.ResourceManagerLeaderContender | From | To | |
| Move Method public revokeLeadership() : void from class org.apache.flink.runtime.resourcemanager.ResourceManager to public revokeLeadership() : void from class org.apache.flink.runtime.resourcemanager.ResourceManager.ResourceManagerLeaderContender | From | To | |
| Rename Variable | 7 | ||
| Rename Variable resourceManagerLeaderElectionService : TestingLeaderElectionService to leaderElectionService : TestingLeaderElectionService in method public testRegisterTaskExecutorFromInvalidAddress() : void in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Rename Variable jobMasterAddress : String to taskExecutorAddress : String in method public testRegisterTaskExecutorWithUnmatchedLeaderSessionId() : void in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Rename Variable jobID : JobID to taskExecutorResourceID : ResourceID in method public testRegisterTaskExecutorWithUnmatchedLeaderSessionId() : void in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Rename Variable jobID : JobID to taskExecutorResourceID : ResourceID in method public testRegisterTaskExecutorFromInvalidAddress() : void in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Rename Variable resourceManagerLeaderElectionService : TestingLeaderElectionService to leaderElectionService : TestingLeaderElectionService in method public testRegisterTaskExecutorWithUnmatchedLeaderSessionId() : void in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Rename Variable jobMasterGateway : JobMasterGateway to taskExecutorGateway : TaskExecutorGateway in method private mockTaskExecutor(taskExecutorAddress String) : ResourceID in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Rename Variable jobMasterAddress : String to taskExecutorAddress : String in method public testRegisterTaskExecutorFromInvalidAddress() : void in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Change Return Type | 4 | ||
| Change Return Type JobID to ResourceID in method private mockTaskExecutor(taskExecutorAddress String) : ResourceID in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Change Return Type SlotRequestReply to SlotAssignment in method public requestSlot(slotRequest SlotRequest) : SlotAssignment in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Change Return Type Future<SlotRequestReply> to Future<SlotAssignment> in method public requestSlot(slotRequest SlotRequest) : Future<SlotAssignment> in class org.apache.flink.runtime.resourcemanager.ResourceManagerGateway | From | To | |
| Change Return Type RegistrationResponse to Future<RegistrationResponse> in method public registerTaskExecutor(resourceManagerLeaderId UUID, taskExecutorAddress String, resourceID ResourceID) : Future<RegistrationResponse> in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.flink.runtime.resourcemanager.ResourceManager.ResourceManagerLeaderContender from class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type jobMasterGateway : JobMasterGateway to taskExecutorGateway : TaskExecutorGateway in method private mockTaskExecutor(taskExecutorAddress String) : ResourceID in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Change Variable Type jobID : JobID to taskExecutorResourceID : ResourceID in method public testRegisterTaskExecutorWithUnmatchedLeaderSessionId() : void in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Change Variable Type jobID : JobID to taskExecutorResourceID : ResourceID in method public testRegisterTaskExecutorFromInvalidAddress() : void in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type jobMasterGateways : Map<JobID,JobMasterGateway> to jobMasterGateways : Map<JobMasterGateway,InstanceID> in class org.apache.flink.runtime.resourcemanager.ResourceManager | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter jobMasterAddress : String to taskExecutorAddress : String in method private mockTaskExecutor(taskExecutorAddress String) : ResourceID in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Rename Parameter resourceManagerLeaderElectionService : TestingLeaderElectionService to leaderElectionService : TestingLeaderElectionService in method private createAndStartResourceManager(leaderElectionService TestingLeaderElectionService) : ResourceManager in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To | |
| Rename Parameter resourceManagerLeaderElectionService : TestingLeaderElectionService to leaderElectionService : TestingLeaderElectionService in method private grantResourceManagerLeadership(leaderElectionService TestingLeaderElectionService) : UUID in class org.apache.flink.runtime.resourcemanager.ResourceManagerTest | From | To |