a1ba9f1126270d53168394211a99e354aa2cf20d
Files Diff
- Added: 4
- Removed: 2
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public setJobManagerLeaderId(jobManagerLeaderId UUID) : void renamed to public connectToResourceManager(resourceManagerLeaderId UUID, resourceManagerGateway ResourceManagerGateway) : void in class org.apache.flink.runtime.instance.SlotPool | From | To | |
| Rename Method package containResource(resourceID ResourceID) : boolean renamed to package containsTaskManager(resourceID ResourceID) : boolean in class org.apache.flink.runtime.instance.SlotPool.AvailableSlots | From | To | |
| Rename Method public releaseResource(resourceID ResourceID) : void renamed to public releaseTaskManager(resourceID ResourceID) : void in class org.apache.flink.runtime.instance.SlotPool | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type slot : Slot to slotAllocationId : AllocationID in method package contains(slotAllocationId AllocationID) : boolean in class org.apache.flink.runtime.instance.SlotPool.AllocatedSlots | From | To | |
| Change Parameter Type descriptor : SlotDescriptor to slot : AllocatedSlot in method package add(slot AllocatedSlot, timestamp long) : void in class org.apache.flink.runtime.instance.SlotPool.AvailableSlots | From | To | |
| Change Parameter Type slotDescriptor : SlotDescriptor to slotId : AllocationID in method package contains(slotId AllocationID) : boolean in class org.apache.flink.runtime.instance.SlotPool.AvailableSlots | From | To | |
| Rename Variable | 5 | ||
| Rename Variable e : Exception to t : Throwable in method public suspendExecution(cause Throwable) : void in class org.apache.flink.runtime.jobmaster.JobMaster | From | To | |
| Rename Variable slotsForResource : Set<Slot> to slotsForTM : Set<Slot> in method package remove(slotId AllocationID) : Slot in class org.apache.flink.runtime.instance.SlotPool.AllocatedSlots | From | To | |
| Rename Variable resourceID : ResourceID to taskManagerId : ResourceID in method package remove(slotId AllocationID) : Slot in class org.apache.flink.runtime.instance.SlotPool.AllocatedSlots | From | To | |
| Rename Variable slotsForResource : Set<Slot> to slotsForTaskManager : Set<Slot> in method package add(slot Slot) : void in class org.apache.flink.runtime.instance.SlotPool.AllocatedSlots | From | To | |
| Rename Variable slotsForResource : Set<SlotDescriptor> to slotsForTaskManager : Set<AllocatedSlot> in method package add(slot AllocatedSlot, timestamp long) : void in class org.apache.flink.runtime.instance.SlotPool.AvailableSlots | From | To | |
| Change Return Type | 3 | ||
| Change Return Type SlotDescriptor to boolean in method package remove(slot Slot) : boolean in class org.apache.flink.runtime.instance.SlotPool.AllocatedSlots | From | To | |
| Change Return Type Iterable<SlotOffer> to Future<Iterable<SlotOffer>> in method public offerSlots(taskManagerId ResourceID, slots Iterable<SlotOffer>, leaderId UUID) : Future<Iterable<SlotOffer>> in class org.apache.flink.runtime.jobmaster.JobMaster | From | To | |
| Change Return Type boolean to void in method public returnAllocatedSlot(slot Slot) : void in class org.apache.flink.runtime.instance.SlotPool | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private timeout : Time from class org.apache.flink.runtime.instance.SlotPool to private timeout : Time from class org.apache.flink.runtime.instance.SlotPool.ProviderAndOwner | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.flink.runtime.instance.SlotPool.ProviderAndOwner from class org.apache.flink.runtime.instance.SlotPool | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute allocatedSlotsByResource : Map<ResourceID,Set<Slot>> to allocatedSlotsByTaskManager : Map<ResourceID,Set<Slot>> in class org.apache.flink.runtime.instance.SlotPool.AllocatedSlots | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type e : Exception to t : Throwable in method public suspendExecution(cause Throwable) : void in class org.apache.flink.runtime.jobmaster.JobMaster | From | To | |
| Change Variable Type pendingRequest : Tuple2<SlotRequest,FlinkCompletableFuture<SlotDescriptor>> to pendingRequest : PendingRequest in method public failAllocation(allocationID AllocationID, cause Exception) : void in class org.apache.flink.runtime.instance.SlotPool | From | To | |
| Change Variable Type c : Class to c : Class<?> in method private determineSelfGatewayType() : Class<C> in class org.apache.flink.runtime.rpc.RpcEndpoint | From | To | |
| Change Variable Type slotsForResource : Set<SlotDescriptor> to slotsForTaskManager : Set<AllocatedSlot> in method package add(slot AllocatedSlot, timestamp long) : void in class org.apache.flink.runtime.instance.SlotPool.AvailableSlots | From | To | |
| Extract Method | 2 | ||
| Extract Method private internalReturnAllocatedSlot(slot Slot) : void extracted from public returnAllocatedSlot(slot Slot) : boolean in class org.apache.flink.runtime.instance.SlotPool | From | To | |
| Extract Method package remove(slotId AllocationID) : Slot extracted from package remove(slot Slot) : SlotDescriptor in class org.apache.flink.runtime.instance.SlotPool.AllocatedSlots | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type availableSlots : Set<SlotDescriptor> to availableSlots : HashMap<AllocationID,SlotAndTimestamp> in class org.apache.flink.runtime.instance.SlotPool.AvailableSlots | From | To | |
| Change Attribute Type pendingRequests : Map<AllocationID,Tuple2<SlotRequest,FlinkCompletableFuture<SlotDescriptor>>> to pendingRequests : HashMap<AllocationID,PendingRequest> in class org.apache.flink.runtime.instance.SlotPool | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method private remove(slotId AllocationID) : void extracted from package remove(slot Slot) : SlotDescriptor in class org.apache.flink.runtime.instance.SlotPool.AllocatedSlots & moved to class org.apache.flink.runtime.instance.SlotPool.AvailableSlots | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter slot : Slot to slotAllocationId : AllocationID in method package contains(slotAllocationId AllocationID) : boolean in class org.apache.flink.runtime.instance.SlotPool.AllocatedSlots | From | To | |
| Rename Parameter descriptor : SlotDescriptor to slot : AllocatedSlot in method package add(slot AllocatedSlot, timestamp long) : void in class org.apache.flink.runtime.instance.SlotPool.AvailableSlots | From | To | |
| Rename Parameter slotDescriptor : SlotDescriptor to slotId : AllocationID in method package contains(slotId AllocationID) : boolean in class org.apache.flink.runtime.instance.SlotPool.AvailableSlots | From | To | |
| Rename Parameter jobManagerLeaderId : UUID to resourceManagerLeaderId : UUID in method public connectToResourceManager(resourceManagerLeaderId UUID, resourceManagerGateway ResourceManagerGateway) : void in class org.apache.flink.runtime.instance.SlotPool | From | To |