a25cd3feddd19e75456db32a704ee5509e85dd47
Files Diff
- Added: 1
- Removed: 5
- Renamed: 0
- Modified: 28
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type uploadedFiles : Collection<Path> to uploadedFiles : Collection<File> in method public HandlerRequest(requestBody R, messageParameters M, receivedPathParameters Map<String,String>, receivedQueryParameters Map<String,List<String>>, uploadedFiles Collection<File>) in class org.apache.flink.runtime.rest.handler.HandlerRequest | From | To | |
| Rename Variable | 2 | ||
| Rename Variable other : JobSubmitRequestBody to that : JobSubmitRequestBody in method public equals(o Object) : boolean in class org.apache.flink.runtime.rest.messages.job.JobSubmitRequestBody | From | To | |
| Rename Variable job : JobGraph to jobGraph : JobGraph in method public testFailedJobSubmission() : void in class org.apache.flink.runtime.rest.handler.job.JobSubmitHandlerTest | From | To | |
| Change Return Type | 6 | ||
| Change Return Type Collection<Path> to Collection<File> in method public getUploadedFiles() : Collection<File> in class org.apache.flink.runtime.rest.handler.FileUploads | From | To | |
| Change Return Type void to CompletableFuture<Void> in method protected respondToRequest(ctx ChannelHandlerContext, httpRequest HttpRequest, handlerRequest HandlerRequest<R,M>, gateway T) : CompletableFuture<Void> in class org.apache.flink.runtime.rest.handler.AbstractRestHandler | From | To | |
| Change Return Type Collection<Path> to Collection<File> in method package getContainedFiles() : Collection<File> in class org.apache.flink.runtime.rest.handler.FileUploads.FileAdderVisitor | From | To | |
| Change Return Type void to CompletableFuture<Void> in method protected abstract respondToRequest(ctx ChannelHandlerContext, httpRequest HttpRequest, handlerRequest HandlerRequest<R,M>, gateway T) : CompletableFuture<Void> in class org.apache.flink.runtime.rest.AbstractHandler | From | To | |
| Change Return Type void to CompletableFuture<Void> in method protected respondToRequest(ctx ChannelHandlerContext, httpRequest HttpRequest, handlerRequest HandlerRequest<EmptyRequestBody,M>, gateway RestfulGateway) : CompletableFuture<Void> in class org.apache.flink.runtime.rest.handler.taskmanager.AbstractTaskManagerFileHandler | From | To | |
| Change Return Type Collection<Path> to Collection<File> in method public getUploadedFiles() : Collection<File> in class org.apache.flink.runtime.rest.handler.HandlerRequest | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.flink.runtime.rest.handler.job.BlobServerPortHandlerTest.TestException moved and renamed to org.apache.flink.runtime.rest.handler.job.JobSubmitHandler.MissingFileException | From | To | |
| Split Parameter | 1 | ||
| Split Parameter jobGraph : JobGraph to [userJars : Collection<Path>, userArtifacts : Collection<Tuple2<String,org.apache.flink.core.fs.Path>>] in method public uploadJobGraphFiles(jobGraph JobGraph, userJars Collection<Path>, userArtifacts Collection<Tuple2<String,org.apache.flink.core.fs.Path>>, clientSupplier SupplierWithException<BlobClient,IOException>) : void in class org.apache.flink.runtime.client.ClientUtils | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type detectedFiles : Collection<Path> to detectedFiles : Collection<File> in method public testEmptyDirectory() : void in class org.apache.flink.runtime.rest.handler.FileUploadsTest | From | To | |
| Change Variable Type uploadedFiles : Collection<Path> to uploadedFiles : Collection<File> in method protected handleRequest(request HandlerRequest<EmptyRequestBody,EmptyMessageParameters>, gateway RestfulGateway) : CompletableFuture<JarUploadResponseBody> in class org.apache.flink.runtime.webmonitor.handlers.JarUploadHandler | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type files : Collection<Path> to files : Collection<File> in class org.apache.flink.runtime.rest.handler.FileUploads.FileAdderVisitor | From | To | |
| Change Attribute Type uploadedFiles : Collection<Path> to uploadedFiles : Collection<File> in class org.apache.flink.runtime.rest.handler.HandlerRequest | From | To | |
| Extract Method | 2 | ||
| Extract Method private sendRetriableRequest(messageHeaders M, messageParameters U, request R, filesToUpload Collection<FileUpload>, retryPredicate Predicate<Throwable>) : CompletableFuture<P> extracted from private sendRetriableRequest(messageHeaders M, messageParameters U, request R, retryPredicate Predicate<Throwable>) : CompletableFuture<P> in class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
| Extract Method private loadJobGraph(requestBody JobSubmitRequestBody, nameToFile Map<String,Path>) : CompletableFuture<JobGraph> extracted from protected handleRequest(request HandlerRequest<JobSubmitRequestBody,EmptyMessageParameters>, gateway DispatcherGateway) : CompletableFuture<JobSubmitResponseBody> in class org.apache.flink.runtime.rest.handler.job.JobSubmitHandler | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter object : Object to o : Object in method public equals(o Object) : boolean in class org.apache.flink.runtime.rest.messages.job.JobSubmitRequestBody | From | To |