a7cf24383be9f310fb5ccc5a032721421fa45791
Files Diff
- Added: 9
- Removed: 4
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public testReleaseParent() : void renamed to public testReleaseIsIdempotent() : void in class org.apache.flink.runtime.io.network.partition.SubpartitionTestBase | From | To | |
| Rename Method public testReleaseParentAfterSpilled() : void renamed to public testReleasingReaderDoesNotReleasePartition() : void in class org.apache.flink.runtime.io.network.partition.SubpartitionTestBase | From | To | |
| Push Down Method | 8 | ||
| Push Down Method protected increaseBuffersInBacklog(buffer BufferConsumer) : void from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to private increaseBuffersInBacklog(buffer BufferConsumer) : void from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Method protected getTotalNumberOfBytes() : long from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to protected getTotalNumberOfBytes() : long from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Method protected getTotalNumberOfBuffers() : long from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to protected getTotalNumberOfBuffers() : long from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Method public getBuffersInBacklog() : int from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to public getBuffersInBacklog() : int from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Method protected getFailureCause() : Throwable from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to package getFailureCause() : Throwable from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Method protected updateStatistics(buffer BufferConsumer) : void from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to private updateStatistics(buffer BufferConsumer) : void from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Method protected updateStatistics(buffer Buffer) : void from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to private updateStatistics(buffer Buffer) : void from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Method protected decreaseBuffersInBacklogUnsafe(isBuffer boolean) : int from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to private decreaseBuffersInBacklogUnsafe(isBuffer boolean) : void from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type ioManager : IOManager to memory : MemoryMappedBuffers in method package BoundedBlockingSubpartition(index int, parent ResultPartition, memory MemoryMappedBuffers) in class org.apache.flink.runtime.io.network.partition.BoundedBlockingSubpartition | From | To | |
| Inline Method | 6 | ||
| Inline Method private verifyViewReleasedAfterParentRelease(partition ResultSubpartition) : void inlined to public testReleaseIsIdempotent() : void in class org.apache.flink.runtime.io.network.partition.SubpartitionTestBase | From | To | |
| Inline Method private add(bufferConsumer BufferConsumer, forceFinishRemainingBuffers boolean) : boolean inlined to public add(bufferConsumer BufferConsumer) : boolean in class org.apache.flink.runtime.io.network.partition.BoundedBlockingSubpartition | From | To | |
| Inline Method private verifyViewReleasedAfterParentRelease(partition ResultSubpartition) : void inlined to public testReleasingReaderDoesNotReleasePartition() : void in class org.apache.flink.runtime.io.network.partition.SubpartitionTestBase | From | To | |
| Change Return Type | 1 | ||
| Change Return Type int to void in method private decreaseBuffersInBacklogUnsafe(isBuffer boolean) : void in class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Attribute | 4 | ||
| Push Down Attribute protected buffers : ArrayDeque<BufferConsumer> from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to private buffers : ArrayDeque<BufferConsumer> from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Attribute private totalNumberOfBytes : long from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to private totalNumberOfBytes : long from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Attribute private buffersInBacklog : int from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to private buffersInBacklog : int from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Push Down Attribute private totalNumberOfBuffers : long from class org.apache.flink.runtime.io.network.partition.ResultSubpartition to private totalNumberOfBuffers : long from class org.apache.flink.runtime.io.network.partition.PipelinedSubpartition | From | To | |
| Rename Class | 2 | ||
| Rename Class org.apache.flink.runtime.io.network.partition.SpillableSubpartitionView renamed to org.apache.flink.runtime.io.network.partition.BoundedBlockingSubpartitionReader | From | To | |
| Rename Class org.apache.flink.runtime.io.network.partition.SpillableSubpartition renamed to org.apache.flink.runtime.io.network.partition.BoundedBlockingSubpartition | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute ioManager : IOManager to memory : MemoryMappedBuffers in class org.apache.flink.runtime.io.network.partition.BoundedBlockingSubpartition | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type ioManager : IOManager to memory : MemoryMappedBuffers in class org.apache.flink.runtime.io.network.partition.BoundedBlockingSubpartition | From | To | |
| Change Attribute Type parent : SpillableSubpartition to parent : BoundedBlockingSubpartition in class org.apache.flink.runtime.io.network.partition.BoundedBlockingSubpartitionReader | From | To | |
| Change Attribute Type nextBuffer : BufferConsumer to nextBuffer : Buffer in class org.apache.flink.runtime.io.network.partition.BoundedBlockingSubpartitionReader | From | To | |
| Inline Variable | 1 | ||
| Inline Variable bufferConsumer : BufferConsumer in method private verifyViewReleasedAfterParentRelease(partition ResultSubpartition) : void from class org.apache.flink.runtime.io.network.partition.SubpartitionTestBase | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter ioManager : IOManager to memory : MemoryMappedBuffers in method package BoundedBlockingSubpartition(index int, parent ResultPartition, memory MemoryMappedBuffers) in class org.apache.flink.runtime.io.network.partition.BoundedBlockingSubpartition | From | To | |
| Rename Parameter availabilityListener : BufferAvailabilityListener to availability : BufferAvailabilityListener in method public createReadView(availability BufferAvailabilityListener) : ResultSubpartitionView in class org.apache.flink.runtime.io.network.partition.BoundedBlockingSubpartition | From | To |