ac8225fd56f16b1766724aefbd44babbe322d2ac
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 31
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public getRestServerPort() : int renamed to public getRetryMaxAttempts() : int in class org.apache.flink.client.program.rest.RestClusterClientConfiguration | From | To | |
| Rename Method private waitForSavepointCompletion(jobId JobID, savepointTriggerId SavepointTriggerId) : SavepointInfo renamed to private pollSavepointAsync(jobId JobID, savepointTriggerId SavepointTriggerId) : CompletableFuture<SavepointInfo> in class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type searchType : Class<?> to searchType : Class<T> in method public findThrowable(throwable Throwable, searchType Class<T>) : Optional<T> in class org.apache.flink.util.ExceptionUtils | From | To | |
| Change Parameter Type restServerPort : int to retryDelay : long in method private RestClusterClientConfiguration(endpointConfiguration RestClientConfiguration, awaitLeaderTimeout long, retryMaxAttempts int, retryDelay long) in class org.apache.flink.client.program.rest.RestClusterClientConfiguration | From | To | |
| Move Method | 3 | ||
| Move Method public sendRequest(targetAddress String, targetPort int, messageHeaders M) : CompletableFuture<P> from class org.apache.flink.runtime.rest.RestClient to private sendRequest(messageHeaders M) : CompletableFuture<P> from class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
| Move Method public sendRequest(targetAddress String, targetPort int, messageHeaders M, request R) : CompletableFuture<P> from class org.apache.flink.runtime.rest.RestClient to private sendRequest(messageHeaders M, request R) : CompletableFuture<P> from class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
| Move Method public sendRequest(targetAddress String, targetPort int, messageHeaders M, messageParameters U) : CompletableFuture<P> from class org.apache.flink.runtime.rest.RestClient to private sendRequest(messageHeaders M, messageParameters U) : CompletableFuture<P> from class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
| Rename Variable | 1 | ||
| Rename Variable serverPort : int to retryMaxAttempts : int in method public fromConfiguration(config Configuration) : RestClusterClientConfiguration in class org.apache.flink.client.program.rest.RestClusterClientConfiguration | From | To | |
| Change Return Type | 2 | ||
| Change Return Type SavepointInfo to CompletableFuture<SavepointInfo> in method private pollSavepointAsync(jobId JobID, savepointTriggerId SavepointTriggerId) : CompletableFuture<SavepointInfo> in class org.apache.flink.client.program.rest.RestClusterClient | From | To | |
| Change Return Type Optional<Throwable> to Optional<T> in method public findThrowable(throwable Throwable, searchType Class<T>) : Optional<T> in class org.apache.flink.util.ExceptionUtils | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute blobServerAddress : String to awaitLeaderTimeout : long in class org.apache.flink.client.program.rest.RestClusterClientConfiguration | From | To | |
| Rename Attribute clientEndpoint : RestClient to restClient : RestClient in class org.apache.flink.runtime.rest.RestEndpointITCase | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type optNotFound : Optional<Throwable> to optNotFound : Optional<NotFoundException> in method protected respondAsLeader(ctx ChannelHandlerContext, routed Routed, jobManagerGateway JobManagerGateway) : void in class org.apache.flink.runtime.webmonitor.RuntimeMonitorHandler | From | To | |
| Extract Method | 1 | ||
| Extract Method public retryWithDelay(operation Supplier<CompletableFuture<T>>, retries int, retryDelay Time, retryPredicate Predicate<Throwable>, scheduledExecutor ScheduledExecutor) : CompletableFuture<T> extracted from public retryWithDelay(operation Supplier<CompletableFuture<T>>, retries int, retryDelay Time, scheduledExecutor ScheduledExecutor) : CompletableFuture<T> in class org.apache.flink.runtime.concurrent.FutureUtils | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type blobServerAddress : String to awaitLeaderTimeout : long in class org.apache.flink.client.program.rest.RestClusterClientConfiguration | From | To | |
| Change Attribute Type expectedSavepointResponseBodies : Iterator<SavepointResponseBody> to expectedSavepointResponseBodies : Iterator<Object> in class org.apache.flink.client.program.rest.RestClusterClientTest.TestSavepointHandlers.TestSavepointHandler | From | To | |
| Change Attribute Type jobExecutionResults : Iterator<JobExecutionResultResponseBody> to jobExecutionResults : Iterator<Object> in class org.apache.flink.client.program.rest.RestClusterClientTest.TestJobExecutionResultHandler | From | To | |
| Change Attribute Type lastJobExecutionResult : JobExecutionResultResponseBody to lastJobExecutionResult : Object in class org.apache.flink.client.program.rest.RestClusterClientTest.TestJobExecutionResultHandler | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter restServerPort : int to retryDelay : long in method private RestClusterClientConfiguration(endpointConfiguration RestClientConfiguration, awaitLeaderTimeout long, retryMaxAttempts int, retryDelay long) in class org.apache.flink.client.program.rest.RestClusterClientConfiguration | From | To | |
| Rename Parameter restServerPort : int to retryMaxAttempts : int in method private RestClusterClientConfiguration(endpointConfiguration RestClientConfiguration, awaitLeaderTimeout long, retryMaxAttempts int, retryDelay long) in class org.apache.flink.client.program.rest.RestClusterClientConfiguration | From | To |