ae8cef3de2f790c4de834982751f4fc49359ee05
Files Diff
- Added: 4
- Removed: 1
- Renamed: 0
- Modified: 10
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type messageHeaders : MessageHeaders<FileUpload,JarUploadResponseBody,EmptyMessageParameters> to messageHeaders : MessageHeaders<EmptyRequestBody,JarUploadResponseBody,EmptyMessageParameters> in method public JarUploadHandler(localRestAddress CompletableFuture<String>, leaderRetriever GatewayRetriever<? extends RestfulGateway>, timeout Time, responseHeaders Map<String,String>, messageHeaders MessageHeaders<EmptyRequestBody,JarUploadResponseBody,EmptyMessageParameters>, jarDir Path, executor Executor) in class org.apache.flink.runtime.webmonitor.handlers.JarUploadHandler | From | To | |
| Change Parameter Type request : HandlerRequest<FileUpload,EmptyMessageParameters> to request : HandlerRequest<EmptyRequestBody,EmptyMessageParameters> in method protected handleRequest(request HandlerRequest<EmptyRequestBody,EmptyMessageParameters>, gateway RestfulGateway) : CompletableFuture<JarUploadResponseBody> in class org.apache.flink.runtime.webmonitor.handlers.JarUploadHandler | From | To | |
| Rename Variable | 1 | ||
| Rename Variable lastUploadedPath : Path to lastUploadedFileContents : byte[] in method public testFileUpload() : void in class org.apache.flink.runtime.rest.RestServerEndpointITCase | From | To | |
| Change Return Type | 3 | ||
| Change Return Type Class<FileUpload> to Class<EmptyRequestBody> in method public getRequestClass() : Class<EmptyRequestBody> in class org.apache.flink.runtime.webmonitor.handlers.JarUploadHeaders | From | To | |
| Change Return Type Class<FileUpload> to Class<EmptyRequestBody> in method public getRequestClass() : Class<EmptyRequestBody> in class org.apache.flink.runtime.rest.RestServerEndpointITCase.TestUploadHeaders | From | To | |
| Change Return Type HandlerRequest<FileUpload,EmptyMessageParameters> to HandlerRequest<EmptyRequestBody,EmptyMessageParameters> in method private createRequest(uploadedFile Path) : HandlerRequest<EmptyRequestBody,EmptyMessageParameters> in class org.apache.flink.runtime.webmonitor.handlers.JarUploadHandlerTest | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type request : HandlerRequest<FileUpload,EmptyMessageParameters> to request : HandlerRequest<EmptyRequestBody,EmptyMessageParameters> in method public testRejectNonJarFiles() : void in class org.apache.flink.runtime.webmonitor.handlers.JarUploadHandlerTest | From | To | |
| Change Variable Type lastUploadedPath : Path to lastUploadedFileContents : byte[] in method public testFileUpload() : void in class org.apache.flink.runtime.rest.RestServerEndpointITCase | From | To | |
| Change Variable Type request : HandlerRequest<FileUpload,EmptyMessageParameters> to request : HandlerRequest<EmptyRequestBody,EmptyMessageParameters> in method public testFailedUpload() : void in class org.apache.flink.runtime.webmonitor.handlers.JarUploadHandlerTest | From | To | |
| Change Variable Type request : HandlerRequest<FileUpload,EmptyMessageParameters> to request : HandlerRequest<EmptyRequestBody,EmptyMessageParameters> in method public testUploadJar() : void in class org.apache.flink.runtime.webmonitor.handlers.JarUploadHandlerTest | From | To | |
| Extract Method | 1 | ||
| Extract Method private processRestHandlerException(ctx ChannelHandlerContext, httpRequest HttpRequest, rhe RestHandlerException) : void extracted from protected respondToRequest(ctx ChannelHandlerContext, httpRequest HttpRequest, handlerRequest HandlerRequest<R,M>, gateway T) : void in class org.apache.flink.runtime.rest.handler.AbstractRestHandler | From | To |