c64860677fb576f00c700a62a4ebb4ed415bebda
Files Diff
- Added: 3
- Removed: 2
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type ignored : JobID to leaderSessionID : UUID in method public requestPartitionState(leaderSessionID UUID, intermediateResultId IntermediateDataSetID, resultPartitionId ResultPartitionID) : ExecutionState in class org.apache.flink.runtime.jobmaster.JobMaster | From | To | |
| Rename Variable | 2 | ||
| Rename Variable onJobCompletion : BlockingJobSync to sync : BlockingJobSync in method public runJobBlocking(job JobGraph) : JobExecutionResult in class org.apache.flink.runtime.jobmaster.MiniClusterJobDispatcher | From | To | |
| Rename Variable onJobCompletion : OnCompletionActions to finalizer : DetachedFinalizer in method public runDetached(job JobGraph) : void in class org.apache.flink.runtime.jobmaster.MiniClusterJobDispatcher | From | To | |
| Inline Method | 1 | ||
| Inline Method public shutdown(cause Throwable) : void inlined to public shutdown() : void in class org.apache.flink.runtime.jobmaster.JobManagerRunner | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private submittedJobGraphStore : SubmittedJobGraphStore from class org.apache.flink.runtime.jobmaster.JobManagerRunner to private submittedJobGraphStore : SubmittedJobGraphStore from class org.apache.flink.runtime.jobmaster.JobManagerRunnerMockTest | From | To | |
| Move Attribute public jobManagerMetricGroup : JobManagerMetricGroup from class org.apache.flink.runtime.jobmaster.JobManagerServices to private jobManagerMetricGroup : JobManagerMetricGroup from class org.apache.flink.runtime.jobmaster.JobManagerRunner | From | To | |
| Replace Variable With Attribute | 2 | ||
| Replace Variable With Attribute jobId : JobID to jobMasterLeaderId : UUID in method public requestPartitionProducerState(jobId JobID, resultId IntermediateDataSetID, partitionId ResultPartitionID) : Future<ExecutionState> in class org.apache.flink.runtime.taskexecutor.rpc.RpcPartitionStateChecker | From | To | |
| Replace Variable With Attribute fs : FileSystem to fileSystem : FileSystem in method private delete(blobPath String) : void in class org.apache.flink.runtime.blob.FileSystemBlobStore | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute timeout : Time to rpcAskTimeout : Time in class org.apache.flink.runtime.jobmaster.JobManagerServices | From | To | |
| Rename Attribute DEFAULT_RESOURCE_MANAGER_PATH_SUFFIX : String to RESOURCE_MANAGER_LEADER_PATH : String in class org.apache.flink.runtime.highavailability.ZookeeperHaServices | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type jobId : JobID to jobMasterLeaderId : UUID in method public requestPartitionProducerState(jobId JobID, resultId IntermediateDataSetID, partitionId ResultPartitionID) : Future<ExecutionState> in class org.apache.flink.runtime.taskexecutor.rpc.RpcPartitionStateChecker | From | To | |
| Change Variable Type onJobCompletion : OnCompletionActions to finalizer : DetachedFinalizer in method public runDetached(job JobGraph) : void in class org.apache.flink.runtime.jobmaster.MiniClusterJobDispatcher | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type executionContext : Executor to executionContext : ExecutorService in class org.apache.flink.runtime.jobmaster.JobMaster | From | To | |
| Change Attribute Type jobManagerMetricGroup : JobManagerMetricGroup to jobManagerMetricGroup : MetricGroup in class org.apache.flink.runtime.jobmaster.JobMaster | From | To | |
| Extract Method | 1 | ||
| Extract Method private createBlobStoreFromConfig(config Configuration) : BlobStore extracted from public BlobServer(config Configuration) in class org.apache.flink.runtime.blob.BlobServer | From | To | |
| Rename Parameter | 7 | ||
| Rename Parameter timeout : Time to rpcAskTimeout : Time in method public JobManagerServices(executorService ExecutorService, libraryCacheManager BlobLibraryCacheManager, restartStrategyFactory RestartStrategyFactory, rpcAskTimeout Time) in class org.apache.flink.runtime.jobmaster.JobManagerServices | From | To | |
| Rename Parameter checkpointId : long to checkpointID : long in method public declineCheckpoint(jobID JobID, executionAttemptID ExecutionAttemptID, checkpointID long, reason Throwable) : void in class org.apache.flink.runtime.jobmaster.JobMaster | From | To | |
| Rename Parameter cause : Throwable to reason : Throwable in method public declineCheckpoint(jobID JobID, executionAttemptID ExecutionAttemptID, checkpointID long, reason Throwable) : void in class org.apache.flink.runtime.jobmaster.JobMaster | From | To | |
| Rename Parameter toNotify : OnCompletionActions to toNotifyOnComplete : OnCompletionActions in method public JobManagerRunner(jobGraph JobGraph, configuration Configuration, rpcService RpcService, haServices HighAvailabilityServices, metricRegistry MetricRegistry, toNotifyOnComplete OnCompletionActions, errorHandler FatalErrorHandler) in class org.apache.flink.runtime.jobmaster.JobManagerRunner | From | To | |
| Rename Parameter checkpointStateHandles : SubtaskState to checkpointState : SubtaskState in method public acknowledgeCheckpoint(jobID JobID, executionAttemptID ExecutionAttemptID, checkpointInfo CheckpointMetaData, checkpointState SubtaskState) : void in class org.apache.flink.runtime.jobmaster.JobMaster | From | To | |
| Rename Parameter ignored : JobID to leaderSessionID : UUID in method public requestPartitionState(leaderSessionID UUID, intermediateResultId IntermediateDataSetID, resultPartitionId ResultPartitionID) : ExecutionState in class org.apache.flink.runtime.jobmaster.JobMaster | From | To | |
| Rename Parameter timeout : Time to rpcAskTimeout : Time in method public JobMaster(jobGraph JobGraph, configuration Configuration, rpcService RpcService, highAvailabilityService HighAvailabilityServices, executorService ExecutorService, libraryCacheManager BlobLibraryCacheManager, restartStrategyFactory RestartStrategyFactory, rpcAskTimeout Time, jobManagerMetricGroup JobManagerMetricGroup, jobCompletionActions OnCompletionActions, errorHandler FatalErrorHandler, userCodeLoader ClassLoader) in class org.apache.flink.runtime.jobmaster.JobMaster | From | To |