c9e392b53b48c8ae0b189905a9b4cf878bf741e4
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 24
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method package cancelingComplete(userAccumulators Map<String,Accumulator<?,?>>, metrics IOMetrics) : void renamed to package completeCancelling(userAccumulators Map<String,Accumulator<?,?>>, metrics IOMetrics) : void in class org.apache.flink.runtime.executiongraph.Execution | From | To | |
Rename Variable | 2 | ||
Rename Variable testingResourceManagerGateway : TestingResourceManagerGateway to allocationIdsResourceManagerGateway : AllocationIdsResourceManagerGateway in method private registerSlotsAtJobMaster(numberSlots int, jobMasterGateway JobMasterGateway, taskExecutorGateway TaskExecutorGateway, taskManagerLocation TaskManagerLocation) : Collection<SlotOffer> in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
Inline Method | 1 | ||
Inline Method private offerSingleSlot(jobMasterGateway JobMasterGateway, taskManagerLocation LocalTaskManagerLocation) : void inlined to private runJobFailureWhenTaskExecutorTerminatesTest(heartbeatServices HeartbeatServices, jobReachedRunningState BiConsumer<LocalTaskManagerLocation,JobMasterGateway>, heartbeatConsumerFunction BiFunction<JobMasterGateway,ResourceID,Consumer<ResourceID>>) : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
Parameterize Variable | 2 | ||
Parameterize Variable testingTaskExecutorGateway : TestingTaskExecutorGateway to taskExecutorGateway : TaskExecutorGateway in method private registerSlotsAtJobMaster(numberSlots int, jobMasterGateway JobMasterGateway, taskExecutorGateway TaskExecutorGateway, taskManagerLocation TaskManagerLocation) : Collection<SlotOffer> in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
Replace Variable With Attribute | 1 | ||
Replace Variable With Attribute current : ExecutionState to state : ExecutionState in method private startCancelling(numberCancelRetries int) : boolean in class org.apache.flink.runtime.executiongraph.Execution | From | To | |
Change Variable Type | 4 | ||
Change Variable Type testingResourceManagerGateway : TestingResourceManagerGateway to allocationIdsResourceManagerGateway : AllocationIdsResourceManagerGateway in method private registerSlotsAtJobMaster(numberSlots int, jobMasterGateway JobMasterGateway, taskExecutorGateway TaskExecutorGateway, taskManagerLocation TaskManagerLocation) : Collection<SlotOffer> in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
Change Variable Type testingTaskExecutorGateway : TestingTaskExecutorGateway to taskExecutorGateway : TaskExecutorGateway in method private registerSlotsAtJobMaster(numberSlots int, jobMasterGateway JobMasterGateway, taskExecutorGateway TaskExecutorGateway, taskManagerLocation TaskManagerLocation) : Collection<SlotOffer> in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
Inline Variable | 2 | ||
Inline Variable ongoingSchedulingFuture : CompletableFuture<Void> in method public suspend(suspensionCause Throwable) : void from class org.apache.flink.runtime.executiongraph.ExecutionGraph | From | To | |
Inline Variable currentState : JobStatus in method public suspend(suspensionCause Throwable) : void from class org.apache.flink.runtime.executiongraph.ExecutionGraph | From | To | |
Extract Method | 6 | ||
Extract Method private startCancelling(numberCancelRetries int) : boolean extracted from public cancel() : void in class org.apache.flink.runtime.executiongraph.Execution | From | To | |
Extract Method private mapExecutionVertices(mapFunction Function<ExecutionVertex,CompletableFuture<?>>) : Collection<CompletableFuture<?>> extracted from public cancelWithFuture() : CompletableFuture<Void> in class org.apache.flink.runtime.executiongraph.ExecutionJobVertex | From | To | |
Extract Method private registerSlotsAtJobMaster(numberSlots int, jobMasterGateway JobMasterGateway, taskExecutorGateway TaskExecutorGateway) : Collection<SlotOffer> extracted from public testRequestPartitionState() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
Extract Method private registerSlotsAtJobMaster(numberSlots int, jobMasterGateway JobMasterGateway, taskExecutorGateway TaskExecutorGateway, taskManagerLocation TaskManagerLocation) : Collection<SlotOffer> extracted from private runJobFailureWhenTaskExecutorTerminatesTest(heartbeatServices HeartbeatServices, jobReachedRunningState BiConsumer<LocalTaskManagerLocation,JobMasterGateway>, heartbeatConsumerFunction BiFunction<JobMasterGateway,ResourceID,Consumer<ResourceID>>) : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
Extract Method private registerSlotsAtJobMaster(numberSlots int, jobMasterGateway JobMasterGateway, taskExecutorGateway TaskExecutorGateway) : Collection<SlotOffer> extracted from public testReleasingTaskExecutorIfNoMoreSlotsRegistered() : void in class org.apache.flink.runtime.jobmaster.JobMasterTest | From | To | |
Extract Method private finishCancellation() : void extracted from package cancelingComplete(userAccumulators Map<String,Accumulator<?,?>>, metrics IOMetrics) : void in class org.apache.flink.runtime.executiongraph.Execution | From | To |