cfce493feb70a49d2722dc2a0d79f845f7e0461a
Files Diff
- Added: 8
- Removed: 2
- Renamed: 0
- Modified: 12
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 2 | ||
Change Parameter Type buf : byte[] to blobKey : BlobKey in method private sendGetHeader(outputStream OutputStream, jobID JobID, key String, blobKey BlobKey) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
Change Parameter Type key : String to jobID : JobID in method private sendPutHeader(outputStream OutputStream, jobID JobID, key String) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
Move Method | 3 | ||
Move Method package readLength(buf byte[], inputStream InputStream) : int from class org.apache.flink.runtime.blob.BlobServer to package readLength(inputStream InputStream) : int from class org.apache.flink.runtime.blob.BlobUtils | From | To | |
Move Method package readFully(inputStream InputStream, buf byte[], off int, len int) : void from class org.apache.flink.runtime.blob.BlobServer to package readFully(inputStream InputStream, buf byte[], off int, len int, type String) : void from class org.apache.flink.runtime.blob.BlobUtils | From | To | |
Move Method package writeLength(length int, buf byte[], outputStream OutputStream) : void from class org.apache.flink.runtime.blob.BlobServer to package writeLength(length int, outputStream OutputStream) : void from class org.apache.flink.runtime.blob.BlobUtils | From | To | |
Move Attribute | 5 | ||
Move Attribute package GET_OPERATION : byte from class org.apache.flink.runtime.blob.BlobServer to package GET_OPERATION : byte from class org.apache.flink.runtime.blob.BlobServerProtocol | From | To | |
Move Attribute package PUT_OPERATION : byte from class org.apache.flink.runtime.blob.BlobServer to package PUT_OPERATION : byte from class org.apache.flink.runtime.blob.BlobServerProtocol | From | To | |
Move Attribute package BUFFER_SIZE : int from class org.apache.flink.runtime.blob.BlobServer to package BUFFER_SIZE : int from class org.apache.flink.runtime.blob.BlobServerProtocol | From | To | |
Move Attribute package DELETE_OPERATION : byte from class org.apache.flink.runtime.blob.BlobServer to package DELETE_OPERATION : byte from class org.apache.flink.runtime.blob.BlobServerProtocol | From | To | |
Move Attribute package MAX_KEY_LENGTH : int from class org.apache.flink.runtime.blob.BlobServer to package MAX_KEY_LENGTH : int from class org.apache.flink.runtime.blob.BlobServerProtocol | From | To | |
Extract Class | 1 | ||
Extract Class org.apache.flink.runtime.blob.BlobServerProtocol from class org.apache.flink.runtime.blob.BlobServer | From | To | |
Rename Class | 2 | ||
Rename Class org.apache.flink.runtime.blob.BlobCacheTest renamed to org.apache.flink.runtime.blob.BlobCacheSuccessTest | From | To | |
Rename Class org.apache.flink.runtime.blob.BlobConnection renamed to org.apache.flink.runtime.blob.BlobServerConnection | From | To | |
Change Variable Type | 1 | ||
Change Variable Type ioe : IOException to t : Throwable in method public run() : void in class org.apache.flink.runtime.blob.BlobServerConnection | From | To | |
Extract Variable | 2 | ||
Extract Variable is : InputStream in method public get(blobKey BlobKey) : InputStream from class org.apache.flink.runtime.blob.BlobClient | From | To | |
Extract Variable is : InputStream in method public get(jobID JobID, key String) : InputStream from class org.apache.flink.runtime.blob.BlobClient | From | To | |
Extract Method | 2 | ||
Extract Method private receivePutResponseAndCompare(is InputStream, md MessageDigest) : BlobKey extracted from private putBuffer(jobId JobID, key String, value byte[], offset int, len int) : BlobKey in class org.apache.flink.runtime.blob.BlobClient | From | To | |
Extract Method private receivePutResponseAndCompare(is InputStream, md MessageDigest) : BlobKey extracted from private putInputStream(jobId JobID, key String, inputStream InputStream) : BlobKey in class org.apache.flink.runtime.blob.BlobClient | From | To | |
Rename Method | 3 | ||
Rename Method private sendPutHeader(outputStream OutputStream, jobID JobID, key String, buf byte[]) : void renamed to private sendGetHeader(outputStream OutputStream, jobID JobID, key String, blobKey BlobKey) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
Rename Method private deleteInternal(jobId JobID, key String) : void renamed to private sendPutHeader(outputStream OutputStream, jobID JobID, key String) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
Rename Method package getTemporaryFilename() : File renamed to package createTemporaryFilename() : File in class org.apache.flink.runtime.blob.BlobServer | From | To | |
Inline Method | 2 | ||
Inline Method package closeSilently(socket Socket) : void inlined to public run() : void in class org.apache.flink.runtime.blob.BlobServerConnection | From | To | |
Inline Method public getServerPort() : int inlined to public getPort() : int in class org.apache.flink.runtime.blob.BlobServer | From | To | |
Rename Variable | 4 | ||
Rename Variable ioe : IOException to t : Throwable in method public run() : void in class org.apache.flink.runtime.blob.BlobServerConnection | From | To | |
Rename Variable blob : File to blobFile : File in method private get(inputStream InputStream, outputStream OutputStream, buf byte[]) : void in class org.apache.flink.runtime.blob.BlobServerConnection | From | To | |
Rename Variable incomingDirectory : File to incomingDir : File in method package getIncomingDirectory(storageDir File) : File in class org.apache.flink.runtime.blob.BlobUtils | From | To | |
Rename Variable buf : byte[] to idBytes : byte[] in method private sendPutHeader(outputStream OutputStream, jobID JobID, key String) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
Parameterize Variable | 1 | ||
Parameterize Variable os : OutputStream to outputStream : OutputStream in method private sendPutHeader(outputStream OutputStream, jobID JobID, key String) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
Rename Parameter | 6 | ||
Rename Parameter buf : byte[] to blobKey : BlobKey in method private sendGetHeader(outputStream OutputStream, jobID JobID, key String, blobKey BlobKey) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
Rename Parameter jobId : JobID to jobID : JobID in method private sendPutHeader(outputStream OutputStream, jobID JobID, key String) : void in class org.apache.flink.runtime.blob.BlobClient | From | To | |
Rename Parameter blobKey : BlobKey to key : BlobKey in method public delete(key BlobKey) : void in class org.apache.flink.runtime.blob.BlobService | From | To | |
Rename Parameter requiredBlob : BlobKey to key : BlobKey in method public getURL(key BlobKey) : URL in class org.apache.flink.runtime.blob.BlobService | From | To | |
Rename Parameter blobKey : BlobKey to key : BlobKey in method public delete(key BlobKey) : void in class org.apache.flink.runtime.blob.BlobServer | From | To | |
Rename Parameter key : String to jobID : JobID in method private sendPutHeader(outputStream OutputStream, jobID JobID, key String) : void in class org.apache.flink.runtime.blob.BlobClient | From | To |