d3fd7a6794a8ffd16e00bb1867b6e62c3909a2d2
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 4 | ||
| Pull Up Method private createInputGate(numberOfInputChannels int, partitionType ResultPartitionType) : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest to protected createInputGate(numberOfInputChannels int, partitionType ResultPartitionType) : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase | From | To | |
| Pull Up Method private createInputGate() : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest to protected createInputGate() : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase | From | To | |
| Pull Up Method public parameters() : List<Boolean> from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest to public parameters() : List<Boolean> from class org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase | From | To | |
| Pull Up Method private createInputGate(numberOfInputChannels int) : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest to protected createInputGate(numberOfInputChannels int) : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase | From | To | |
| Inline Method | 1 | ||
| Inline Method public notifyInputGateNonEmpty(inputGate InputGate) : void inlined to private queueInputGate(inputGate InputGate) : void in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To | |
| Rename Variable | 3 | ||
| Rename Variable currentChannel : InputChannel to inputChannel : InputChannel in method private waitAndGetNextData(blocking boolean) : Optional<InputWithData<InputChannel,BufferAndAvailability>> in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate | From | To | |
| Rename Variable listener : InputGateListener to toNotify : CompletableFuture<?> in method private queueInputGate(inputGate InputGate) : void in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To | |
| Rename Variable listener : InputGateListener to toNotify : CompletableFuture<?> in method private queueChannel(channel InputChannel) : void in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute public enableCreditBasedFlowControl : boolean from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest to public enableCreditBasedFlowControl : boolean from class org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase from classes [org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest, org.apache.flink.runtime.io.network.partition.consumer.UnionInputGateTest] | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type listener : InputGateListener to toNotify : CompletableFuture<?> in method private queueInputGate(inputGate InputGate) : void in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To | |
| Change Variable Type listener : InputGateListener to toNotify : CompletableFuture<?> in method private queueChannel(channel InputChannel) : void in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type inputGatesWithData : ArrayDeque<InputGate> to inputGatesWithData : LinkedHashSet<InputGate> in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To | |
| Extract Method | 5 | ||
| Extract Method private handleEndOfPartitionEvent(bufferOrEvent BufferOrEvent, inputGate InputGate) : void extracted from public getNextBufferOrEvent() : Optional<BufferOrEvent> in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To | |
| Extract Method private transformToBufferOrEvent(buffer Buffer, moreAvailable boolean, currentChannel InputChannel) : BufferOrEvent extracted from private getNextBufferOrEvent(blocking boolean) : Optional<BufferOrEvent> in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate | From | To | |
| Extract Method private waitAndGetNextData(blocking boolean) : Optional<InputWithData<InputChannel,BufferAndAvailability>> extracted from private getNextBufferOrEvent(blocking boolean) : Optional<BufferOrEvent> in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate | From | To | |
| Extract Method private adjustForUnionInputGate(bufferOrEvent BufferOrEvent, inputGate InputGate, moreInputGatesAvailable boolean) : BufferOrEvent extracted from public getNextBufferOrEvent() : Optional<BufferOrEvent> in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To | |
| Extract Method private getNextBufferOrEvent(blocking boolean) : Optional<BufferOrEvent> extracted from public getNextBufferOrEvent() : Optional<BufferOrEvent> in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To |