dd1eb082fdd291523ec931a01b295e407a2df1f5
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Method | 4 | ||
| Move Method protected createInputGate(numberOfInputChannels int) : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase to private createInputGate(numberOfInputChannels int) : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest | From | To | |
| Move Method protected createInputGate() : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase to private createInputGate() : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest | From | To | |
| Move Method protected createInputGate(numberOfInputChannels int, partitionType ResultPartitionType) : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase to private createInputGate(numberOfInputChannels int, partitionType ResultPartitionType) : SingleInputGate from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest | From | To | |
| Move Method public parameters() : List<Boolean> from class org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase to public parameters() : List<Boolean> from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest | From | To | |
| Rename Variable | 1 | ||
| Rename Variable toNotify : CompletableFuture<?> to listener : InputGateListener in method private queueInputGate(inputGate InputGate) : void in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To | |
| Inline Method | 3 | ||
| Inline Method private transformToBufferOrEvent(buffer Buffer, moreAvailable boolean, currentChannel InputChannel) : BufferOrEvent inlined to private getNextBufferOrEvent(blocking boolean) : Optional<BufferOrEvent> in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate | From | To | |
| Inline Method private waitAndGetNextData(blocking boolean) : Optional<InputWithData<InputChannel,BufferAndAvailability>> inlined to private getNextBufferOrEvent(blocking boolean) : Optional<BufferOrEvent> in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate | From | To | |
| Inline Method private getNextBufferOrEvent(blocking boolean) : Optional<BufferOrEvent> inlined to public getNextBufferOrEvent() : Optional<BufferOrEvent> in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To | |
| Move Attribute | 1 | ||
| Move Attribute public enableCreditBasedFlowControl : boolean from class org.apache.flink.runtime.io.network.partition.consumer.InputGateTestBase to public enableCreditBasedFlowControl : boolean from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type toNotify : CompletableFuture<?> to listener : InputGateListener in method private queueInputGate(inputGate InputGate) : void in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To | |
| Extract Variable | 1 | ||
| Extract Variable moreAvailable : boolean in method private getNextBufferOrEvent(blocking boolean) : Optional<BufferOrEvent> from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate | From | To | |
| Extract Method | 1 | ||
| Extract Method public notifyInputGateNonEmpty(inputGate InputGate) : void extracted from private queueInputGate(inputGate InputGate) : void in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type inputGatesWithData : LinkedHashSet<InputGate> to inputGatesWithData : ArrayDeque<InputGate> in class org.apache.flink.runtime.io.network.partition.consumer.UnionInputGate | From | To |