de67f2ed042301bdd6b452aa37cd097e645041ca
Files Diff
- Added: 11
- Removed: 3
- Renamed: 0
- Modified: 26
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type inputChannels : InputChannelDeploymentDescriptor[] to inputChannels : ShuffleDescriptor[] in method public InputGateDeploymentDescriptor(consumedResultId IntermediateDataSetID, consumedPartitionType ResultPartitionType, consumedSubpartitionIndex int, inputChannels ShuffleDescriptor[]) in class org.apache.flink.runtime.deployment.InputGateDeploymentDescriptor | From | To | |
| Change Parameter Type inputChannelDeploymentDescriptor : InputChannelDeploymentDescriptor to shuffleDescriptor : ShuffleDescriptor in method public PartitionInfo(intermediateResultPartitionID IntermediateDataSetID, shuffleDescriptor ShuffleDescriptor) in class org.apache.flink.runtime.executiongraph.PartitionInfo | From | To | |
| Move Method | 1 | ||
| Move Method public from(partition IntermediateResultPartition, maxParallelism int, lazyScheduling boolean) : ResultPartitionDeploymentDescriptor from class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor to public from(partition IntermediateResultPartition) : PartitionDescriptor from class org.apache.flink.runtime.shuffle.PartitionDescriptor | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private resultId : IntermediateDataSetID from class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor to private resultId : IntermediateDataSetID from class org.apache.flink.runtime.shuffle.PartitionDescriptor | From | To | |
| Move Attribute private partitionType : ResultPartitionType from class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor to private partitionType : ResultPartitionType from class org.apache.flink.runtime.shuffle.PartitionDescriptor | From | To | |
| Move Attribute private partitionId : IntermediateResultPartitionID from class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor to private partitionId : IntermediateResultPartitionID from class org.apache.flink.runtime.shuffle.PartitionDescriptor | From | To | |
| Move Attribute private numberOfSubpartitions : int from class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor to private numberOfSubpartitions : int from class org.apache.flink.runtime.shuffle.PartitionDescriptor | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.flink.runtime.shuffle.PartitionDescriptor from class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor | From | To | |
| Move And Rename Class | 2 | ||
| Move And Rename Class org.apache.flink.runtime.deployment.InputChannelDeploymentDescriptor moved and renamed to org.apache.flink.runtime.shuffle.ShuffleDescriptor | From | To | |
| Merge Variable | 1 | ||
| Merge Variable [numLocalChannels : int, numRemoteChannels : int, numUnknownChannels : int] to channelStatistics : ChannelStatistics in method private createInputChannels(owningTaskName String, inputGateDeploymentDescriptor InputGateDeploymentDescriptor, inputGate SingleInputGate, metrics InputChannelMetrics) : void in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateFactory | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type partitionIds : ResultPartitionID[] to partitionIds : IntermediateResultPartitionID[] in method public testRequestBackoffConfiguration() : void in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateTest | From | To | |
| Change Variable Type partitionType : ResultPartitionType to shuffleDescriptor : ShuffleDescriptor in method private createCopyAndVerifyResultPartitionDeploymentDescriptor(shuffleDescriptor ShuffleDescriptor) : ResultPartitionDeploymentDescriptor in class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptorTest | From | To | |
| Change Variable Type icdd : InputChannelDeploymentDescriptor[] to shuffleDescriptors : ShuffleDescriptor[] in method private createInputChannels(owningTaskName String, inputGateDeploymentDescriptor InputGateDeploymentDescriptor, inputGate SingleInputGate, metrics InputChannelMetrics) : void in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateFactory | From | To | |
| Change Variable Type partitionId : IntermediateResultPartitionID to partitionDescriptor : PartitionDescriptor in method private createCopyAndVerifyResultPartitionDeploymentDescriptor(shuffleDescriptor ShuffleDescriptor) : ResultPartitionDeploymentDescriptor in class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptorTest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable remoteInputChannel : RemoteInputChannel in method public updateInputChannel(localLocation ResourceID, shuffleDescriptor NettyShuffleDescriptor) : void from class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate | From | To | |
| Extract Method | 5 | ||
| Extract Method private createSender(shuffleDescriptor NettyShuffleDescriptor) : TaskDeploymentDescriptor extracted from public testRunJobWithForwardChannel() : void in class org.apache.flink.runtime.taskexecutor.TaskExecutorSubmissionTest | From | To | |
| Extract Method private createSender(shuffleDescriptor NettyShuffleDescriptor) : TaskDeploymentDescriptor extracted from public testCancellingDependentAndStateUpdateFails() : void in class org.apache.flink.runtime.taskexecutor.TaskExecutorSubmissionTest | From | To | |
| Extract Method private createSender(shuffleDescriptor NettyShuffleDescriptor, abstractInvokable Class<? extends AbstractInvokable>) : TaskDeploymentDescriptor extracted from public testFailingScheduleOrUpdateConsumers() : void in class org.apache.flink.runtime.taskexecutor.TaskExecutorSubmissionTest | From | To | |
| Extract Method private allocateAndAssignSlotForExecution(slotProvider SlotProvider, queued boolean, locationPreferenceConstraint LocationPreferenceConstraint, allPreviousExecutionGraphAllocationIds Set<AllocationID>, allocationTimeout Time) : CompletableFuture<LogicalSlot> extracted from public allocateAndAssignSlotForExecution(slotProvider SlotProvider, queued boolean, locationPreferenceConstraint LocationPreferenceConstraint, allPreviousExecutionGraphAllocationIds Set<AllocationID>, allocationTimeout Time) : CompletableFuture<Execution> in class org.apache.flink.runtime.executiongraph.Execution | From | To | |
| Extract Method private createInputChannels(owningTaskName String, inputGateDeploymentDescriptor InputGateDeploymentDescriptor, inputGate SingleInputGate, metrics InputChannelMetrics) : void extracted from public create(owningTaskName String, igdd InputGateDeploymentDescriptor, partitionProducerStateProvider PartitionProducerStateProvider, metrics InputChannelMetrics) : SingleInputGate in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateFactory | From | To | |
| Rename Method | 4 | ||
| Rename Method public getInputChannelDeploymentDescriptor() : InputChannelDeploymentDescriptor renamed to public getShuffleDescriptor() : ShuffleDescriptor in class org.apache.flink.runtime.executiongraph.PartitionInfo | From | To | |
| Rename Method public allocateAndAssignSlotForExecution(slotProvider SlotProvider, queued boolean, locationPreferenceConstraint LocationPreferenceConstraint, allPreviousExecutionGraphAllocationIds Set<AllocationID>, allocationTimeout Time) : CompletableFuture<Execution> renamed to package allocateResourcesForExecution(slotProvider SlotProvider, queued boolean, locationPreferenceConstraint LocationPreferenceConstraint, allPreviousExecutionGraphAllocationIds Set<AllocationID>, allocationTimeout Time) : CompletableFuture<Execution> in class org.apache.flink.runtime.executiongraph.Execution | From | To | |
| Rename Method public testSerialization() : void renamed to private createCopyAndVerifyResultPartitionDeploymentDescriptor(shuffleDescriptor ShuffleDescriptor) : ResultPartitionDeploymentDescriptor in class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptorTest | From | To | |
| Rename Method public getInputChannelDeploymentDescriptors() : InputChannelDeploymentDescriptor[] renamed to public getShuffleDescriptors() : ShuffleDescriptor[] in class org.apache.flink.runtime.deployment.InputGateDeploymentDescriptor | From | To | |
| Rename Variable | 4 | ||
| Rename Variable task1ResultPartitionDescriptor : ResultPartitionDeploymentDescriptor to resultPartitionDeploymentDescriptor : ResultPartitionDeploymentDescriptor in method private createSender(shuffleDescriptor NettyShuffleDescriptor, abstractInvokable Class<? extends AbstractInvokable>) : TaskDeploymentDescriptor in class org.apache.flink.runtime.taskexecutor.TaskExecutorSubmissionTest | From | To | |
| Rename Variable icdd : InputChannelDeploymentDescriptor[] to shuffleDescriptors : ShuffleDescriptor[] in method private createInputChannels(owningTaskName String, inputGateDeploymentDescriptor InputGateDeploymentDescriptor, inputGate SingleInputGate, metrics InputChannelMetrics) : void in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateFactory | From | To | |
| Rename Variable partitionId : ResultPartitionID to resultPartitionID : ResultPartitionID in method private createInputChannels(owningTaskName String, inputGateDeploymentDescriptor InputGateDeploymentDescriptor, inputGate SingleInputGate, metrics InputChannelMetrics) : void in class org.apache.flink.runtime.io.network.partition.consumer.SingleInputGateFactory | From | To | |
| Change Return Type | 4 | ||
| Change Return Type InputChannelDeploymentDescriptor[] to ShuffleDescriptor[] in method public getShuffleDescriptors() : ShuffleDescriptor[] in class org.apache.flink.runtime.deployment.InputGateDeploymentDescriptor | From | To | |
| Change Return Type void to ResultPartitionDeploymentDescriptor in method private createCopyAndVerifyResultPartitionDeploymentDescriptor(shuffleDescriptor ShuffleDescriptor) : ResultPartitionDeploymentDescriptor in class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptorTest | From | To | |
| Change Return Type ResultPartitionDeploymentDescriptor to PartitionDescriptor in method public from(partition IntermediateResultPartition) : PartitionDescriptor in class org.apache.flink.runtime.shuffle.PartitionDescriptor | From | To | |
| Change Return Type InputChannelDeploymentDescriptor to ShuffleDescriptor in method public getShuffleDescriptor() : ShuffleDescriptor in class org.apache.flink.runtime.executiongraph.PartitionInfo | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute partitionId : IntermediateResultPartitionID to partitionDescriptor : PartitionDescriptor in method private createCopyAndVerifyResultPartitionDeploymentDescriptor(shuffleDescriptor ShuffleDescriptor) : ResultPartitionDeploymentDescriptor in class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptorTest | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable partitionType : ResultPartitionType to shuffleDescriptor : ShuffleDescriptor in method private createCopyAndVerifyResultPartitionDeploymentDescriptor(shuffleDescriptor ShuffleDescriptor) : ResultPartitionDeploymentDescriptor in class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptorTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type inputChannels : InputChannelDeploymentDescriptor[] to inputChannels : ShuffleDescriptor[] in class org.apache.flink.runtime.deployment.InputGateDeploymentDescriptor | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter lazyScheduling : boolean to sendScheduleOrUpdateConsumersMessage : boolean in method public ResultPartitionDeploymentDescriptor(partitionDescriptor PartitionDescriptor, shuffleDescriptor ShuffleDescriptor, maxParallelism int, sendScheduleOrUpdateConsumersMessage boolean) in class org.apache.flink.runtime.deployment.ResultPartitionDeploymentDescriptor | From | To | |
| Rename Parameter inputChannelDeploymentDescriptor : InputChannelDeploymentDescriptor to shuffleDescriptor : ShuffleDescriptor in method public PartitionInfo(intermediateResultPartitionID IntermediateDataSetID, shuffleDescriptor ShuffleDescriptor) in class org.apache.flink.runtime.executiongraph.PartitionInfo | From | To |