f4ac852275da36ee33aa54ae9097293ccc981afa
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 7 | ||
| Rename Method public updateConfig(options CommandLineOptions) : void renamed to public retrieveClient(options CommandLineOptions) : ClusterClient in class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest.TestCLI | From | To | |
| Rename Method public getIdentifier() : String renamed to public getId() : String in class org.apache.flink.client.cli.CustomCommandLine | From | To | |
| Rename Method public writeJobManagerAddressToConfig(config Configuration, address InetSocketAddress) : void renamed to public setJobManagerAddressInConfig(config Configuration, address InetSocketAddress) : void in class org.apache.flink.client.CliFrontend | From | To | |
| Rename Method public createClient(applicationName String, cmdLine CommandLine) : YarnClusterClient renamed to public createCluster(applicationName String, cmdLine CommandLine, config Configuration) : YarnClusterClient in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Rename Method public getIdentifier() : String renamed to public getId() : String in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Rename Method public testYarnConfig() : void renamed to public testInvalidYarnPropertiesFile() : void in class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest | From | To | |
| Rename Method public getYARNAttachCLIOptions(options Options) : void renamed to public addGeneralOptions(baseOptions Options) : void in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Move Method | 1 | ||
| Move Method private loadCustomCommandLine(className String, params Object...) : void from class org.apache.flink.client.cli.CliFrontendParser to private loadCustomCommandLine(className String, params Object...) : void from class org.apache.flink.client.CliFrontend | From | To | |
| Rename Variable | 6 | ||
| Rename Variable entry : Map.Entry<String,CustomCommandLine> to cli : CustomCommandLine in method private printCustomCliOptions(formatter HelpFormatter, runOptions boolean) : void in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
| Rename Variable tmpFolder : File to directoryPath : File in method public testInvalidYarnPropertiesFile() : void in class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest | From | To | |
| Rename Variable flinkYarnClient : YarnClusterDescriptor to yarnDescriptor : AbstractYarnClusterDescriptor in method public run(args String[]) : int in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Rename Variable yarnOpts : Options to customOpts : Options in method private printCustomCliOptions(formatter HelpFormatter, runOptions boolean) : void in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
| Rename Variable opt : Options to options : Options in method private printUsage() : void in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Change Return Type | 3 | ||
| Change Return Type YarnClusterDescriptor to AbstractYarnClusterDescriptor in method public createDescriptor(defaultApplicationName String, cmd CommandLine) : AbstractYarnClusterDescriptor in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Change Return Type String to File in method public getYarnPropertiesLocation(conf Configuration) : File in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Change Return Type void to ClusterClient in method public retrieveClient(options CommandLineOptions) : ClusterClient in class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest.TestCLI | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type flinkYarnDescriptor : YarnClusterDescriptor to flinkYarnDescriptor : AbstractYarnClusterDescriptor in method public testDynamicProperties() : void in class org.apache.flink.yarn.FlinkYarnSessionCliTest | From | To | |
| Change Variable Type yarnClusterDescriptor : YarnClusterDescriptor to yarnClusterDescriptor : AbstractYarnClusterDescriptor in method public createCluster(applicationName String, cmdLine CommandLine, config Configuration) : YarnClusterClient in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Change Variable Type entry : Map.Entry<String,CustomCommandLine> to cli : CustomCommandLine in method private printCustomCliOptions(formatter HelpFormatter, runOptions boolean) : void in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
| Change Variable Type flinkYarnClient : YarnClusterDescriptor to yarnDescriptor : AbstractYarnClusterDescriptor in method public run(args String[]) : int in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Extract Method | 14 | ||
| Extract Method protected createYarnClusterClient(descriptor AbstractYarnClusterDescriptor, yarnClient YarnClient, report ApplicationReport, flinkConfiguration Configuration, sessionFilesDir Path, perJobCluster boolean) : YarnClusterClient extracted from protected deployInternal() : YarnClusterClient in class org.apache.flink.yarn.AbstractYarnClusterDescriptor | From | To | |
| Extract Method private addCustomCliOptions(options Options, runOptions boolean) : Options extracted from private getCancelOptions(options Options) : Options in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
| Extract Method private printCustomCliOptions(formatter HelpFormatter, runOptions boolean) : void extracted from public printHelpForInfo() : void in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
| Extract Method public shutdownCluster() : void extracted from public finalizeCluster() : void in class org.apache.flink.yarn.YarnClusterClient | From | To | |
| Extract Method private addCustomCliOptions(options Options, runOptions boolean) : Options extracted from private getSavepointOptions(options Options) : Options in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
| Extract Method protected getClusterDescriptor() : AbstractYarnClusterDescriptor extracted from public run(args String[]) : int in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Extract Method private printCustomCliOptions(formatter HelpFormatter, runOptions boolean) : void extracted from public printHelpForRun() : void in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
| Extract Method private writeYarnPropertiesFile(contents String) : File extracted from public testYarnConfig() : void in class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest | From | To | |
| Extract Method public addRunOptions(baseOptions Options) : void extracted from private printUsage() : void in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Extract Method public getActiveCustomCommandLine(commandLine CommandLine) : CustomCommandLine extracted from protected getClient(options CommandLineOptions, programName String) : ClusterClient in class org.apache.flink.client.CliFrontend | From | To | |
| Extract Method protected getClusterDescriptor() : AbstractYarnClusterDescriptor extracted from public createDescriptor(defaultApplicationName String, cmd CommandLine) : YarnClusterDescriptor in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
| Extract Method private addCustomCliOptions(options Options, runOptions boolean) : Options extracted from private getStopOptions(options Options) : Options in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
| Extract Method private addCustomCliOptions(options Options, runOptions boolean) : Options extracted from private getListOptions(options Options) : Options in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
| Extract Method private addCustomCliOptions(options Options, runOptions boolean) : Options extracted from private getInfoOptions(options Options) : Options in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter options : Options to baseOptions : Options in method public addGeneralOptions(baseOptions Options) : void in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To |