f9b52a3114a2114e6846091acf3abb294a49615b
Files Diff
- Added: 11
- Removed: 8
- Renamed: 0
- Modified: 44
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 6 | ||
Change Parameter Type client : Client to client : ClusterClient in method protected executeProgram(program PackagedProgram, client ClusterClient, parallelism int) : int in class org.apache.flink.client.CliFrontendRunTest.RunTestingCliFrontend | From | To | |
Change Parameter Type client : Client to client : ClusterClient in method public ContextEnvironmentFactory(client ClusterClient, jarFilesToAttach List<URL>, classpathsToAttach List<URL>, userCodeClassLoader ClassLoader, defaultParallelism int, isDetached boolean, savepointPath String) in class org.apache.flink.client.program.ContextEnvironmentFactory | From | To | |
Change Parameter Type client : Client to client : ClusterClient in method protected executeProgram(program PackagedProgram, client ClusterClient, parallelism int) : int in class org.apache.flink.client.CliFrontend | From | To | |
Change Parameter Type remoteConnection : Client to remoteConnection : ClusterClient in method public ContextEnvironment(remoteConnection ClusterClient, jarFiles List<URL>, classpaths List<URL>, userCodeClassLoader ClassLoader, savepointPath String) in class org.apache.flink.client.program.ContextEnvironment | From | To | |
Change Parameter Type remoteConnection : Client to remoteConnection : ClusterClient in method public DetachedEnvironment(remoteConnection ClusterClient, jarFiles List<URL>, classpaths List<URL>, userCodeClassLoader ClassLoader, savepointPath String) in class org.apache.flink.client.program.DetachedEnvironment | From | To | |
Change Parameter Type yarnCluster : AbstractFlinkYarnCluster to yarnCluster : YarnClusterClient in method public runInteractiveCli(yarnCluster YarnClusterClient, readConsoleInput boolean) : void in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
Move Method | 4 | ||
Move Method public testManualOptionsOverridesYarn() : void from class org.apache.flink.client.CliFrontendAddressConfigurationTest to public testManualOptionsOverridesYarn() : void from class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest | From | To | |
Move Method public checkJobManagerAddress(config Configuration, expectedAddress String, expectedPort int) : void from class org.apache.flink.client.CliFrontendAddressConfigurationTest to private checkJobManagerAddress(config Configuration, expectedAddress String, expectedPort int) : void from class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest | From | To | |
Move Method public testInvalidYarnConfig() : void from class org.apache.flink.client.CliFrontendAddressConfigurationTest to public testInvalidYarnConfig() : void from class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest | From | To | |
Move Method public testYarnConfig() : void from class org.apache.flink.client.CliFrontendAddressConfigurationTest to public testYarnConfig() : void from class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest | From | To | |
Pull Up Attribute | 2 | ||
Pull Up Attribute private flinkConfig : org.apache.flink.configuration.Configuration from class org.apache.flink.yarn.FlinkYarnCluster to protected flinkConfig : Configuration from class org.apache.flink.client.program.ClusterClient | From | To | |
Pull Up Attribute private actorSystem : ActorSystem from class org.apache.flink.yarn.FlinkYarnCluster to protected actorSystem : ActorSystem from class org.apache.flink.client.program.ClusterClient | From | To | |
Move Attribute | 2 | ||
Move Attribute public TEST_YARN_JOB_MANAGER_PORT : int from class org.apache.flink.client.CliFrontendTestUtils to private TEST_YARN_JOB_MANAGER_PORT : int from class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest | From | To | |
Move Attribute public TEST_YARN_JOB_MANAGER_ADDRESS : String from class org.apache.flink.client.CliFrontendTestUtils to private TEST_YARN_JOB_MANAGER_ADDRESS : String from class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest | From | To | |
Extract Class | 2 | ||
Extract Class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest from class org.apache.flink.client.CliFrontendTestUtils | From | To | |
Extract Class org.apache.flink.yarn.CliFrontendYarnAddressConfigurationTest from class org.apache.flink.client.CliFrontendAddressConfigurationTest | From | To | |
Rename Class | 5 | ||
Rename Class org.apache.flink.yarn.TestingFlinkYarnClient renamed to org.apache.flink.yarn.TestingYarnClusterDescriptor | From | To | |
Rename Class org.apache.flink.yarn.FlinkYarnClient renamed to org.apache.flink.yarn.YarnClusterDescriptor | From | To | |
Rename Class org.apache.flink.client.program.Client renamed to org.apache.flink.client.program.ClusterClient | From | To | |
Rename Class org.apache.flink.yarn.FlinkYarnClientBase renamed to org.apache.flink.yarn.AbstractYarnClusterDescriptor | From | To | |
Rename Class org.apache.flink.yarn.FlinkYarnCluster renamed to org.apache.flink.yarn.YarnClusterClient | From | To | |
Move And Rename Class | 1 | ||
Move And Rename Class org.apache.flink.runtime.yarn.AbstractFlinkYarnCluster moved and renamed to org.apache.flink.client.program.ClusterClient | From | To | |
Move Class | 1 | ||
Move Class org.apache.flink.client.FlinkYarnSessionCli moved to org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
Change Variable Type | 12 | ||
Change Variable Type flinkYarnClient : AbstractFlinkYarnClient to flinkYarnDescriptor : YarnClusterDescriptor in method public testDynamicProperties() : void in class org.apache.flink.yarn.FlinkYarnSessionCliTest | From | To | |
Change Variable Type status : boolean to status : ApplicationStatus in method public getApplicationStatus() : ApplicationStatus in class org.apache.flink.yarn.YarnClusterClient | From | To | |
Change Variable Type client : Client to client : ClusterClient in method protected executeRemotely(streamGraph StreamGraph, jarFiles List<URL>) : JobExecutionResult in class org.apache.flink.streaming.api.environment.RemoteStreamEnvironment | From | To | |
Change Variable Type out : Client to out : ClusterClient in method public shouldSubmitToJobClient() : void in class org.apache.flink.client.program.ClientTest | From | To | |
Change Variable Type client : Client to client : ClusterClient in method public submitTopologyWithOpts(name String, uploadedJarLocation String, topology FlinkTopology) : void in class org.apache.flink.storm.api.FlinkClient | From | To | |
Change Variable Type out : Client to out : ClusterClient in method public shouldSubmitToJobClientFails() : void in class org.apache.flink.client.program.ClientTest | From | To | |
Change Variable Type out : Client to out : ClusterClient in method public testDetachedMode() : void in class org.apache.flink.client.program.ClientTest | From | To | |
Change Variable Type yarnCluster : AbstractFlinkYarnCluster to yarnCluster : ClusterClient in method public testJavaAPI() : void in class org.apache.flink.yarn.YARNSessionFIFOITCase | From | To | |
Change Variable Type client : Client to client : ClusterClient in method public testExternalProgram() : void in class org.apache.flink.api.avro.AvroExternalJarProgramITCase | From | To | |
Change Variable Type flinkYarnClient : TestingFlinkYarnClient to flinkYarnClient : TestingYarnClusterDescriptor in method public testMultipleAMKill() : void in class org.apache.flink.yarn.YARNHighAvailabilityITCase | From | To | |
Change Variable Type yarnCluster : AbstractFlinkYarnCluster to yarnCluster : ClusterClient in method public testMultipleAMKill() : void in class org.apache.flink.yarn.YARNHighAvailabilityITCase | From | To | |
Change Variable Type client : Client to client : ClusterClient in method public killTopologyWithOpts(name String, options KillOptions) : void in class org.apache.flink.storm.api.FlinkClient | From | To | |
Extract Method | 1 | ||
Extract Method private getOptimizedPlan(compiler Optimizer, prog JobWithJars, parallelism int) : OptimizedPlan extracted from public runDetached(program JobWithJars, parallelism int, savepointPath String) : JobSubmissionResult in class org.apache.flink.client.program.ClusterClient | From | To | |
Rename Method | 9 | ||
Rename Method public shutdown(failApplication boolean) : void renamed to public finalizeCluster() : void in class org.apache.flink.yarn.YarnClusterClient | From | To | |
Rename Method public getYARNSessionCLIOptions(options Options) : void renamed to public addOptions(options Options) : void in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
Rename Method public hasBeenStopped() : boolean renamed to public hasBeenShutdown() : boolean in class org.apache.flink.yarn.YarnClusterClient | From | To | |
Rename Method protected executeProgramDetached(program PackagedProgram, client Client, parallelism int) : int renamed to protected executeProgram(program PackagedProgram, client ClusterClient, parallelism int) : int in class org.apache.flink.client.CliFrontendRunTest.RunTestingCliFrontend | From | To | |
Rename Method public hasFailed() : boolean renamed to public getApplicationStatus() : ApplicationStatus in class org.apache.flink.yarn.YarnClusterClient | From | To | |
Rename Method protected executeProgramBlocking(program PackagedProgram, client Client, parallelism int) : int renamed to protected executeProgram(program PackagedProgram, client ClusterClient, parallelism int) : int in class org.apache.flink.client.CliFrontend | From | To | |
Rename Method public abstract shutdown(failApplication boolean) : void renamed to protected abstract finalizeCluster() : void in class org.apache.flink.client.program.ClusterClient | From | To | |
Rename Method public abstract getApplicationId() : String renamed to protected abstract getClusterIdentifier() : String in class org.apache.flink.client.program.ClusterClient | From | To | |
Rename Method public getApplicationId() : String renamed to public getClusterIdentifier() : String in class org.apache.flink.yarn.YarnClusterClient | From | To | |
Pull Up Method | 1 | ||
Pull Up Method public getJobManagerAddress() : InetSocketAddress from class org.apache.flink.yarn.FlinkYarnCluster to public getJobManagerAddress() : InetSocketAddress from class org.apache.flink.client.program.ClusterClient | From | To | |
Rename Variable | 3 | ||
Rename Variable yarnOpts : Options to customOpts : Options in method public printHelpForRun() : void in class org.apache.flink.client.cli.CliFrontendParser | From | To | |
Rename Variable optimizedPlan : OptimizedPlan to optPlan : OptimizedPlan in method public run(program JobWithJars, parallelism int, savepointPath String) : JobSubmissionResult in class org.apache.flink.client.program.ClusterClient | From | To | |
Rename Variable flinkYarnClient : AbstractFlinkYarnClient to flinkYarnDescriptor : YarnClusterDescriptor in method public testDynamicProperties() : void in class org.apache.flink.yarn.FlinkYarnSessionCliTest | From | To | |
Change Return Type | 4 | ||
Change Return Type AbstractFlinkYarnCluster to YarnClusterClient in method public deploy() : YarnClusterClient in class org.apache.flink.yarn.AbstractYarnClusterDescriptor | From | To | |
Change Return Type Client to ClusterClient in method public getClient() : ClusterClient in class org.apache.flink.client.program.ContextEnvironment | From | To | |
Change Return Type AbstractFlinkYarnCluster to YarnClusterClient in method protected deployInternal() : YarnClusterClient in class org.apache.flink.yarn.AbstractYarnClusterDescriptor | From | To | |
Change Return Type boolean to ApplicationStatus in method public getApplicationStatus() : ApplicationStatus in class org.apache.flink.yarn.YarnClusterClient | From | To | |
Replace Variable With Attribute | 1 | ||
Replace Variable With Attribute url : String to trackingURL : String in method public getWebInterfaceURL() : String in class org.apache.flink.yarn.YarnClusterClient | From | To | |
Extract Superclass | 1 | ||
Extract Superclass org.apache.flink.client.program.ClusterClient from classes [org.apache.flink.yarn.YarnClusterClient] | From | To | |
Rename Attribute | 2 | ||
Rename Attribute config : Configuration to flinkConfig : Configuration in class org.apache.flink.client.program.ClusterClient | From | To | |
Rename Attribute wait : boolean to isDetached : boolean in class org.apache.flink.client.program.ContextEnvironmentFactory | From | To | |
Extract Interface | 1 | ||
Extract Interface org.apache.flink.client.deployment.ClusterDescriptor from classes [org.apache.flink.yarn.AbstractYarnClusterDescriptor] | From | To | |
Change Attribute Type | 5 | ||
Change Attribute Type client : Client to client : ClusterClient in class org.apache.flink.client.program.ContextEnvironment | From | To | |
Change Attribute Type applicationId : ApplicationId to applicationId : ApplicationReport in class org.apache.flink.yarn.YarnClusterClient | From | To | |
Change Attribute Type client : Client to client : ClusterClient in class org.apache.flink.client.RemoteExecutor | From | To | |
Change Attribute Type client : Client to client : ClusterClient in class org.apache.flink.client.program.ContextEnvironmentFactory | From | To | |
Change Attribute Type yarnCluster : AbstractFlinkYarnCluster to yarnCluster : YarnClusterClient in class org.apache.flink.yarn.cli.FlinkYarnSessionCli | From | To | |
Extract And Move Method | 2 | ||
Extract And Move Method public isDetached() : boolean extracted from public isDetached() : boolean in class org.apache.flink.yarn.FlinkYarnCluster & moved to class org.apache.flink.client.program.ClusterClient | From | To | |
Extract And Move Method public isJobExecutionResults() : boolean extracted from protected executeProgramBlocking(program PackagedProgram, client Client, parallelism int) : int in class org.apache.flink.client.CliFrontend & moved to class org.apache.flink.api.common.JobSubmissionResult | From | To | |
Rename Parameter | 2 | ||
Rename Parameter wait : boolean to isDetached : boolean in method public ContextEnvironmentFactory(client ClusterClient, jarFilesToAttach List<URL>, classpathsToAttach List<URL>, userCodeClassLoader ClassLoader, defaultParallelism int, isDetached boolean, savepointPath String) in class org.apache.flink.client.program.ContextEnvironmentFactory | From | To | |
Rename Parameter config : Configuration to flinkConfig : Configuration in method public ClusterClient(flinkConfig Configuration) in class org.apache.flink.client.program.ClusterClient | From | To |