fd410d9f6d1c8d53fb721752528ebd77fd78db57
Files Diff
- Added: 2
- Removed: 7
- Renamed: 0
- Modified: 69
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type shutdownStoreAndCounter : boolean to jobStatus : JobStatus in method public shutdown(jobStatus JobStatus) : void in class org.apache.flink.runtime.checkpoint.CheckpointCoordinator | From | To | |
| Pull Up Attribute | 5 | ||
| Pull Up Attribute private LOG : Logger from class org.apache.flink.runtime.checkpoint.savepoint.HeapSavepointStore to private LOG : Logger from class org.apache.flink.runtime.checkpoint.savepoint.SavepointStore | From | To | |
| Pull Up Attribute private prefix : String from class org.apache.flink.runtime.checkpoint.savepoint.FsSavepointStore to private prefix : String from class org.apache.flink.runtime.checkpoint.savepoint.SavepointStore | From | To | |
| Pull Up Attribute package MAGIC_NUMBER : int from class org.apache.flink.runtime.checkpoint.savepoint.FsSavepointStore to private MAGIC_NUMBER : int from class org.apache.flink.runtime.checkpoint.savepoint.SavepointStore | From | To | |
| Pull Up Attribute private LOG : Logger from class org.apache.flink.runtime.checkpoint.savepoint.FsSavepointStore to private LOG : Logger from class org.apache.flink.runtime.checkpoint.savepoint.SavepointStore | From | To | |
| Pull Up Attribute private LOG : Logger from class org.apache.flink.runtime.checkpoint.PendingSavepoint to private LOG : Logger from class org.apache.flink.runtime.checkpoint.PendingCheckpoint | From | To | |
| Move Attribute | 5 | ||
| Move Attribute private LOG : Logger from class org.apache.flink.runtime.checkpoint.PendingSavepoint to private LOG : Logger from class org.apache.flink.runtime.checkpoint.savepoint.SavepointStore | From | To | |
| Move Attribute private LOG : Logger from class org.apache.flink.runtime.checkpoint.PendingSavepoint to private LOG : Logger from class org.apache.flink.runtime.checkpoint.CompletedCheckpoint | From | To | |
| Move Attribute private LOG : Logger from class org.apache.flink.runtime.checkpoint.savepoint.HeapSavepointStore to private LOG : Logger from class org.apache.flink.runtime.checkpoint.PendingCheckpoint | From | To | |
| Move Attribute public LOG : Logger from class org.apache.flink.runtime.checkpoint.savepoint.SavepointStoreFactory to private LOG : Logger from class org.apache.flink.runtime.checkpoint.PendingCheckpoint | From | To | |
| Move Attribute private LOG : Logger from class org.apache.flink.runtime.checkpoint.PendingSavepoint to private LOG : Logger from class org.apache.flink.runtime.checkpoint.StandaloneCompletedCheckpointStore | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.flink.runtime.checkpoint.savepoint.FsSavepointStoreTest renamed to org.apache.flink.runtime.checkpoint.savepoint.SavepointStoreTest | From | To | |
| Change Variable Type | 8 | ||
| Change Variable Type savepointFuture1 : Future<String> to savepointFuture1 : Future<CompletedCheckpoint> in method public testSavepointsAreNotSubsumed() : void in class org.apache.flink.runtime.checkpoint.CheckpointCoordinatorTest | From | To | |
| Change Variable Type savepointFuture : Future<String> to savepointFuture : Future<CompletedCheckpoint> in method public testTriggerAndConfirmSimpleSavepoint() : void in class org.apache.flink.runtime.checkpoint.CheckpointCoordinatorTest | From | To | |
| Change Variable Type savepointFutures : List<Future<String>> to savepointFutures : List<Future<CompletedCheckpoint>> in method public testConcurrentSavepoints() : void in class org.apache.flink.runtime.checkpoint.CheckpointCoordinatorTest | From | To | |
| Change Variable Type savepoint0 : Future<String> to savepoint0 : Future<CompletedCheckpoint> in method public testMinDelayBetweenSavepoints() : void in class org.apache.flink.runtime.checkpoint.CheckpointCoordinatorTest | From | To | |
| Change Variable Type savepointFuture2 : Future<String> to savepointFuture2 : Future<CompletedCheckpoint> in method public testSavepointsAreNotSubsumed() : void in class org.apache.flink.runtime.checkpoint.CheckpointCoordinatorTest | From | To | |
| Change Variable Type savepointFuture : Future<String> to savepointFuture : Future<CompletedCheckpoint> in method public testConcurrentSavepoints() : void in class org.apache.flink.runtime.checkpoint.CheckpointCoordinatorTest | From | To | |
| Change Variable Type savepoint1 : Future<String> to savepoint1 : Future<CompletedCheckpoint> in method public testMinDelayBetweenSavepoints() : void in class org.apache.flink.runtime.checkpoint.CheckpointCoordinatorTest | From | To | |
| Extract Variable | 3 | ||
| Extract Variable props : CheckpointProperties in method public testCheckpointProperties() : void from class org.apache.flink.runtime.checkpoint.CheckpointPropertiesTest | From | To | |
| Extract Variable props : CheckpointProperties in method public testSavepointProperties() : void from class org.apache.flink.runtime.checkpoint.CheckpointPropertiesTest | From | To | |
| Extract Variable jobStats : JobCheckpointStats in method public handleRequest(graph ExecutionGraph, params Map<String,String>) : String from class org.apache.flink.runtime.webmonitor.handlers.JobCheckpointsHandler | From | To | |
| Extract Method | 2 | ||
| Extract Method private discard() : void extracted from public discardState() : void in class org.apache.flink.runtime.checkpoint.CompletedCheckpoint | From | To | |
| Extract Method protected createCheckpoint(id int, numberOfStates int, props CheckpointProperties) : TestCompletedCheckpoint extracted from protected createCheckpoint(id int, numberOfStates int) : TestCompletedCheckpoint in class org.apache.flink.runtime.checkpoint.CompletedCheckpointStoreTest | From | To | |
| Rename Method | 3 | ||
| Rename Method public isSavepoint() : boolean renamed to public discardOnJobFailed() : boolean in class org.apache.flink.runtime.checkpoint.CheckpointProperties | From | To | |
| Rename Method public discardState() : void renamed to public subsume() : boolean in class org.apache.flink.runtime.checkpoint.CompletedCheckpoint | From | To | |
| Rename Method public discardState() : void renamed to private discard() : void in class org.apache.flink.runtime.checkpoint.CompletedCheckpointStoreTest.TestCompletedCheckpoint | From | To | |
| Pull Up Method | 4 | ||
| Pull Up Method private createFsInputStream(path Path) : FSDataInputStream from class org.apache.flink.runtime.checkpoint.savepoint.FsSavepointStore to private createFsInputStream(path Path) : FSDataInputStream from class org.apache.flink.runtime.checkpoint.savepoint.SavepointStore | From | To | |
| Pull Up Method public storeSavepoint(savepoint T) : String from class org.apache.flink.runtime.checkpoint.savepoint.FsSavepointStore to public storeSavepoint(targetDirectory String, savepoint T) : String from class org.apache.flink.runtime.checkpoint.savepoint.SavepointStore | From | To | |
| Pull Up Method public disposeSavepoint(path String) : void from class org.apache.flink.runtime.checkpoint.savepoint.FsSavepointStore to public removeSavepoint(path String) : void from class org.apache.flink.runtime.checkpoint.savepoint.SavepointStore | From | To | |
| Pull Up Method public loadSavepoint(path String) : Savepoint from class org.apache.flink.runtime.checkpoint.savepoint.FsSavepointStore to public loadSavepoint(path String) : Savepoint from class org.apache.flink.runtime.checkpoint.savepoint.SavepointStore | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to boolean in method public subsume() : boolean in class org.apache.flink.runtime.checkpoint.CompletedCheckpoint | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute deleteStateWhenDisposed : boolean to externalPath : String in class org.apache.flink.runtime.checkpoint.CompletedCheckpoint | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type deleteStateWhenDisposed : boolean to externalPath : String in class org.apache.flink.runtime.checkpoint.CompletedCheckpoint | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public forceCheckpoint() : boolean extracted from public canBeSubsumed() : boolean in class org.apache.flink.runtime.checkpoint.PendingCheckpoint & moved to class org.apache.flink.runtime.checkpoint.CheckpointProperties | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter shutdownStoreAndCounter : boolean to jobStatus : JobStatus in method public shutdown(jobStatus JobStatus) : void in class org.apache.flink.runtime.checkpoint.CheckpointCoordinator | From | To |