211dd5336e47f31556f3f6f42f11b7f7a62ec887
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private sanitetizeList(options List<?>, needNullSelectOption boolean) : List<?> renamed to package sanitizeList(options List<?>, needNullSelectOption boolean) : List<?> in class com.vaadin.v7.ui.ComboBox | From | To | |
| Rename Method private getItemStyle(itemId Object) : String renamed to private paintItemStyle(target PaintTarget, itemId Object) : void in class com.vaadin.v7.ui.ComboBox | From | To | |
| Move Method | 1 | ||
| Move Method private performSelection(selectedKey String, oldSuggestionTextMatchTheOldSelection boolean, updatePromptAndSelectionIfMatchFound boolean) : void from class com.vaadin.v7.client.ui.VFilterSelect to private performSelection(selectedKey String) : void from class com.vaadin.v7.client.ui.combobox.ComboBoxConnector | From | To | |
| Inline Method | 2 | ||
| Inline Method private getDataReceivedHandler() : DataReceivedHandler inlined to public updateFromUIDL(uidl UIDL, client ApplicationConnection) : void in class com.vaadin.v7.client.ui.combobox.ComboBoxConnector | From | To | |
| Change Return Type | 1 | ||
| Change Return Type String to void in method private paintItemStyle(target PaintTarget, itemId Object) : void in class com.vaadin.v7.ui.ComboBox | From | To | |
| Move Attribute | 7 | ||
| Move Attribute public textInputAllowed : boolean from class com.vaadin.v7.shared.ui.combobox.ComboBoxState to private textInputAllowed : boolean from class com.vaadin.v7.ui.ComboBox | From | To | |
| Move Attribute public filteringMode : FilteringMode from class com.vaadin.v7.shared.ui.combobox.ComboBoxState to private filteringMode : FilteringMode from class com.vaadin.v7.ui.ComboBox | From | To | |
| Move Attribute public inputPrompt : String from class com.vaadin.v7.shared.ui.combobox.ComboBoxState to private inputPrompt : String from class com.vaadin.v7.ui.ComboBox | From | To | |
| Move Attribute public pageLength : int from class com.vaadin.v7.shared.ui.combobox.ComboBoxState to protected pageLength : int from class com.vaadin.v7.ui.ComboBox | From | To | |
| Move Attribute private popupOpenerClicked : boolean from class com.vaadin.v7.client.ui.VFilterSelect.DataReceivedHandler to public popupOpenerClicked : boolean from class com.vaadin.v7.client.ui.VFilterSelect | From | To | |
| Move Attribute private waitingForFilteringResponse : boolean from class com.vaadin.v7.client.ui.VFilterSelect.DataReceivedHandler to public waitingForFilteringResponse : boolean from class com.vaadin.v7.client.ui.VFilterSelect | From | To | |
| Move Attribute public suggestionPopupWidth : String from class com.vaadin.v7.shared.ui.combobox.ComboBoxState to private suggestionPopupWidth : String from class com.vaadin.v7.ui.ComboBox | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute oldSuggestionTextMatchesTheOldSelection : boolean to oldSuggestionTextMatchTheOldSelection : boolean in method public updateFromUIDL(uidl UIDL, client ApplicationConnection) : void in class com.vaadin.v7.client.ui.combobox.ComboBoxConnector | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [key : String, caption : String, style : String, untranslatedIconUri : String] to uidl : UIDL in method public FilterSelectSuggestion(uidl UIDL) in class com.vaadin.v7.client.ui.VFilterSelect.FilterSelectSuggestion | From | To | |
| Extract Method | 1 | ||
| Extract Method private filterOptions(page int, filter String, immediate boolean) : void extracted from public filterOptions(page int, filter String) : void in class com.vaadin.v7.client.ui.VFilterSelect | From | To |