framework b38dc12c24ca5eb0cc597309e0317e4364585433

b38dc12c24ca5eb0cc597309e0317e4364585433

Files Diff

Added: 2
Removed: 1
Renamed: 0
Modified: 6

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Push Down Method	1
Push Down Method public setText(text String) : void from class com.vaadin.client.communication.ReconnectDialog to public setText(text String) : void from class com.vaadin.client.communication.DefaultReconnectDialog	From	To
Move And Rename Method	1
Move And Rename Method public ReconnectDialog() from class com.vaadin.client.communication.ReconnectDialog to public DefaultReconnectDialog() from class com.vaadin.client.communication.DefaultReconnectDialog	From	To
Extract Subclass	1
Extract Subclass com.vaadin.client.communication.DefaultReconnectDialog from class com.vaadin.client.communication.ReconnectDialog	From	To
Inline Method	2
Inline Method private endRequestAndStopApplication() : void inlined to protected handleUnauthorized(event CommunicationProblemEvent) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Inline Method private endRequestAndStopApplication() : void inlined to private handleUnrecoverableCommunicationError(details String, event CommunicationProblemEvent) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Push Down Attribute	2
Push Down Attribute private uiBinder : MyUiBinder from class com.vaadin.client.communication.ReconnectDialog to private uiBinder : MyUiBinder from class com.vaadin.client.communication.DefaultReconnectDialog	From	To
Push Down Attribute public label : Label from class com.vaadin.client.communication.ReconnectDialog to public label : Label from class com.vaadin.client.communication.DefaultReconnectDialog	From	To
Move Attribute	1
Move Attribute private STYLE_RECONNECTING : String from class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler to private STYLE_RECONNECTING : String from class com.vaadin.client.communication.DefaultReconnectDialog	From	To
Move Class	1
Move Class com.vaadin.client.communication.ReconnectDialog.MyUiBinder moved to com.vaadin.client.communication.DefaultReconnectDialog.MyUiBinder	From	To
Extract Method	19
Extract Method private debug(msg String) : void extracted from public pushClosed(pushConnection PushConnection) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method protected doReconnect(payload JsonObject) : void extracted from protected handleRecoverableError(type Type, payload JsonObject) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private isReconnecting() : boolean extracted from protected handleRecoverableError(type Type, payload JsonObject) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from public pushClientTimeout(pushConnection PushConnection) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from public xhrException(event CommunicationProblemEvent) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from public xhrInvalidContent(event CommunicationProblemEvent) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method protected updateDialog() : void extracted from protected handleRecoverableError(type Type, payload JsonObject) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from public xhrOk() : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method protected scheduleReconnect(payload JsonObject) : void extracted from protected handleRecoverableError(type Type, payload JsonObject) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from public pushOk(pushConnection PushConnection) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method protected isDialogVisible() : boolean extracted from protected handleRecoverableError(type Type, payload JsonObject) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from public pushError(pushConnection PushConnection) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from public heartbeatOk() : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method protected giveUp() : void extracted from protected handleRecoverableError(type Type, payload JsonObject) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from private resolveTemporaryError(type Type, success boolean) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from public pushNotConnected(payload JsonObject) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from protected handleRecoverableError(type Type, payload JsonObject) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method protected hideDialog() : void extracted from private resolveTemporaryError(type Type, success boolean) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract Method private debug(msg String) : void extracted from public xhrInvalidStatusCode(event CommunicationProblemEvent) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler	From	To
Extract And Move Method	1
Extract And Move Method public isHigherPriorityThan(type Type) : boolean extracted from protected handleRecoverableError(type Type, payload JsonObject) : void in class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler & moved to class com.vaadin.client.communication.ReconnectingCommunicationProblemHandler.Type	From	To

b38dc12c24ca5eb0cc597309e0317e4364585433

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: