c3ad14183d72ed48088b7a5bb528e896a9797e32
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 19
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method public testKeyboardSelection() : void renamed to public testKeyboardWithMultiSelection() : void in class com.vaadin.tests.components.grid.GridSelectionTest | From | To | |
Pull Up Method | 2 | ||
Pull Up Method private toggleFirstRowSelection() : void from class com.vaadin.tests.components.grid.GridSelectionTest to protected toggleFirstRowSelection() : void from class com.vaadin.tests.components.grid.basics.GridBasicsTest | From | To | |
Pull Up Method private toggleFirstRowSelection() : void from class com.vaadin.tests.components.grid.basics.GridBasicSelectionTest to protected selectAll() : void from class com.vaadin.tests.components.grid.basics.GridBasicsTest | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type selectionModel : SelectionModel to selectionModel : SelectionModel<T> in method public SelectAllEvent(selectionModel SelectionModel<T>, allSelected boolean) in class com.vaadin.client.widget.grid.events.SelectAllEvent | From | To | |
Change Return Type | 1 | ||
Change Return Type SelectionModel to SelectionModel<T> in method public getSelectionModel() : SelectionModel<T> in class com.vaadin.client.widget.grid.events.SelectAllEvent | From | To | |
Extract Variable | 2 | ||
Extract Variable model : MultiSelectionModelImpl<DataObject> in method private switchToMultiSelect() : void from class com.vaadin.tests.components.grid.basics.GridBasics | From | To | |
Extract Variable model : MultiSelectionModelImpl<String> in method protected setup(request VaadinRequest) : void from class com.vaadin.tests.components.grid.GridMultiSelectionOnInit | From | To | |
Change Variable Type | 4 | ||
Change Variable Type listener : SingleSelectionListener<String> to listener : MultiSelectionListener<String> in method public addValueChangeListener() : void in class com.vaadin.tests.components.grid.GridMultiSelectionModelTest | From | To | |
Change Variable Type select : SingleSelectionModelImpl<String> to select : MultiSelectionModelImpl<String> in method public addValueChangeListener() : void in class com.vaadin.tests.components.grid.GridMultiSelectionModelTest | From | To | |
Change Variable Type event : AtomicReference<ValueChangeEvent<?>> to event : AtomicReference<MultiSelectionEvent<String>> in method public addValueChangeListener() : void in class com.vaadin.tests.components.grid.GridMultiSelectionModelTest | From | To | |
Change Variable Type selectionListener : AtomicReference<SingleSelectionListener<String>> to selectionListener : AtomicReference<MultiSelectionListener<String>> in method public addValueChangeListener() : void in class com.vaadin.tests.components.grid.GridMultiSelectionModelTest | From | To | |
Extract Method | 7 | ||
Extract Method protected doSetSelectAllCheckBoxVisible() : void extracted from protected setDefaultHeaderContent(selectionCell HeaderCell) : void in class com.vaadin.client.widgets.Grid.SelectionColumn | From | To | |
Extract Method private switchToMultiSelect() : void extracted from private createSelectionMenu(stateItem MenuItem) : void in class com.vaadin.tests.components.grid.basics.GridBasics | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type selectionModel : SelectionModel to selectionModel : SelectionModel<T> in class com.vaadin.client.widget.grid.events.SelectAllEvent | From | To | |
Extract And Move Method | 3 | ||
Extract And Move Method protected getSelectAllCheckbox() : WebElement extracted from public testServerSideSelectTogglesSelectAllCheckBox() : void in class com.vaadin.tests.components.grid.GridSelectionTest & moved to class com.vaadin.tests.components.grid.basics.GridBasicsTest | From | To | |
Extract And Move Method protected isSelected(item JsonObject) : boolean extracted from public isSelected(item JsonObject) : boolean in class com.vaadin.client.connectors.grid.MultiSelectionModelConnector.MultiSelectionModel & moved to class com.vaadin.client.connectors.grid.MultiSelectionModelConnector | From | To | |
Extract And Move Method protected deselectAll() : void extracted from public testServerSideSelectTogglesSelectAllCheckBox() : void in class com.vaadin.tests.components.grid.GridSelectionTest & moved to class com.vaadin.tests.components.grid.basics.GridBasicsTest | From | To |