f76cc830efa7f4823e8eed272de8b5ca2cfebfc3
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public isKeyStored(itemKey String) : boolean renamed to private getChildrenStream(parent T, includeParent boolean) : Stream<T> in class com.vaadin.data.provider.HierarchyMapper | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method private doFetchQuery(start int, length int, parentItem T) : Stream<T> from class com.vaadin.data.provider.HierarchicalDataCommunicator to protected fetchItemsWithRange(offset int, limit int) : List<T> from class com.vaadin.data.provider.DataCommunicator | From | To | |
| Pull Up Method private doSizeQuery(parentItem T) : int from class com.vaadin.data.provider.HierarchicalDataCommunicator to protected getDataProviderSize() : int from class com.vaadin.data.provider.DataCommunicator | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private createDataObject(item T, depth int) : JsonObject from class com.vaadin.data.provider.HierarchicalDataCommunicator to public generateData(item T, jsonObject JsonObject) : void from class com.vaadin.data.provider.HierarchyMapper | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type rowIndex : int to item : T in method public getParentIndex(item T) : Integer in class com.vaadin.data.provider.HierarchicalDataCommunicator | From | To | |
| Change Parameter Type depth : int to jsonObject : JsonObject in method public generateData(item T, jsonObject JsonObject) : void in class com.vaadin.data.provider.HierarchyMapper | From | To | |
| Change Return Type | 3 | ||
| Change Return Type JsonObject to void in method public generateData(item T, jsonObject JsonObject) : void in class com.vaadin.data.provider.HierarchyMapper | From | To | |
| Change Return Type Stream<T> to List<T> in method protected fetchItemsWithRange(offset int, limit int) : List<T> in class com.vaadin.data.provider.DataCommunicator | From | To | |
| Change Return Type boolean to Stream<T> in method private getChildrenStream(parent T, includeParent boolean) : Stream<T> in class com.vaadin.data.provider.HierarchyMapper | From | To | |
| Extract Variable | 1 | ||
| Extract Variable item : T in method public setNodeCollapsed(rowKey String, rowIndex int, collapse boolean, userOriginated boolean) : void from class com.vaadin.ui.TreeGrid.TreeGrid.registerRpc | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type mapper : HierarchyMapper to mapper : HierarchyMapper<T,?> in class com.vaadin.data.provider.HierarchicalDataCommunicator | From | To | |
| Extract Method | 3 | ||
| Extract Method protected getDataProviderSize() : int extracted from protected sendDataToClient(initial boolean) : void in class com.vaadin.data.provider.DataCommunicator | From | To | |
| Extract Method protected fetchItemsWithRange(offset int, limit int) : List<T> extracted from protected sendDataToClient(initial boolean) : void in class com.vaadin.data.provider.DataCommunicator | From | To | |
| Extract Method protected setFilter(filter F) : void extracted from public setDataProvider(dataProvider DataProvider<T,F>, initialFilter F) : SerializableConsumer<F> in class com.vaadin.data.provider.DataCommunicator | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public setFilter(filter Object) : void extracted from public setDataProvider(dataProvider DataProvider<T,F>, initialFilter F) : SerializableConsumer<F> in class com.vaadin.data.provider.DataCommunicator & moved to class com.vaadin.data.provider.HierarchyMapper | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter rowIndex : int to item : T in method public getParentIndex(item T) : Integer in class com.vaadin.data.provider.HierarchicalDataCommunicator | From | To | |
| Rename Parameter depth : int to jsonObject : JsonObject in method public generateData(item T, jsonObject JsonObject) : void in class com.vaadin.data.provider.HierarchyMapper | From | To |