fd9d5d3eb14b15c98c9ab6e5ec053aec852e7810
Files Diff
- Added: 9
- Removed: 10
- Renamed: 0
- Modified: 41
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private createMessage(messages List<String>, objectName String) : String from class com.galenframework.validation.specs.SpecValidationGeneral to public joinMessages(messages List<String>, separator String) : String from class com.galenframework.validation.ValidationUtils | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type spec : T to spec : Spec in method public verifyLocation(mainArea Rect, secondArea Rect, location Location, pageValidation PageValidation, spec Spec, offsetProvider OffsetProvider) : String in class com.galenframework.validation.ValidationUtils | From | To | |
| Change Parameter Type spec : SpecOn to spec : Spec in method public getOffsetForSide(mainArea Rect, secondArea Rect, side Side, spec Spec) : int in class com.galenframework.validation.specs.SpecValidationOn | From | To | |
| Move Method | 3 | ||
| Move Method protected verifyLocation(mainArea Rect, secondArea Rect, location Location, pageValidation PageValidation, spec T) : String from class com.galenframework.validation.specs.SpecValidationGeneral to public verifyLocation(mainArea Rect, secondArea Rect, location Location, pageValidation PageValidation, spec Spec, offsetProvider OffsetProvider) : String from class com.galenframework.validation.ValidationUtils | From | To | |
| Move Method protected rangeCalculatedFromPercentage(range Range, objectValue int) : String from class com.galenframework.validation.SpecValidation to public rangeCalculatedFromPercentage(range Range, objectValue int) : String from class com.galenframework.validation.ValidationUtils | From | To | |
| Move Method private takeNonNullValue(from RangeValue, to RangeValue) : RangeValue from class com.galenframework.validation.SpecValidation to private takeNonNullValue(from RangeValue, to RangeValue) : RangeValue from class com.galenframework.validation.ValidationUtils | From | To | |
| Rename Variable | 2 | ||
| Rename Variable error : ValidationError to realResult : ValidationResult in method public shouldGiveError(expectedResult ValidationResult, spec Spec, page MockedPage) : void in class com.galenframework.tests.validation.ValidationTestBase | From | To | |
| Rename Variable spec : SpecOn to specOn : SpecOn in method public getOffsetForSide(mainArea Rect, secondArea Rect, side Side, spec Spec) : int in class com.galenframework.validation.specs.SpecValidationOn | From | To | |
| Extract Class | 1 | ||
| Extract Class com.galenframework.validation.ValidationUtils from class com.galenframework.validation.SpecValidation | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.galenframework.validation.specs.SpecValidationComplex from classes [com.galenframework.validation.specs.SpecValidationInside, com.galenframework.validation.specs.SpecValidationNear] | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type error : ValidationError to realResult : ValidationResult in method public shouldGiveError(expectedResult ValidationResult, spec Spec, page MockedPage) : void in class com.galenframework.tests.validation.ValidationTestBase | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter objectName : String to separator : String in method public joinMessages(messages List<String>, separator String) : String in class com.galenframework.validation.ValidationUtils | From | To |